Skip to content

🎥 Make videos programmatically with React

Fix Browser Studio document title

Jonny Burgerb91f119a4c09
diff --git a/packages/browser-studio/e2e/browser-studio.test.ts b/packages/browser-studio/e2e/browser-studio.test.ts
index 3a3bcc77d2..442c76daa0 100644
--- a/packages/browser-studio/e2e/browser-studio.test.ts
+++ b/packages/browser-studio/e2e/browser-studio.test.ts
@@ -195,6 +195,10 @@ test('loads Browser Studio, opens external links, and can add, delete, and dupli
studio.locator('.remotion-studio-composition-container'),
).toBeVisible();
await expect.poll(() => new URL(page.url()).search).toBe('?/MyComp');
+ await expect(page).toHaveTitle(
+ 'MyComp / template-blank - Remotion Studio',
+ {timeout: 5000},
+ );
await studio.locator('button:has(svg[viewBox="0 0 415 426"])').click();
const popupPromise = page.waitForEvent('popup');
await studio.getByText('About Remotion', {exact: true}).click();
@@ -329,8 +333,16 @@ test('loads Browser Studio, opens external links, and can add, delete, and dupli
studio.getByTitle('/project').getByText('MyComp1'),
).toBeVisible();
await expect.poll(() => new URL(page.url()).search).toBe('?/MyComp1');
+ await expect(page).toHaveTitle(
+ 'MyComp1 / template-blank - Remotion Studio',
+ {timeout: 5000},
+ );
await page.goBack();
await expect.poll(() => new URL(page.url()).search).toBe('?/MyComp');
+ await expect(page).toHaveTitle(
+ 'MyComp / template-blank - Remotion Studio',
+ {timeout: 5000},
+ );
await studio.getByRole('button', {name: 'Render on web'}).click();
await expect(
studio.getByText('Render MyComp', {exact: true}),
diff --git a/packages/studio/src/helpers/document-title.ts b/packages/studio/src/helpers/document-title.ts
index 633e9be7da..1f7523bce6 100644
--- a/packages/studio/src/helpers/document-title.ts
+++ b/packages/studio/src/helpers/document-title.ts
@@ -1,6 +1,7 @@
import {NoReactInternals} from 'remotion/no-react';
import type {AnyRenderJob} from '../components/RenderQueue/context';
import {isClientRenderJob} from '../components/RenderQueue/context';
+import {getNavigationWindow} from './url-state';
let currentItemName: string | null = null;
let renderJobs: AnyRenderJob[] = [];
@@ -27,13 +28,13 @@ const suffix = `- ${productName}`;
const updateTitle = () => {
if (!currentItemName) {
- document.title = productName;
+ getNavigationWindow().document.title = productName;
return;
}
const currentCompTitle = `${currentItemName} / ${window.remotion_projectName}`;
- document.title = [
+ getNavigationWindow().document.title = [
getProgressInBrackets(currentItemName, renderJobs),
`${currentCompTitle} ${suffix}`,
]