🎥 Make videos programmatically with React
`@remotion/studio`: Fix LUT drop highlighting and document LUT imports
Jonny Burgerc3302f2f4b50
diff --git a/packages/docs/docs/color-correction.mdx b/packages/docs/docs/color-correction.mdxindex bc80a64678..eff55ea1ae 100644--- a/packages/docs/docs/color-correction.mdx+++ b/packages/docs/docs/color-correction.mdx@@ -80,7 +80,23 @@ Effects are applied in array order. Place `colorCorrection()` before `lut()` to## Previewing LUTs in the Studio-You can drop .cube files into your public folder and preview LUTs by clicking on them in the Assets panel.+You can drop `.cube` files into your [public folder](/docs/assets) and preview LUTs by clicking on them in the Assets panel.++## Applying LUTs in the Studio<AvailableFrom v="4.0.535" />++Drag a 3D `.cube` file from your computer or the Assets panel onto a video in the canvas or timeline.+Studio adds a [`lut()`](/docs/effects/lut) effect to the video's source code and opens its inspector.++<video+ src="https://remotion.media/studio/lut-drop-demo-v1.mp4"+ autoPlay+ loop+ muted+ playsInline+ controls+ aria-label="Dragging a Cube LUT onto a video in Remotion Studio"+ style={{width: '100%', borderRadius: 'var(--ifm-global-radius)'}}+/>## See alsodiff --git a/packages/studio/src/components/Canvas.tsx b/packages/studio/src/components/Canvas.tsxindex 4bf0eb53b5..c49cb3ca07 100644--- a/packages/studio/src/components/Canvas.tsx+++ b/packages/studio/src/components/Canvas.tsx@@ -760,6 +760,11 @@ export const Canvas: React.FC<{}if (isEffectDragOverTarget(event)) {+ event.preventDefault();+ if (event.dataTransfer) {+ event.dataTransfer.dropEffect = 'copy';+ }+setCompositionDropPreview(null);return;}diff --git a/packages/studio/src/components/SelectedOutlinePolygon.tsx b/packages/studio/src/components/SelectedOutlinePolygon.tsxindex ed47c05929..0480344d40 100644--- a/packages/studio/src/components/SelectedOutlinePolygon.tsx+++ b/packages/studio/src/components/SelectedOutlinePolygon.tsx@@ -16,6 +16,7 @@ import {EditorSnappingContext} from '../state/editor-snapping';import {addEffectFromDrop,hasEffectDragType,+ isLutEffectDrop,LUT_EFFECT_DROP_TARGET_ATTR,} from './effect-drag-and-drop';import {@@ -422,7 +423,10 @@ const SelectedOutlinePolygonUnmemoized: React.FC<{const onEffectDrop = React.useCallback(async (event: React.DragEvent<SVGPolygonElement>) => {- if (!hasEffectDragType(event.dataTransfer)) {+ if (+ !hasEffectDragType(event.dataTransfer) &&+ !isLutEffectDrop(event.nativeEvent)+ ) {return;}diff --git a/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx b/packages/studio/src/components/Timeline/TimelineSequenceItem.tsxindex d5c91ffbe2..ed2e948f55 100644--- a/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx+++ b/packages/studio/src/components/Timeline/TimelineSequenceItem.tsx@@ -61,6 +61,7 @@ import {ContextMenu} from '../ContextMenu';import {addEffectFromDrop,hasEffectDragType,+ isLutEffectDrop,LUT_EFFECT_DROP_TARGET_ATTR,} from '../effect-drag-and-drop';import {@@ -1633,7 +1634,7 @@ const TimelineSequenceItemInner: React.FC<{previewServerState.type !== 'connected' ||nodePathInfo === null ||validatedLocation === null ||- !hasEffectDragType(e.dataTransfer)+ (!hasEffectDragType(e.dataTransfer) && !isLutEffectDrop(e.nativeEvent))) {return;}diff --git a/packages/studio/src/components/Timeline/use-timeline-asset-drop.ts b/packages/studio/src/components/Timeline/use-timeline-asset-drop.tsindex 74a3771900..a181e03f29 100644--- a/packages/studio/src/components/Timeline/use-timeline-asset-drop.ts+++ b/packages/studio/src/components/Timeline/use-timeline-asset-drop.ts@@ -104,6 +104,8 @@ export const useTimelineAssetDrop = () => {}if (isEffectDragOverTarget(event)) {+ event.preventDefault();+ dataTransfer.dropEffect = 'copy';setAssetDropFrame(null);return;}diff --git a/packages/studio/src/components/effect-drag-and-drop.ts b/packages/studio/src/components/effect-drag-and-drop.tsindex 2054583c48..f6c4323fae 100644--- a/packages/studio/src/components/effect-drag-and-drop.ts+++ b/packages/studio/src/components/effect-drag-and-drop.ts@@ -30,9 +30,7 @@ export const hasExplicitEffectDragType = (dataTransfer: DataTransfer) => {export const hasEffectDragType = (dataTransfer: DataTransfer) => {return (hasExplicitEffectDragType(dataTransfer) ||- Array.from(dataTransfer.types).includes(LUT_ASSET_DRAG_TYPE) ||- // File names are unavailable during native file drags until the drop.- Array.from(dataTransfer.types).includes('Files')+ Array.from(dataTransfer.types).includes(LUT_ASSET_DRAG_TYPE));};@@ -61,7 +59,9 @@ export const isLutEffectDrop = (event: DragEvent) => {export const isEffectDragOverTarget = (event: DragEvent) => {return (event.dataTransfer !== null &&- hasEffectDragType(event.dataTransfer) &&+ (hasEffectDragType(event.dataTransfer) ||+ // File names are unavailable during native file drags until the drop.+ Array.from(event.dataTransfer.types).includes('Files')) &&event.target instanceof Element &&event.target.closest(`[${LUT_EFFECT_DROP_TARGET_ATTR}="true"]`) !== null);