Skip to content

🎥 Make videos programmatically with React

Use icon-only caption import action

JonnyBurgerce300cd38246
diff --git a/packages/example/e2e/captions-inspector.test.mts b/packages/example/e2e/captions-inspector.test.mts
index 48156f2638..fd3ff44562 100644
--- a/packages/example/e2e/captions-inspector.test.mts
+++ b/packages/example/e2e/captions-inspector.test.mts
@@ -101,7 +101,7 @@ test.describe('captions inspector', () => {
await expect(defaultCaption).toBeEnabled();
const importCaptionsButton = page.getByRole('button', {
- name: 'Import',
+ name: 'Import captions',
exact: true,
});
const importCaptionsInput = page.getByLabel('Import captions file');
diff --git a/packages/studio/src/components/CaptionInspector.tsx b/packages/studio/src/components/CaptionInspector.tsx
index ae453b4ac9..3ddb7556c1 100644
--- a/packages/studio/src/components/CaptionInspector.tsx
+++ b/packages/studio/src/components/CaptionInspector.tsx
@@ -1,10 +1,11 @@
import type {Caption} from '@remotion/captions';
import React, {useCallback, useRef, useState} from 'react';
-import {CURRENT_COLOR, LIGHT_TEXT} from '../helpers/colors';
+import {LIGHT_TEXT} from '../helpers/colors';
+import {FOCUS_VISIBLE_ONLY_CLASS_NAME} from '../helpers/hoverable';
import {UploadIcon} from '../icons/upload';
import {SetSelectedModalContext} from '../state/modals';
-import {Button} from './Button';
import {CaptionTextEditor} from './CaptionTextEditor';
+import {InlineAction} from './InlineAction';
import {CollapsibleInspectorSectionHeader} from './InspectorPanel/CollapsibleInspectorSectionHeader';
import {InspectorSectionHeader} from './InspectorPanel/common';
import {sectionHeaderEnd} from './InspectorPanel/styles';
@@ -131,25 +132,22 @@ export const CaptionInspector: React.FC<{
onChange={onFileSelected}
type="file"
/>
- <Button
- buttonContainerStyle={{
- alignItems: 'center',
- display: 'flex',
- gap: 4,
- }}
+ <InlineAction
+ aria-label="Import captions"
+ className={FOCUS_VISIBLE_ONLY_CLASS_NAME}
disabled={isImporting}
onClick={openCaptionSelection}
- size="condensed"
+ renderAction={(color) => (
+ <UploadIcon
+ aria-hidden="true"
+ color={color}
+ focusable="false"
+ style={{height: 14, width: 14}}
+ />
+ )}
title={importTooltip}
- >
- <UploadIcon
- aria-hidden="true"
- color={CURRENT_COLOR}
- focusable="false"
- style={{height: 12, width: 12}}
- />
- {isImporting ? 'Importing…' : 'Import'}
- </Button>
+ variant={null}
+ />
</>
)}
{readOnly ? (
diff --git a/packages/studio/src/test/caption-inspector-import.test.tsx b/packages/studio/src/test/caption-inspector-import.test.tsx
index 24ca88fe72..2912f76edc 100644
--- a/packages/studio/src/test/caption-inspector-import.test.tsx
+++ b/packages/studio/src/test/caption-inspector-import.test.tsx
@@ -53,7 +53,7 @@ test('imports captions from a JSON file in the public folder', async () => {
</SetSelectedModalContext.Provider>,
);
- fireEvent.click(screen.getByRole('button', {name: 'Import'}));
+ fireEvent.click(screen.getByRole('button', {name: 'Import captions'}));
const modal = selectedModal as ModalState | null;
if (modal?.type !== 'quick-switcher' || modal.assetSelection === null) {
throw new Error('Expected asset Quick Switcher to open');