Skip to content

🎥 Make videos programmatically with React

@remotion/studio: Replace title tooltips with accessible names

JonnyBurgerd68336c5a897
diff --git a/packages/browser-studio/src/BrowserStudio.tsx b/packages/browser-studio/src/BrowserStudio.tsx
index 3b7c8b962d..90a94a0c9c 100644
--- a/packages/browser-studio/src/BrowserStudio.tsx
+++ b/packages/browser-studio/src/BrowserStudio.tsx
@@ -848,7 +848,7 @@ export const BrowserStudio: React.FC<BrowserStudioProps> = ({
sandbox="allow-scripts allow-same-origin allow-downloads allow-popups allow-popups-to-escape-sandbox"
src={iframeSrc ?? 'about:blank'}
style={iframeStyle}
- title="Remotion Studio"
+ aria-label="Remotion Studio"
/>
) : null}
{state.status === 'compiling' && iframeHtml === null ? (
diff --git a/packages/studio/src/components/AgentPrompt.tsx b/packages/studio/src/components/AgentPrompt.tsx
index d628bb630d..f47d797eb1 100644
--- a/packages/studio/src/components/AgentPrompt.tsx
+++ b/packages/studio/src/components/AgentPrompt.tsx
@@ -128,7 +128,7 @@ export const AgentPrompt: React.FC<{
onClick={() => copy(installCommand, markInstallCopied)}
renderAction={renderInstallCopy}
style={copyAction}
- title="Copy command"
+ aria-label="Copy command"
variant={null}
/>
</div>
@@ -179,7 +179,7 @@ export const AgentPrompt: React.FC<{
onClick={() => copy(prompt, markPromptCopied)}
renderAction={renderPromptCopy}
style={copyAction}
- title="Copy prompt"
+ aria-label="Copy prompt"
variant={null}
/>
</div>
diff --git a/packages/studio/src/components/AppLaunchButton.tsx b/packages/studio/src/components/AppLaunchButton.tsx
index 4d2cc296c5..932d7eab10 100644
--- a/packages/studio/src/components/AppLaunchButton.tsx
+++ b/packages/studio/src/components/AppLaunchButton.tsx
@@ -40,7 +40,6 @@ export const AppLaunchButton: React.FC<{
readonly onClick: React.MouseEventHandler<HTMLButtonElement>;
readonly size: 'compact' | 'default';
readonly style: React.CSSProperties | null;
- readonly title: string;
}> = ({
actionButtonId,
ariaLabel,
@@ -53,7 +52,6 @@ export const AppLaunchButton: React.FC<{
onClick,
size,
style,
- title,
}) => {
const items = useMemo(() => {
return [
@@ -79,7 +77,6 @@ export const AppLaunchButton: React.FC<{
size === 'default'
? defaultMainSegmentStyle
: compactMainSegmentStyle,
- title,
tooltipLabel: null,
type: 'action',
},
@@ -100,7 +97,6 @@ export const AppLaunchButton: React.FC<{
segmentId: 'another-app',
selectedId: null,
style: dropdownSegmentStyle,
- title: menuAriaLabel,
tooltipLabel: null,
type: 'menu' as const,
values: items,
@@ -118,14 +114,12 @@ export const AppLaunchButton: React.FC<{
menuButtonId,
onClick,
size,
- title,
]);
return (
<SegmentedButton
segments={segments}
style={{...(size === 'default' ? {height: 41} : null), ...style}}
- title={null}
/>
);
};
diff --git a/packages/studio/src/components/AssetAudioVolume.tsx b/packages/studio/src/components/AssetAudioVolume.tsx
index 792e7b7d11..06e0964114 100644
--- a/packages/studio/src/components/AssetAudioVolume.tsx
+++ b/packages/studio/src/components/AssetAudioVolume.tsx
@@ -30,13 +30,14 @@ export const AssetAudioVolume: React.FC<{
return (
<span
+ role="group"
style={{
fontFamily: 'sans-serif',
fontSize: 13,
lineHeight: '20px',
color: LIGHT_TEXT,
}}
- title="RMS level across all channels over the full audio track, including silence."
+ aria-label="RMS level across all channels over the full audio track, including silence."
>
{value}
</span>
diff --git a/packages/studio/src/components/AssetSelectorItem.tsx b/packages/studio/src/components/AssetSelectorItem.tsx
index 9e6a1c3693..9f31fd30dd 100644
--- a/packages/studio/src/components/AssetSelectorItem.tsx
+++ b/packages/studio/src/components/AssetSelectorItem.tsx
@@ -355,10 +355,11 @@ const AssetFolderItem: React.FC<{
<ContextMenu getItems={getContextMenuItems}>
<Row align="center">
<div
+ role="group"
style={folderStyle}
className={`${HOVERABLE_CLASS_NAME} ${HOVER_GROUP_CLASS_NAME}`}
tabIndex={tabIndex}
- title={item.name}
+ aria-label={item.name}
onClick={onClick}
onDragEnter={(event) => {
if (!isAssetUploadDragEvent(event)) {
@@ -391,7 +392,7 @@ const AssetFolderItem: React.FC<{
<Spacing x={0.5} />
<InlineDropdown
variant={null}
- title="More actions"
+ aria-label="More actions"
renderAction={renderContextMenuAction}
getItems={getContextMenuItems}
style={NO_HOVER_BACKGROUND_STYLE}
@@ -626,6 +627,7 @@ const AssetSelectorItem: React.FC<{
<Row align="center">
<div
ref={rowRef}
+ role="group"
style={style}
className={`${HOVERABLE_CLASS_NAME} ${HOVER_GROUP_CLASS_NAME}`}
onClick={onClick}
@@ -633,7 +635,7 @@ const AssetSelectorItem: React.FC<{
onDragStart={onDragStart}
onDragEnd={onDragEnd}
tabIndex={tabIndex}
- title={item.name}
+ aria-label={item.name}
>
<AssetFileIcon
fileType={previewFileType}
@@ -650,7 +652,7 @@ const AssetSelectorItem: React.FC<{
<Spacing x={0.5} />
<InlineDropdown
variant={null}
- title="More actions"
+ aria-label="More actions"
renderAction={renderContextMenuAction}
getItems={getContextMenuItems}
style={NO_HOVER_BACKGROUND_STYLE}
@@ -661,7 +663,7 @@ const AssetSelectorItem: React.FC<{
<Spacing x={0.5} />
<InlineAction
variant={null}
- title={`Show in ${fileManagerName}`}
+ aria-label={`Show in ${fileManagerName}`}
renderAction={renderFileExplorerAction}
onClick={revealInExplorer}
style={NO_HOVER_BACKGROUND_STYLE}
diff --git a/packages/studio/src/components/Button.tsx b/packages/studio/src/components/Button.tsx
index 2703c76971..a74027c2a2 100644
--- a/packages/studio/src/components/Button.tsx
+++ b/packages/studio/src/components/Button.tsx
@@ -31,7 +31,7 @@ export type ButtonProps = {
readonly style?: React.CSSProperties;
readonly buttonContainerStyle?: React.CSSProperties;
readonly autoFocus?: boolean;
- readonly title?: string;
+ readonly 'aria-label'?: string;
readonly id?: string;
readonly onPointerDown?: React.PointerEventHandler<HTMLButtonElement>;
};
@@ -43,7 +43,7 @@ const ButtonRefForwardFunction: React.ForwardRefRenderFunction<
{
children,
onClick,
- title,
+ 'aria-label': ariaLabel,
disabled,
size = 'default',
style,
@@ -98,7 +98,7 @@ const ButtonRefForwardFunction: React.ForwardRefRenderFunction<
onClick={onClick}
onPointerDown={onPointerDown}
autoFocus={autoFocus}
- title={title}
+ aria-label={ariaLabel}
>
<div className="css-reset" style={buttonContainer}>
{children}
diff --git a/packages/studio/src/components/CaptionInspector.tsx b/packages/studio/src/components/CaptionInspector.tsx
index 3da0a1752e..1504eee212 100644
--- a/packages/studio/src/components/CaptionInspector.tsx
+++ b/packages/studio/src/components/CaptionInspector.tsx
@@ -138,6 +138,7 @@ export const CaptionInspector: React.FC<{
/>
<InlineAction
aria-label="Import captions"
+ aria-description={importTooltip}
className={FOCUS_VISIBLE_ONLY_CLASS_NAME}
disabled={isImporting}
onClick={openCaptionSelection}
@@ -149,13 +150,16 @@ export const CaptionInspector: React.FC<{
style={{height: 14, width: 14}}
/>
)}
- title={importTooltip}
variant={null}
/>
</>
)}
{readOnly ? (
- <div style={readOnlyStatus} title={readOnlyTitle ?? undefined}>
+ <div
+ role="group"
+ style={readOnlyStatus}
+ aria-label={readOnlyTitle ?? undefined}
+ >
Read only
</div>
) : null}
diff --git a/packages/studio/src/components/CaptionTextEditor.tsx b/packages/studio/src/components/CaptionTextEditor.tsx
index bd5a7187cb..1a05615c11 100644
--- a/packages/studio/src/components/CaptionTextEditor.tsx
+++ b/packages/studio/src/components/CaptionTextEditor.tsx
@@ -231,7 +231,7 @@ export const CaptionTextEditor: React.FC<{
style={{height: 16, width: 16}}
/>
)}
- title={pageBreakTitle}
+ aria-label={pageBreakTitle}
variant={null}
/>
</div>
diff --git a/packages/studio/src/components/CheckboardToggle.tsx b/packages/studio/src/components/CheckboardToggle.tsx
index 6027ef30ab..7518f1b35f 100644
--- a/packages/studio/src/components/CheckboardToggle.tsx
+++ b/packages/studio/src/components/CheckboardToggle.tsx
@@ -33,7 +33,6 @@ export const CheckboardToggle: React.FC = () => {
dismissOnClick={false}
>
<ControlButton
- title=""
aria-label={accessibilityLabel}
aria-pressed={checkerboard}
aria-keyshortcuts={
diff --git a/packages/studio/src/components/CodingAgentButton.tsx b/packages/studio/src/components/CodingAgentButton.tsx
index 4cf0cc8718..a81c99c952 100644
--- a/packages/studio/src/components/CodingAgentButton.tsx
+++ b/packages/studio/src/components/CodingAgentButton.tsx
@@ -88,7 +88,6 @@ export const CodingAgentButton: React.FC<{
}}
size={size}
style={style}
- title={`${label} ${defaultCodingAgent.nameWithType}`}
>
<CodingAgentIcon
codingAgentId={defaultCodingAgent.id}
diff --git a/packages/studio/src/components/ColorPicker/ColorPicker.tsx b/packages/studio/src/components/ColorPicker/ColorPicker.tsx
index 6336831e83..1947b0e134 100644
--- a/packages/studio/src/components/ColorPicker/ColorPicker.tsx
+++ b/packages/studio/src/components/ColorPicker/ColorPicker.tsx
@@ -80,7 +80,7 @@ type Props = {
readonly width?: number;
readonly height?: number;
readonly borderRadius?: number;
- readonly title?: string;
+ readonly 'aria-label'?: string;
readonly name?: string;
readonly className?: string;
readonly style?: React.CSSProperties;
@@ -94,7 +94,7 @@ export const ColorPicker: React.FC<Props> = ({
width = 45,
height = 25,
borderRadius = 3,
- title,
+ 'aria-label': ariaLabel,
name,
className,
style: customStyle,
@@ -296,7 +296,7 @@ export const ColorPicker: React.FC<Props> = ({
.join(' ')}
disabled={disabled}
name={name}
- title={title ?? value}
+ aria-label={ariaLabel ?? value}
tabIndex={tabIndex}
style={swatchStyle}
onPointerDown={onTriggerPointerDown}
@@ -312,7 +312,6 @@ export const ColorPicker: React.FC<Props> = ({
onPointerDown={onEyeDropperPointerDown}
onClick={onPickWithEyeDropper}
tabIndex={tabIndex}
- title="Pick color from screen"
aria-label="Pick color from screen"
>
<EyedropperIcon style={eyedropperIconStyle} color={CURRENT_COLOR} />
diff --git a/packages/studio/src/components/ColorPicker/ColorPickerPopup.tsx b/packages/studio/src/components/ColorPicker/ColorPickerPopup.tsx
index 1167ce2d09..c08af8c1d9 100644
--- a/packages/studio/src/components/ColorPicker/ColorPickerPopup.tsx
+++ b/packages/studio/src/components/ColorPicker/ColorPickerPopup.tsx
@@ -431,7 +431,6 @@ export const ColorPickerPopup: React.FC<{
style={eyedropperButtonStyle}
onClick={onPickWithEyeDropper}
tabIndex={tabIndex}
- title="Pick color from screen"
aria-label="Pick color from screen"
>
<EyedropperIcon
@@ -440,7 +439,7 @@ export const ColorPickerPopup: React.FC<{
/>
</button>
) : null}
- <div style={previewSwatchStyle} title={formatted}>
+ <div role="group" style={previewSwatchStyle} aria-label={formatted}>
<div style={previewFill} />
</div>
<div style={slidersColumnStyle}>
diff --git a/packages/studio/src/components/CompactExplanation.tsx b/packages/studio/src/components/CompactExplanation.tsx
index 76f26f01b6..f05d987b6b 100644
--- a/packages/studio/src/components/CompactExplanation.tsx
+++ b/packages/studio/src/components/CompactExplanation.tsx
@@ -43,11 +43,9 @@ const compactHelpIconPath: CSSProperties = {
const CompactHelpLink = ({
href,
ariaLabel,
- title,
}: {
readonly href: string;
readonly ariaLabel: string;
- readonly title: string;
}) => {
const [hovered, setHovered] = useState(false);
@@ -58,7 +56,6 @@ const CompactHelpLink = ({
rel="noopener noreferrer"
style={hovered ? compactHelpLinkHovered : compactHelpLink}
aria-label={ariaLabel}
- title={title}
onMouseEnter={() => setHovered(true)}
onMouseLeave={() => setHovered(false)}
>
@@ -96,7 +93,6 @@ export const CompactExplanation = ({
<CompactHelpLink
href={learnMoreHref}
ariaLabel={learnMoreAriaLabel ?? learnMoreTitle}
- title={learnMoreTitle}
/>
) : null}
</div>
diff --git a/packages/studio/src/components/CompositionSelectorItem.tsx b/packages/studio/src/components/CompositionSelectorItem.tsx
index 6931a4aa8b..339329eca4 100644
--- a/packages/studio/src/components/CompositionSelectorItem.tsx
+++ b/packages/studio/src/components/CompositionSelectorItem.tsx
@@ -773,7 +773,7 @@ export const CompositionSelectorItem: React.FC<{
onDragOver={onRowDragOver}
onDragLeave={onRowDragLeave}
onDrop={onRowDrop}
- title={item.folderName}
+ aria-label={item.folderName}
role="button"
aria-expanded={item.expanded}
>
@@ -850,7 +850,7 @@ export const CompositionSelectorItem: React.FC<{
onDragLeave={onRowDragLeave}
onDrop={onRowDrop}
type="button"
- title={item.composition.id}
+ aria-label={item.composition.id}
className={`__remotion-composition __remotion-composition-selector-item ${HOVERABLE_CLASS_NAME} ${HOVER_GROUP_CLASS_NAME}`}
data-compname={item.composition.id}
>
diff --git a/packages/studio/src/components/ConfigSelect.tsx b/packages/studio/src/components/ConfigSelect.tsx
index 5825644959..7250005e66 100644
--- a/packages/studio/src/components/ConfigSelect.tsx
+++ b/packages/studio/src/components/ConfigSelect.tsx
@@ -68,7 +68,7 @@ export const ConfigSelect = <T extends string | boolean>({
value === null ? DEFAULT_VALUE : `${name}-${String(value)}`
}
style={controlWidth}
- title={name}
+ aria-label={name}
/>
</div>
</div>
diff --git a/packages/studio/src/components/ConfigureDefaultEditorModal.tsx b/packages/studio/src/components/ConfigureDefaultEditorModal.tsx
index e0292376fb..c0b8629453 100644
--- a/packages/studio/src/components/ConfigureDefaultEditorModal.tsx
+++ b/packages/studio/src/components/ConfigureDefaultEditorModal.tsx
@@ -256,7 +256,7 @@ export const DefaultEditorSettings: React.FC = () => {
values={editorValues}
selectedId={selectedEditor ?? NO_PREFERENCE_ID}
style={comboBoxStyle}
- title="Default editor"
+ aria-label="Default editor"
/>
)}
</div>
@@ -277,7 +277,7 @@ export const DefaultEditorSettings: React.FC = () => {
values={codingAgentValues}
selectedId={selectedCodingAgent ?? NO_PREFERENCE_ID}
style={comboBoxStyle}
- title="Default coding agent"
+ aria-label="Default coding agent"
/>
)}
</div>
diff --git a/packages/studio/src/components/ControlButton.tsx b/packages/studio/src/components/ControlButton.tsx
index 7b4f606a25..7b6272b443 100644
--- a/packages/studio/src/components/ControlButton.tsx
+++ b/packages/studio/src/components/ControlButton.tsx
@@ -10,19 +10,17 @@ export const ControlButton = (
React.ButtonHTMLAttributes<HTMLButtonElement>,
'children' | 'onClick' | 'title'
> & {
- readonly title: string;
readonly onClick: React.MouseEventHandler<HTMLButtonElement>;
readonly children: React.ReactNode | RenderInlineAction;
},
) => {
- const {children, onClick, title, ...buttonProps} = props;
+ const {children, onClick, ...buttonProps} = props;
const renderAction: RenderInlineAction =
typeof children === 'function' ? children : () => children;
return (
<InlineAction
{...buttonProps}
- title={title}
onClick={onClick}
renderAction={renderAction}
variant={null}
diff --git a/packages/studio/src/components/CurrentAsset.tsx b/packages/studio/src/components/CurrentAsset.tsx
index 2f32a7b63e..eb034576ca 100644
--- a/packages/studio/src/components/CurrentAsset.tsx
+++ b/packages/studio/src/components/CurrentAsset.tsx
@@ -328,7 +328,7 @@ export const AssetInfo: React.FC<{
onClick={onAssetClick}
onCommit={onRename}
size={contentSized ? 'default' : 'inspector'}
- title={assetName}
+ aria-label={assetName}
/>
</InspectorInfoHeader>
{fileDetails.length > 0 ? (
diff --git a/packages/studio/src/components/ElementLibraryModal.tsx b/packages/studio/src/components/ElementLibraryModal.tsx
index 4dfc478732..a3ebe94045 100644
--- a/packages/studio/src/components/ElementLibraryModal.tsx
+++ b/packages/studio/src/components/ElementLibraryModal.tsx
@@ -48,7 +48,7 @@ export const ElementLibraryModal: React.FC<{
allow="local-network-access; loopback-network"
data-remotion-element-library=""
style={iframeStyle}
- title={`${name} library`}
+ aria-label={`${name} library`}
/>
</DismissableModal>
);
diff --git a/packages/studio/src/components/FullscreenToggle.tsx b/packages/studio/src/components/FullscreenToggle.tsx
index 8d73dd0a86..f547995d32 100644
--- a/packages/studio/src/components/FullscreenToggle.tsx
+++ b/packages/studio/src/components/FullscreenToggle.tsx
@@ -67,7 +67,6 @@ export const FullScreenToggle: React.FC<{
>
<ControlButton
id="fullscreen-toggle"
- title=""
aria-label={accessibilityLabel}
aria-keyshortcuts={
shortcutsDisabled ? undefined : ariaKeyShortcuts || undefined
diff --git a/packages/studio/src/components/InlineAction.tsx b/packages/studio/src/components/InlineAction.tsx
index 14832e0639..b15741302a 100644
--- a/packages/studio/src/components/InlineAction.tsx
+++ b/packages/studio/src/components/InlineAction.tsx
@@ -13,7 +13,7 @@ export type RenderInlineAction = (color: string) => React.ReactNode;
export type InlineActionProps = Omit<
React.ButtonHTMLAttributes<HTMLButtonElement>,
- 'children' | 'onClick' | 'style'
+ 'children' | 'onClick' | 'style' | 'title'
> & {
readonly onClick: React.MouseEventHandler<HTMLButtonElement>;
readonly renderAction: RenderInlineAction;
@@ -27,7 +27,6 @@ export const InlineAction = ({
renderAction,
onClick,
disabled,
- title,
hoveredColor = WHITE,
unhoveredColor = LIGHT_TEXT,
variant,
@@ -91,8 +90,6 @@ export const InlineAction = ({
onPointerDown={onPointerDown}
style={style}
tabIndex={tabIndex}
- title={title}
- aria-label={buttonProps['aria-label'] ?? title}
>
{renderAction(CURRENT_COLOR)}
</button>
diff --git a/packages/studio/src/components/InlineEditableTitle.tsx b/packages/studio/src/components/InlineEditableTitle.tsx
index 2d361e167f..8e731cbd83 100644
--- a/packages/studio/src/components/InlineEditableTitle.tsx
+++ b/packages/studio/src/components/InlineEditableTitle.tsx
@@ -113,7 +113,7 @@ export const InlineEditableTitle: React.FC<{
readonly onClick?: () => void;
readonly onCommit: (newValue: string) => void;
readonly size?: 'default' | 'inspector';
- readonly title?: string;
+ readonly 'aria-label'?: string;
}> = ({
value,
canRename,
@@ -121,7 +121,7 @@ export const InlineEditableTitle: React.FC<{
onClick,
onCommit,
size = 'default',
- title,
+ 'aria-label': ariaLabel,
}) => {
const [isEditing, setIsEditing] = useState(false);
const [isHovered, setIsHovered] = useState(false);
@@ -242,7 +242,8 @@ export const InlineEditableTitle: React.FC<{
return (
<div
style={isInspectorSize ? inspectorTitleWrapper : titleWrapper}
- title={title ?? value}
+ aria-label={ariaLabel ?? value}
+ role="group"
>
<span
style={innerStyle}
@@ -262,6 +263,7 @@ export const InlineEditableTitle: React.FC<{
{isEditing ? (
<input
ref={focusInput}
+ aria-label={ariaLabel ?? value}
style={{...gridItemStyle, ...inputStyle}}
value={draftValue}
onChange={onChange}
diff --git a/packages/studio/src/components/InspectorLocationCopy.tsx b/packages/studio/src/components/InspectorLocationCopy.tsx
index 8b35718cd7..8d337de86a 100644
--- a/packages/studio/src/components/InspectorLocationCopy.tsx
+++ b/packages/studio/src/components/InspectorLocationCopy.tsx
@@ -115,7 +115,7 @@ export const InspectorLocationCopy: React.FC<{
variant={null}
onClick={onCopy}
renderAction={renderCopyAction}
- title="Copy context for agents"
+ aria-label="Copy context for agents"
/>
) : null}
</div>
diff --git a/packages/studio/src/components/InspectorOpenInEditor.tsx b/packages/studio/src/components/InspectorOpenInEditor.tsx
index 0802bc8b00..d68264167a 100644
--- a/packages/studio/src/components/InspectorOpenInEditor.tsx
+++ b/packages/studio/src/components/InspectorOpenInEditor.tsx
@@ -244,7 +244,6 @@ export const InspectorOpenInEditor: React.FC<{
),
segmentId: 'default-editor',
style: mainSegmentStyle,
- title: showTooltips ? '' : `Open in ${defaultAppName}`,
tooltipLabel: showTooltips ? `Open in ${defaultAppName}` : null,
type: 'action',
},
@@ -262,7 +261,6 @@ export const InspectorOpenInEditor: React.FC<{
segmentId: 'another-app',
selectedId: null,
style: dropdownSegmentStyle,
- title: showTooltips ? '' : 'Open in another app',
tooltipLabel: showTooltips ? 'Open in another app' : null,
type: 'menu',
values: menuItems,
@@ -289,5 +287,5 @@ export const InspectorOpenInEditor: React.FC<{
return null;
}
- return <SegmentedButton segments={segments} style={null} title={null} />;
+ return <SegmentedButton segments={segments} style={null} />;
};
diff --git a/packages/studio/src/components/InspectorPanel/AlignmentControls.tsx b/packages/studio/src/components/InspectorPanel/AlignmentControls.tsx
index 330971844b..2db7f8ff40 100644
--- a/packages/studio/src/components/InspectorPanel/AlignmentControls.tsx
+++ b/packages/studio/src/components/InspectorPanel/AlignmentControls.tsx
@@ -58,14 +58,14 @@ const verticalSpacer: React.CSSProperties = {
const AlignmentButton: React.FC<{
readonly onClick: () => void;
- readonly title: string;
+ readonly 'aria-label': string;
readonly Icon: React.FC<React.SVGProps<SVGSVGElement>>;
readonly disabled: boolean;
-}> = ({onClick, title, Icon, disabled}) => {
+}> = ({onClick, 'aria-label': ariaLabel, Icon, disabled}) => {
return (
<InlineAction
variant={null}
- title={title}
+ aria-label={ariaLabel}
onClick={onClick}
renderAction={(color) => <Icon style={iconStyle} color={color} />}
disabled={disabled}
@@ -315,38 +315,38 @@ export const AlignmentControls: React.FC<{
return (
<div style={container}>
<AlignmentButton
- title="Align left"
+ aria-label="Align left"
onClick={() => handleAlign('left')}
Icon={AlignLeftIcon}
disabled={alignmentDisabled}
/>
<AlignmentButton
- title="Align center horizontally"
+ aria-label="Align center horizontally"
onClick={() => handleAlign('center-h')}
Icon={AlignCenterHorizontalIcon}
disabled={alignmentDisabled}
/>
<AlignmentButton
- title="Align right"
+ aria-label="Align right"
onClick={() => handleAlign('right')}
Icon={AlignRightIcon}
disabled={alignmentDisabled}
/>
<div style={verticalSpacer} />
<AlignmentButton
- title="Align top"
+ aria-label="Align top"
onClick={() => handleAlign('top')}
Icon={AlignTopIcon}
disabled={alignmentDisabled}
/>
<AlignmentButton
- title="Align center vertically"
+ aria-label="Align center vertically"
onClick={() => handleAlign('center-v')}
Icon={AlignCenterVerticalIcon}
disabled={alignmentDisabled}
/>
<AlignmentButton
- title="Align bottom"
+ aria-label="Align bottom"
onClick={() => handleAlign('bottom')}
Icon={AlignBottomIcon}
disabled={alignmentDisabled}
diff --git a/packages/studio/src/components/InspectorPanel/CompositionMetadata.tsx b/packages/studio/src/components/InspectorPanel/CompositionMetadata.tsx
index 171f83be77..d935dce938 100644
--- a/packages/studio/src/components/InspectorPanel/CompositionMetadata.tsx
+++ b/packages/studio/src/components/InspectorPanel/CompositionMetadata.tsx
@@ -158,10 +158,10 @@ const frameRatePresets = [23.976, 24, 25, 29.97, 30, 50, 60] as const;
const PresetDropdown: React.FC<{
readonly disabled: boolean;
- readonly title: string;
+ readonly 'aria-label': string;
readonly values: ComboboxValue[];
readonly visible: boolean;
-}> = ({disabled, title, values, visible}) => {
+}> = ({disabled, 'aria-label': ariaLabel, values, visible}) => {
const renderAction = useCallback((color: string) => {
return (
<span style={presetButtonIcon}>
@@ -180,7 +180,7 @@ const PresetDropdown: React.FC<{
<InlineDropdown
disabled={disabled}
renderAction={renderAction}
- title={title}
+ aria-label={ariaLabel}
values={values}
variant="compact"
/>
@@ -490,7 +490,7 @@ export const CompositionMetadata: React.FC<{
pendingValues.width !== undefined ||
pendingValues.height !== undefined
}
- title="Choose dimension preset"
+ aria-label="Choose dimension preset"
values={dimensionPresetValues}
visible={hovered}
/>
@@ -526,7 +526,7 @@ export const CompositionMetadata: React.FC<{
{disabled || fpsIsComputed ? null : (
<PresetDropdown
disabled={pendingValues.fps !== undefined}
- title="Choose frame rate preset"
+ aria-label="Choose frame rate preset"
values={frameRatePresetValues}
visible={hovered}
/>
diff --git a/packages/studio/src/components/InspectorPanel/EasingInspector.tsx b/packages/studio/src/components/InspectorPanel/EasingInspector.tsx
index 7841a605a0..d1d4344e33 100644
--- a/packages/studio/src/components/InspectorPanel/EasingInspector.tsx
+++ b/packages/studio/src/components/InspectorPanel/EasingInspector.tsx
@@ -295,7 +295,7 @@ export const EasingInspector: React.FC<{
<InspectorBackAction
disabled={parentSelection === null}
onClick={onSelectParent}
- title="Back to property"
+ aria-label="Back to property"
>
{fieldLabel}
</InspectorBackAction>
diff --git a/packages/studio/src/components/InspectorPanel/ElementLibraryButton.tsx b/packages/studio/src/components/InspectorPanel/ElementLibraryButton.tsx
index eadd6b7031..f84a559eb6 100644
--- a/packages/studio/src/components/InspectorPanel/ElementLibraryButton.tsx
+++ b/packages/studio/src/components/InspectorPanel/ElementLibraryButton.tsx
@@ -85,7 +85,7 @@ export const ElementLibraryButton: React.FC = () => {
const elementLibraryDropdownSegments = useMemo<SegmentedButtonSegment[]>(
() => [
{
- ariaLabel: 'Browse Elements',
+ ariaLabel: 'Choose an Element Library to browse inside Studio.',
buttonId: null,
disabled: false,
idleColor: LIGHT_TEXT,
@@ -110,7 +110,6 @@ export const ElementLibraryButton: React.FC = () => {
segmentId: 'element-library',
selectedId: null,
style: elementLibraryDropdownSegmentStyle,
- title: 'Choose an Element Library to browse inside Studio.',
tooltipLabel: null,
type: 'menu',
values: [
@@ -155,7 +154,6 @@ export const ElementLibraryButton: React.FC = () => {
<SegmentedButton
segments={elementLibraryDropdownSegments}
style={elementLibraryDropdownStyle}
- title={null}
/>
);
}
@@ -168,7 +166,7 @@ export const ElementLibraryButton: React.FC = () => {
renderIcon={(color) => (
<BrowseElementsIcon color={color} style={browseElementsIconStyle} />
)}
- title="Browse the Remotion Elements library inside Studio."
+ aria-label="Browse the Remotion Elements library inside Studio."
>
Browse Elements
</InspectorQuickAction>
diff --git a/packages/studio/src/components/InspectorPanel/KeyframeEasingNavigator.tsx b/packages/studio/src/components/InspectorPanel/KeyframeEasingNavigator.tsx
index ef7bf5cfd0..edb63586f4 100644
--- a/packages/studio/src/components/InspectorPanel/KeyframeEasingNavigator.tsx
+++ b/packages/studio/src/components/InspectorPanel/KeyframeEasingNavigator.tsx
@@ -143,11 +143,6 @@ const TimelineNavigatorItem: React.FC<{
type="button"
style={buttonStyle}
onClick={onClick}
- title={
- item.type === 'keyframe'
- ? `Keyframe at frame ${item.selection.frame}`
- : `Easing from frame ${item.selection.fromFrame} to ${item.selection.toFrame}`
- }
aria-label={
item.type === 'keyframe'
? `Select keyframe at frame ${item.selection.frame}`
@@ -252,7 +247,7 @@ export const KeyframeEasingNavigator: React.FC<{
variant={null}
disabled={previousItem === null}
onClick={selectPrevious}
- title="Previous animation item"
+ aria-label="Previous animation item"
renderAction={(color) => (
<NavigationChevron
color={previousItem === null ? disabledChevronColor : color}
@@ -289,7 +284,7 @@ export const KeyframeEasingNavigator: React.FC<{
variant={null}
disabled={nextItem === null}
onClick={selectNext}
- title="Next animation item"
+ aria-label="Next animation item"
renderAction={(color) => (
<NavigationChevron
color={nextItem === null ? disabledChevronColor : color}
diff --git a/packages/studio/src/components/InspectorPanel/KeyframeInspector.tsx b/packages/studio/src/components/InspectorPanel/KeyframeInspector.tsx
index 4f8fba7e85..211fdc098a 100644
--- a/packages/studio/src/components/InspectorPanel/KeyframeInspector.tsx
+++ b/packages/studio/src/components/InspectorPanel/KeyframeInspector.tsx
@@ -531,7 +531,7 @@ export const KeyframeInspector: React.FC<{
<InspectorBackAction
disabled={parentSelection === null}
onClick={onSelectParent}
- title="Back to property"
+ aria-label="Back to property"
>
{details.fieldLabel}
</InspectorBackAction>
diff --git a/packages/studio/src/components/InspectorPanel/KeyframeSettings.tsx b/packages/studio/src/components/InspectorPanel/KeyframeSettings.tsx
index 67d362da9e..58cefd34fd 100644
--- a/packages/studio/src/components/InspectorPanel/KeyframeSettings.tsx
+++ b/packages/studio/src/components/InspectorPanel/KeyframeSettings.tsx
@@ -214,7 +214,7 @@ export const KeyframeSettings: React.FC<{
<Combobox
values={leftValues}
selectedId={propStatus.clamping.left}
- title="Extrapolate left"
+ aria-label="Extrapolate left"
style={comboStyle}
size="small"
/>
@@ -223,7 +223,7 @@ export const KeyframeSettings: React.FC<{
<Combobox
values={rightValues}
selectedId={propStatus.clamping.right}
- title="Extrapolate right"
+ aria-label="Extrapolate right"
style={comboStyle}
size="small"
/>
@@ -232,7 +232,7 @@ export const KeyframeSettings: React.FC<{
<Combobox
values={outputValues}
selectedId={propStatus.output ?? 'linear'}
- title="Output"
+ aria-label="Output"
style={comboStyle}
size="small"
/>
diff --git a/packages/studio/src/components/InspectorPanel/MultiSequenceField.tsx b/packages/studio/src/components/InspectorPanel/MultiSequenceField.tsx
index 628229f34b..c197c7c4a1 100644
--- a/packages/studio/src/components/InspectorPanel/MultiSequenceField.tsx
+++ b/packages/studio/src/components/InspectorPanel/MultiSequenceField.tsx
@@ -176,7 +176,7 @@ export const MultiSequenceField: React.FC<{
fontSize: 12,
padding: 0,
}}
- title="Set a value for all selected sequences"
+ aria-label="Set a value for all selected sequences"
onClick={() => setEditingMixed(true)}
>
Mixed
diff --git a/packages/studio/src/components/InspectorPanel/MultiSequenceInspector.tsx b/packages/studio/src/components/InspectorPanel/MultiSequenceInspector.tsx
index a77ac15917..726c9cf631 100644
--- a/packages/studio/src/components/InspectorPanel/MultiSequenceInspector.tsx
+++ b/packages/studio/src/components/InspectorPanel/MultiSequenceInspector.tsx
@@ -227,7 +227,7 @@ export const MultiSequenceInspector: React.FC<{
<InspectorQuickAction
disabled={!canSplit}
onClick={onSplit}
- title={canSplit ? undefined : 'Studio is read-only'}
+ aria-label={canSplit ? undefined : 'Studio is read-only'}
renderIcon={(color) => (
<ScissorsIcon style={actionIconStyle} color={color} />
)}
diff --git a/packages/studio/src/components/InspectorPanel/MultiSequenceNumberField.tsx b/packages/studio/src/components/InspectorPanel/MultiSequenceNumberField.tsx
index 5f00a80d1d..91ae93ca40 100644
--- a/packages/studio/src/components/InspectorPanel/MultiSequenceNumberField.tsx
+++ b/packages/studio/src/components/InspectorPanel/MultiSequenceNumberField.tsx
@@ -101,13 +101,13 @@ const NumericAxis: React.FC<{
>
<InputDragger
type="number"
+ aria-description="Type to set all values; drag to adjust each value"
value={dragValue ?? coordinates[0]}
aria-label={
axis === null
? (field.description ?? field.key)
: `Offset ${['X', 'Y', 'Z'][axis]}`
}
- title="Type to set all values; drag to adjust each value"
status="ok"
small
rightAlign={false}
diff --git a/packages/studio/src/components/InspectorPanel/SequenceInspectorHeader.tsx b/packages/studio/src/components/InspectorPanel/SequenceInspectorHeader.tsx
index ddfda15da7..a32c7c0349 100644
--- a/packages/studio/src/components/InspectorPanel/SequenceInspectorHeader.tsx
+++ b/packages/studio/src/components/InspectorPanel/SequenceInspectorHeader.tsx
@@ -150,7 +150,7 @@ export const SequenceInspectorHeader: React.FC<{
<InspectorQuickAction
disabled={false}
style={defaultCursor}
- title="Open component docs"
+ aria-label="Open component docs"
onClick={openDocumentationLink}
>
{componentName}
diff --git a/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx b/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx
index 3e1910edb9..e615ba4937 100644
--- a/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx
+++ b/packages/studio/src/components/InspectorPanel/SequenceSelectionInspector.tsx
@@ -116,7 +116,7 @@ const SplitSequenceQuickAction: React.FC<{
<InspectorQuickAction
disabled={!canSplit}
onClick={onSplit}
- title={disabledReason}
+ aria-label={disabledReason}
renderIcon={(color) => (
<ScissorsIcon style={actionIconStyle} color={color} />
)}
@@ -292,7 +292,7 @@ const SequenceSourceQuickActions: React.FC<{
<InspectorQuickAction
disabled={videoMattingDisabledReason !== undefined}
onClick={onRemoveBackground}
- title={videoMattingDisabledReason}
+ aria-label={videoMattingDisabledReason}
renderIcon={(color) => (
<BackgroundRemovalIcon style={actionIconStyle} color={color} />
)}
@@ -304,7 +304,7 @@ const SequenceSourceQuickActions: React.FC<{
<InspectorQuickAction
disabled={splitVideoFromAudioDisabledReason !== undefined}
onClick={onSplitVideoFromAudio}
- title={splitVideoFromAudioDisabledReason}
+ aria-label={splitVideoFromAudioDisabledReason}
renderIcon={(color) => (
<AudioIcon style={actionIconStyle} color={color} />
)}
@@ -316,7 +316,7 @@ const SequenceSourceQuickActions: React.FC<{
<InspectorQuickAction
disabled={transcriptionDisabledReason !== undefined}
onClick={onGenerateCaptions}
- title={transcriptionDisabledReason}
+ aria-label={transcriptionDisabledReason}
renderIcon={(color) => (
<TranscriptionIcon style={actionIconStyle} color={color} />
)}
diff --git a/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx b/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx
index 725eefa037..0ccd24dc9f 100644
--- a/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx
+++ b/packages/studio/src/components/InspectorPanel/SequenceWrapAction.tsx
@@ -157,7 +157,10 @@ export const SequenceWrapAction: React.FC<{
const segments = useMemo<SegmentedButtonSegment[]>(
() => [
{
- ariaLabel: 'Wrap',
+ ariaLabel:
+ nodePathInfo.numberOfSequencesWithThisNodePath > 1
+ ? `Wrap all ${nodePathInfo.numberOfSequencesWithThisNodePath} instances of this JSX element`
+ : 'Wrap this JSX element',
buttonId: null,
disabled: busy,
idleColor: LIGHT_TEXT,
@@ -177,10 +180,6 @@ export const SequenceWrapAction: React.FC<{
segmentId: 'wrap',
selectedId: null,
style: segmentStyle,
- title:
- nodePathInfo.numberOfSequencesWithThisNodePath > 1
- ? `Wrap all ${nodePathInfo.numberOfSequencesWithThisNodePath} instances of this JSX element`
- : 'Wrap this JSX element',
tooltipLabel: null,
type: 'menu',
values,
@@ -193,7 +192,5 @@ export const SequenceWrapAction: React.FC<{
return null;
}
- return (
- <SegmentedButton segments={segments} style={buttonStyle} title={null} />
- );
+ return <SegmentedButton segments={segments} style={buttonStyle} />;
};
diff --git a/packages/studio/src/components/InspectorPanel/common.tsx b/packages/studio/src/components/InspectorPanel/common.tsx
index 7b917fd16a..fc91343a1a 100644
--- a/packages/studio/src/components/InspectorPanel/common.tsx
+++ b/packages/studio/src/components/InspectorPanel/common.tsx
@@ -89,15 +89,15 @@ export const InspectorBackAction: React.FC<{
readonly children: React.ReactNode;
readonly disabled: boolean;
readonly onClick: React.MouseEventHandler<HTMLButtonElement>;
- readonly title: string;
-}> = ({children, disabled, onClick, title}) => {
+ readonly 'aria-label': string;
+}> = ({children, disabled, onClick, 'aria-label': ariaLabel}) => {
return (
<div style={inspectorQuickActionsSection}>
<InspectorQuickAction
disabled={disabled}
onClick={onClick}
renderIcon={(color) => <BackArrow color={color} />}
- title={title}
+ aria-label={ariaLabel}
>
{children}
</InspectorQuickAction>
@@ -189,7 +189,7 @@ export type InspectorQuickActionProps = {
readonly renderIcon?: (color: string) => React.ReactNode;
readonly size?: 'default' | 'compact';
readonly style?: React.CSSProperties;
- readonly title?: string;
+ readonly 'aria-label'?: string;
};
export const InspectorQuickAction: React.FC<InspectorQuickActionProps> = ({
@@ -200,7 +200,7 @@ export const InspectorQuickAction: React.FC<InspectorQuickActionProps> = ({
renderIcon,
size = 'default',
style,
- title,
+ 'aria-label': ariaLabel,
}) => {
const showsHover = !disabled && onClick !== null;
const buttonStyle = React.useMemo(
@@ -236,13 +236,18 @@ export const InspectorQuickAction: React.FC<InspectorQuickActionProps> = ({
type="button"
disabled={disabled}
style={buttonStyle}
- title={title}
+ aria-label={ariaLabel}
onClick={onClick}
>
{mainContent}
</button>
) : (
- <div className={HOVERABLE_CLASS_NAME} style={buttonStyle} title={title}>
+ <div
+ className={HOVERABLE_CLASS_NAME}
+ style={buttonStyle}
+ aria-label={ariaLabel}
+ role="group"
+ >
{mainContent}
</div>
);
diff --git a/packages/studio/src/components/InspectorSequenceSection.tsx b/packages/studio/src/components/InspectorSequenceSection.tsx
index 428c2d756f..a66e7bb278 100644
--- a/packages/studio/src/components/InspectorSequenceSection.tsx
+++ b/packages/studio/src/components/InspectorSequenceSection.tsx
@@ -392,7 +392,7 @@ export const InspectorSequenceSection: React.FC<{
style={assetSelectorIcon}
/>
),
- title: linkInfo.assetPath,
+ 'aria-label': linkInfo.assetPath,
};
}
@@ -408,7 +408,7 @@ export const InspectorSequenceSection: React.FC<{
),
disabled: false,
onClick: () => openTimelineAssetLink(linkInfo, selectAsset),
- title: linkInfo.href,
+ 'aria-label': linkInfo.href,
};
}
@@ -812,7 +812,7 @@ export const InspectorSequenceSection: React.FC<{
previewServerState.type !== 'connected'
}
onClick={onConvertBorderRadius}
- title={
+ aria-label={
borderRadiusConversion === null
? borderRadiusUsesShorthand
? 'A static border radius is required to use individual corners'
@@ -836,7 +836,7 @@ export const InspectorSequenceSection: React.FC<{
variant={null}
disabled={automaticallyEnabled3DTransform}
onClick={onToggle3DTransform}
- title={
+ aria-label={
automaticallyEnabled3DTransform
? '3D controls are required by the current transform values'
: show3DTransformControls
@@ -858,7 +858,7 @@ export const InspectorSequenceSection: React.FC<{
variant={null}
disabled={!canAddEffect}
onClick={onAddEffect}
- title={canAddEffect ? 'Add effect' : undefined}
+ aria-label={canAddEffect ? 'Add effect' : undefined}
renderAction={(color) => <Plus color={color} style={plusIcon} />}
/>
}
diff --git a/packages/studio/src/components/InspectorSourceLocation.tsx b/packages/studio/src/components/InspectorSourceLocation.tsx
index fba034ffac..9e6ff78895 100644
--- a/packages/studio/src/components/InspectorSourceLocation.tsx
+++ b/packages/studio/src/components/InspectorSourceLocation.tsx
@@ -114,7 +114,7 @@ export const InspectorSourceLocation: React.FC<{
onClick={onClick}
renderIcon={(iconColor) => renderIcon?.(iconColor)}
style={quickActionStyle}
- title={fileLocation ?? undefined}
+ aria-label={fileLocation ?? undefined}
>
{label}
</InspectorQuickAction>
@@ -125,7 +125,7 @@ export const InspectorSourceLocation: React.FC<{
<button
type="button"
style={style}
- title={fileLocation ?? undefined}
+ aria-label={fileLocation ?? undefined}
onClick={onClick}
onPointerEnter={() => setHovered(true)}
onPointerLeave={() => setHovered(false)}
diff --git a/packages/studio/src/components/KeyboardShortcutsSettings.tsx b/packages/studio/src/components/KeyboardShortcutsSettings.tsx
index 61404ef22a..1642122122 100644
--- a/packages/studio/src/components/KeyboardShortcutsSettings.tsx
+++ b/packages/studio/src/components/KeyboardShortcutsSettings.tsx
@@ -475,7 +475,7 @@ export const KeyboardShortcutsSettings: React.FC = () => {
<span style={actionCell}>
<InlineDropdown
renderAction={(color) => <CaretDown color={color} />}
- title={`Actions for ${shortcut.action}`}
+ aria-label={`Actions for ${shortcut.action}`}
values={shortcutMenuItems}
variant="compact"
/>
diff --git a/packages/studio/src/components/LicenseKeyValidation.tsx b/packages/studio/src/components/LicenseKeyValidation.tsx
index c3b40efc0e..32fb9c893f 100644
--- a/packages/studio/src/components/LicenseKeyValidation.tsx
+++ b/packages/studio/src/components/LicenseKeyValidation.tsx
@@ -147,7 +147,7 @@ export const LicenseKeyDetailsDisplay: React.FC<{
<CheckCircleFilled style={{...iconStyle, fill: color}} />
)}
style={actionStyle}
- title="View license usage"
+ aria-label="View license usage"
>
<span style={actionContent}>
<span style={actionText}>Belongs to {details.projectName}</span>
@@ -165,7 +165,7 @@ export const LicenseKeyDetailsDisplay: React.FC<{
)
}
style={actionStyle}
- title="Manage Company License"
+ aria-label="Manage Company License"
>
<span style={actionContent}>
<span style={hasActiveLicense ? actionText : inactiveLicenseText}>
diff --git a/packages/studio/src/components/LoopToggle.tsx b/packages/studio/src/components/LoopToggle.tsx
index fbb796ac4f..9eff985862 100644
--- a/packages/studio/src/components/LoopToggle.tsx
+++ b/packages/studio/src/components/LoopToggle.tsx
@@ -40,7 +40,6 @@ export const LoopToggle: React.FC<{
dismissOnClick={false}
>
<ControlButton
- title=""
aria-label={accessibilityLabel}
aria-keyshortcuts={
shortcutsDisabled ? undefined : ariaShortcut || undefined
diff --git a/packages/studio/src/components/Menu/MenuSubItem.tsx b/packages/studio/src/components/Menu/MenuSubItem.tsx
index ffd4bebcee..e80984b515 100644
--- a/packages/studio/src/components/Menu/MenuSubItem.tsx
+++ b/packages/studio/src/components/Menu/MenuSubItem.tsx
@@ -187,6 +187,7 @@ export const MenuSubItem: React.FC<{
return (
<div
ref={ref}
+ aria-label={typeof label === 'string' ? label : undefined}
onPointerEnter={onPointerEnter}
onPointerLeave={onPointerLeave}
style={style}
@@ -201,13 +202,7 @@ export const MenuSubItem: React.FC<{
<Spacing x={1} />
</>
) : null}
- <div
- style={labelStyle}
- {...{title: typeof label === 'string' ? label : undefined}}
- >
- {label}
- </div>{' '}
- <Spacing x={2} />
+ <div style={labelStyle}>{label}</div> <Spacing x={2} />
{subMenu ? <CaretRight /> : null}
{keyHint && !areKeyboardShortcutsDisabled() ? (
<span style={keyHintCss}>{keyHint}</span>
diff --git a/packages/studio/src/components/MenuBuildIndicator.tsx b/packages/studio/src/components/MenuBuildIndicator.tsx
index d93f366efe..123c9bc7aa 100644
--- a/packages/studio/src/components/MenuBuildIndicator.tsx
+++ b/packages/studio/src/components/MenuBuildIndicator.tsx
@@ -62,7 +62,7 @@ export const MenuBuildIndicator: React.FC<{
}, []);
return (
- <div style={cwd} title={window.remotion_cwd}>
+ <div role="group" style={cwd} aria-label={window.remotion_cwd}>
<Spacing x={mobileLayout ? 0.5 : 2} />
{window.remotion_projectName}
<MenuCompositionName />
diff --git a/packages/studio/src/components/MenuCompositionName.tsx b/packages/studio/src/components/MenuCompositionName.tsx
index d88a78a5b4..7c9337ab87 100644
--- a/packages/studio/src/components/MenuCompositionName.tsx
+++ b/packages/studio/src/components/MenuCompositionName.tsx
@@ -117,7 +117,6 @@ export const MenuCompositionName: React.FC = () => {
hoveredColor={WHITE}
renderAction={() => composition.id}
style={compositionNameStyle}
- title="Open composition menu"
unhoveredColor={WHITE_ALPHA_80}
variant={null}
/>
diff --git a/packages/studio/src/components/ModelManager.tsx b/packages/studio/src/components/ModelManager.tsx
index 6dfc84ab66..3953aa88fb 100644
--- a/packages/studio/src/components/ModelManager.tsx
+++ b/packages/studio/src/components/ModelManager.tsx
@@ -278,7 +278,7 @@ export const ModelManager = <Model extends string>({
<div key={model.name} role="listitem" style={modelRow}>
<ModelsIcon aria-hidden color={LIGHT_TEXT} style={modelIcon} />
<span style={modelName}>{model.name}</span>
- <span style={status} title={modelStatus}>
+ <span role="group" style={status} aria-label={modelStatus}>
{modelStatus}
</span>
{cached ? (
@@ -300,7 +300,6 @@ export const ModelManager = <Model extends string>({
>
<InlineAction
aria-label={`Remove ${model.name}`}
- title=""
disabled={actionInProgress}
onClick={() => remove(model.name)}
renderAction={renderRemoveIcon}
@@ -316,7 +315,6 @@ export const ModelManager = <Model extends string>({
>
<InlineAction
aria-label={`Download ${model.name}`}
- title=""
disabled={cachedModels === null || actionInProgress}
onClick={() => downloadModel(model.name)}
renderAction={renderDownloadIcon}
diff --git a/packages/studio/src/components/MuteToggle.tsx b/packages/studio/src/components/MuteToggle.tsx
index 9a4f5f83c0..8b8a3d2a7d 100644
--- a/packages/studio/src/components/MuteToggle.tsx
+++ b/packages/studio/src/components/MuteToggle.tsx
@@ -42,7 +42,6 @@ export const MuteToggle: React.FC<{
dismissOnClick={false}
>
<ControlButton
- title=""
aria-label={accessibilityLabel}
aria-keyshortcuts={
shortcutsDisabled ? undefined : ariaShortcut || undefined
diff --git a/packages/studio/src/components/NewComposition/ComboBox.tsx b/packages/studio/src/components/NewComposition/ComboBox.tsx
index 92d8f098ab..6c0b5a5bf8 100644
--- a/packages/studio/src/components/NewComposition/ComboBox.tsx
+++ b/packages/studio/src/components/NewComposition/ComboBox.tsx
@@ -113,14 +113,14 @@ export const Combobox: React.FC<{
readonly values: ComboboxValue[];
readonly selectedId: string | number;
readonly style?: React.CSSProperties;
- readonly title: string;
+ readonly 'aria-label': string;
readonly size?: ComboboxSize;
readonly unhoveredIconColor?: string;
}> = ({
values,
selectedId,
style: customStyle,
- title,
+ 'aria-label': ariaLabel,
size: controlSize = 'default',
unhoveredIconColor = LIGHT_TEXT,
}) => {
@@ -308,7 +308,7 @@ export const Combobox: React.FC<{
<>
<button
ref={ref}
- title={title}
+ aria-label={ariaLabel}
tabIndex={tabIndex}
type="button"
style={style}
@@ -316,7 +316,8 @@ export const Combobox: React.FC<{
>
{selected ? (
<div
- title={
+ role="group"
+ aria-label={
typeof selected.label === 'string' ? selected.label : undefined
}
style={selectedLabelStyle}
diff --git a/packages/studio/src/components/NewComposition/DuplicateComposition.tsx b/packages/studio/src/components/NewComposition/DuplicateComposition.tsx
index c707e946a6..d01b7c4747 100644
--- a/packages/studio/src/components/NewComposition/DuplicateComposition.tsx
+++ b/packages/studio/src/components/NewComposition/DuplicateComposition.tsx
@@ -234,7 +234,7 @@ const DuplicateCompositionLoaded: React.FC<{
<div style={label}>Type</div>
<div style={rightRow}>
<Combobox
- title="Type of composition"
+ aria-label="Type of composition"
style={comboBoxStyle}
values={typeValues}
selectedId={type}
diff --git a/packages/studio/src/components/NewComposition/InputDragger.tsx b/packages/studio/src/components/NewComposition/InputDragger.tsx
index 6c4bb73d8d..7be4743f8c 100644
--- a/packages/studio/src/components/NewComposition/InputDragger.tsx
+++ b/packages/studio/src/components/NewComposition/InputDragger.tsx
@@ -20,7 +20,7 @@ import {
import type {RemInputStatus} from './RemInput';
import {RemotionInput, inputBaseStyle} from './RemInput';
-type Props = InputHTMLAttributes<HTMLInputElement> & {
+type Props = Omit<InputHTMLAttributes<HTMLInputElement>, 'title'> & {
readonly onValueChange: (newVal: number, source: 'input' | 'drag') => void;
readonly onValueChangeEnd?: (
newVal: number,
@@ -826,7 +826,6 @@ const InputDraggerForwardRefFn: React.ForwardRefRenderFunction<
ref={ref}
type="button"
aria-label={props['aria-label']}
- title={props.title}
className={'__remotion_input_dragger'}
style={
buttonStyle
diff --git a/packages/studio/src/components/NewComposition/NewComposition.tsx b/packages/studio/src/components/NewComposition/NewComposition.tsx
index 41bd24e5f6..b4c1119484 100644
--- a/packages/studio/src/components/NewComposition/NewComposition.tsx
+++ b/packages/studio/src/components/NewComposition/NewComposition.tsx
@@ -316,7 +316,7 @@ export const NewCompositionFields: React.FC<{
values={folderValues}
selectedId={selectedFolderId}
style={folderSelectStyle}
- title="Folder"
+ aria-label="Folder"
/>
</div>
</div>
diff --git a/packages/studio/src/components/OpenIssueButton.tsx b/packages/studio/src/components/OpenIssueButton.tsx
index 3db9bca202..01cb0bb5c1 100644
--- a/packages/studio/src/components/OpenIssueButton.tsx
+++ b/packages/studio/src/components/OpenIssueButton.tsx
@@ -44,7 +44,7 @@ export const OpenIssueButton: React.FC<{link: string}> = ({link}) => {
return (
<button
- title={buttonTooltip}
+ aria-label={buttonTooltip}
type="button"
onPointerEnter={onPointerEnter}
onPointerLeave={onPointerLeave}
diff --git a/packages/studio/src/components/OutlineToggle.tsx b/packages/studio/src/components/OutlineToggle.tsx
index 485aae0428..1be31592aa 100644
--- a/packages/studio/src/components/OutlineToggle.tsx
+++ b/packages/studio/src/components/OutlineToggle.tsx
@@ -36,7 +36,6 @@ export const OutlineToggle: React.FC = () => {
dismissOnClick={false}
>
<ControlButton
- title=""
aria-label={accessibilityLabel}
aria-keyshortcuts={
shortcutsDisabled ? undefined : ariaShortcut || undefined
diff --git a/packages/studio/src/components/PlayPause.tsx b/packages/studio/src/components/PlayPause.tsx
index 9573819f02..4734dfdb8b 100644
--- a/packages/studio/src/components/PlayPause.tsx
+++ b/packages/studio/src/components/PlayPause.tsx
@@ -284,7 +284,6 @@ const PlayPauseInner: React.FC<{
<ControlButton
aria-label="Go to beginning"
aria-keyshortcuts={jumpToBeginningAriaShortcut || undefined}
- title=""
disabled={!videoConfig}
onClick={jumpToStart}
>
@@ -302,7 +301,6 @@ const PlayPauseInner: React.FC<{
<ControlButton
aria-label="Go back 1 frame"
aria-keyshortcuts="ArrowLeft"
- title=""
disabled={!videoConfig}
onClick={oneFrameBack}
>
@@ -320,7 +318,6 @@ const PlayPauseInner: React.FC<{
<ControlButton
aria-label={playing ? 'Pause' : 'Play'}
aria-keyshortcuts={playPauseAriaShortcut || undefined}
- title=""
onClick={playing ? pause : play}
disabled={!videoConfig}
>
@@ -351,7 +348,6 @@ const PlayPauseInner: React.FC<{
<ControlButton
aria-label="Go forward 1 frame"
aria-keyshortcuts="ArrowRight"
- title=""
disabled={!videoConfig}
onClick={oneFrameForward}
>
diff --git a/packages/studio/src/components/PlaybackRateSelector.tsx b/packages/studio/src/components/PlaybackRateSelector.tsx
index 93e4490b41..1f317a056e 100644
--- a/packages/studio/src/components/PlaybackRateSelector.tsx
+++ b/packages/studio/src/components/PlaybackRateSelector.tsx
@@ -76,7 +76,7 @@ export const PlaybackRateSelector: React.FC<PlaybackRateMenuItemsProps> = ({
return (
<TimelineCombobox
- title={accessibilityLabel}
+ aria-label={accessibilityLabel}
tooltipDelay={800}
labelWidth={30}
selectedId={selectedId}
diff --git a/packages/studio/src/components/PreviewToolbarOverflowButton.tsx b/packages/studio/src/components/PreviewToolbarOverflowButton.tsx
index d48b4f278c..78813c3071 100644
--- a/packages/studio/src/components/PreviewToolbarOverflowButton.tsx
+++ b/packages/studio/src/components/PreviewToolbarOverflowButton.tsx
@@ -260,7 +260,7 @@ export const PreviewToolbarOverflowButton: React.FC<{
variant={null}
renderAction={renderAction}
values={values}
- title="More actions"
+ aria-label="More actions"
unhoveredColor={WHITE_ALPHA_80}
/>
</ActionTooltip>
diff --git a/packages/studio/src/components/QuickSwitcher/ExplorerQuickSwitcherTrigger.tsx b/packages/studio/src/components/QuickSwitcher/ExplorerQuickSwitcherTrigger.tsx
index 469e754cf0..cc6b3d345c 100644
--- a/packages/studio/src/components/QuickSwitcher/ExplorerQuickSwitcherTrigger.tsx
+++ b/packages/studio/src/components/QuickSwitcher/ExplorerQuickSwitcherTrigger.tsx
@@ -101,7 +101,7 @@ export const ExplorerQuickSwitcherTrigger: React.FC<{
</button>
<InlineDropdown
variant={null}
- title={moreActionsTitle}
+ aria-label={moreActionsTitle}
renderAction={renderMoreActions}
getItems={getActions}
className={FOCUS_VISIBLE_ONLY_CLASS_NAME}
diff --git a/packages/studio/src/components/RenderButton.tsx b/packages/studio/src/components/RenderButton.tsx
index 15e1bafb09..eceb3f0011 100644
--- a/packages/studio/src/components/RenderButton.tsx
+++ b/packages/studio/src/components/RenderButton.tsx
@@ -414,7 +414,7 @@ const RenderButtonInner: React.FC<{
const segments = useMemo((): SegmentedButtonSegment[] => {
return [
{
- ariaLabel: renderLabel,
+ ariaLabel: showRenderLabel ? tooltip : renderLabel,
buttonId: 'render-modal-button',
disabled: false,
idleColor: WHITE_ALPHA_80,
@@ -445,7 +445,6 @@ const RenderButtonInner: React.FC<{
controlSize === 'compact'
? compactMainSegmentStyle
: defaultMainSegmentStyle,
- title: showRenderLabel ? tooltip : null,
tooltipLabel: showRenderLabel ? null : renderLabel,
type: 'action',
},
@@ -463,7 +462,6 @@ const RenderButtonInner: React.FC<{
controlSize === 'compact'
? compactDropdownSegmentStyle
: defaultDropdownSegmentStyle,
- title: 'Select render type',
tooltipLabel: null,
type: 'menu',
values: dropdownValues,
@@ -505,11 +503,7 @@ const RenderButtonInner: React.FC<{
onClick={() => openServerRenderModal(true)}
type="button"
/>
- <SegmentedButton
- segments={segments}
- style={segmentedButtonStyle}
- title={showRenderLabel ? tooltip : null}
- />
+ <SegmentedButton segments={segments} style={segmentedButtonStyle} />
</>
);
};
diff --git a/packages/studio/src/components/RenderModal/InfoBubble.tsx b/packages/studio/src/components/RenderModal/InfoBubble.tsx
index ad7a0d72d2..90134c5284 100644
--- a/packages/studio/src/components/RenderModal/InfoBubble.tsx
+++ b/packages/studio/src/components/RenderModal/InfoBubble.tsx
@@ -20,10 +20,10 @@ const container: React.CSSProperties = {
};
export const InfoBubble: React.FC<{
- readonly title: string;
+ readonly 'aria-label': string;
readonly children: React.ReactNode;
readonly horizontalAlignment?: 'left' | 'right';
-}> = ({title, children, horizontalAlignment = 'left'}) => {
+}> = ({'aria-label': ariaLabel, children, horizontalAlignment = 'left'}) => {
const [hovered, setIsHovered] = useState(false);
const [opened, setOpened] = useState(false);
const ref = useRef<HTMLButtonElement>(null);
@@ -134,7 +134,7 @@ export const InfoBubble: React.FC<{
ref={ref}
tabIndex={tabIndex}
style={style}
- title={title}
+ aria-label={ariaLabel}
type="button"
>
<svg style={icon} viewBox="0 0 512 512">
diff --git a/packages/studio/src/components/RenderModal/NumberSetting.tsx b/packages/studio/src/components/RenderModal/NumberSetting.tsx
index e79cbf4bf2..737646ab94 100644
--- a/packages/studio/src/components/RenderModal/NumberSetting.tsx
+++ b/packages/studio/src/components/RenderModal/NumberSetting.tsx
@@ -55,7 +55,7 @@ export const NumberSetting: React.FC<{
{typeof hint === 'string' ? (
<OptionExplainerBubble id={hint} />
) : (
- <InfoBubble title={hint.title}>{hint.content}</InfoBubble>
+ <InfoBubble aria-label={hint.title}>{hint.content}</InfoBubble>
)}
</>
) : null}
diff --git a/packages/studio/src/components/RenderModal/OptionExplainerBubble.tsx b/packages/studio/src/components/RenderModal/OptionExplainerBubble.tsx
index f2a2880bd8..4ab8b68604 100644
--- a/packages/studio/src/components/RenderModal/OptionExplainerBubble.tsx
+++ b/packages/studio/src/components/RenderModal/OptionExplainerBubble.tsx
@@ -17,7 +17,7 @@ export const OptionExplainerBubble: React.FC<{
const option = BrowserSafeApis.options[id] as AnyRemotionOption<unknown>;
return (
- <InfoBubble title="Learn more about this option">
+ <InfoBubble aria-label="Learn more about this option">
<OptionExplainer
extraInfoRows={extraInfoRows}
option={option}
@@ -56,7 +56,7 @@ export const WebRendererCustomOptionExplainerBubble: React.FC<{
};
return (
- <InfoBubble title="Learn more about this option">
+ <InfoBubble aria-label="Learn more about this option">
<OptionExplainer
extraInfoRows={[{label: 'API option', value: apiName}]}
option={option}
diff --git a/packages/studio/src/components/RenderModal/RenderModalAdvanced.tsx b/packages/studio/src/components/RenderModal/RenderModalAdvanced.tsx
index 5b2151b5e7..02386d0c1e 100644
--- a/packages/studio/src/components/RenderModal/RenderModalAdvanced.tsx
+++ b/packages/studio/src/components/RenderModal/RenderModalAdvanced.tsx
@@ -451,7 +451,7 @@ export const RenderModalAdvanced: React.FC<{
<Combobox
values={chromeModeOptions}
selectedId={chromeModeOption}
- title="Chrome mode"
+ aria-label="Chrome mode"
/>
</div>
</div>
@@ -465,7 +465,7 @@ export const RenderModalAdvanced: React.FC<{
<Combobox
values={openGlOptions}
selectedId={openGlOption}
- title="OpenGl option"
+ aria-label="OpenGl option"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderModal/RenderModalAudio.tsx b/packages/studio/src/components/RenderModal/RenderModalAudio.tsx
index 52333b244a..c3bdec746c 100644
--- a/packages/studio/src/components/RenderModal/RenderModalAudio.tsx
+++ b/packages/studio/src/components/RenderModal/RenderModalAudio.tsx
@@ -159,7 +159,7 @@ export const RenderModalAudio: React.FC<{
<Combobox
values={audioCodecOptions(codec)}
selectedId={audioCodec}
- title="AudioCodec"
+ aria-label="AudioCodec"
/>
</div>
</div>
@@ -246,7 +246,7 @@ export const RenderModalAudio: React.FC<{
<Combobox
values={sampleRateOptions}
selectedId={String(sampleRate)}
- title="Sample Rate"
+ aria-label="Sample Rate"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderModal/RenderModalBasic.tsx b/packages/studio/src/components/RenderModal/RenderModalBasic.tsx
index d83a5c82c8..ca21529ed5 100644
--- a/packages/studio/src/components/RenderModal/RenderModalBasic.tsx
+++ b/packages/studio/src/components/RenderModal/RenderModalBasic.tsx
@@ -175,7 +175,7 @@ export const RenderModalBasic: React.FC<{
<Combobox
values={videoCodecOptions}
selectedId={codec}
- title="Codec"
+ aria-label="Codec"
/>
</div>
</div>
@@ -206,7 +206,7 @@ export const RenderModalBasic: React.FC<{
<div style={label}>ProRes profile</div>
<div style={rightRow}>
<Combobox
- title={'proResProfile' as string}
+ aria-label={'proResProfile' as string}
selectedId={proResProfile as string}
values={proResProfileOptions}
/>
@@ -243,7 +243,7 @@ export const RenderModalBasic: React.FC<{
<Combobox
values={logLevelOptions}
selectedId={logLevel}
- title="Log Level"
+ aria-label="Log Level"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderModal/RenderModalEncoding.tsx b/packages/studio/src/components/RenderModal/RenderModalEncoding.tsx
index 78a21720bd..18091126e3 100644
--- a/packages/studio/src/components/RenderModal/RenderModalEncoding.tsx
+++ b/packages/studio/src/components/RenderModal/RenderModalEncoding.tsx
@@ -350,7 +350,7 @@ export const RenderModalEncoding: React.FC<{
<Combobox
values={pixelFormatOptions}
selectedId={pixelFormat}
- title="Pixel Format"
+ aria-label="Pixel Format"
/>
</div>
</div>
@@ -364,7 +364,7 @@ export const RenderModalEncoding: React.FC<{
<Combobox
values={colorSpaceOptions}
selectedId={colorSpace}
- title="Color Space"
+ aria-label="Color Space"
/>
</div>
</div>
@@ -378,7 +378,7 @@ export const RenderModalEncoding: React.FC<{
</div>
<div style={rightRow}>
<Combobox
- title={x264Preset as string}
+ aria-label={x264Preset as string}
selectedId={x264Preset as string}
values={x264PresetOptions}
/>
@@ -420,7 +420,7 @@ export const RenderModalEncoding: React.FC<{
</div>
<div style={rightRow}>
<Combobox
- title={hardwareAcceleration as string}
+ aria-label={hardwareAcceleration as string}
selectedId={hardwareAcceleration as string}
values={hardwareAccelerationValues}
/>
diff --git a/packages/studio/src/components/RenderModal/RenderModalOutputName.tsx b/packages/studio/src/components/RenderModal/RenderModalOutputName.tsx
index 09dedcc04b..f836cf22df 100644
--- a/packages/studio/src/components/RenderModal/RenderModalOutputName.tsx
+++ b/packages/studio/src/components/RenderModal/RenderModalOutputName.tsx
@@ -115,7 +115,7 @@ export const RenderModalOutputName = ({
variant={null}
onClick={openExistingOutput}
renderAction={renderOpenIcon}
- title={`Open in ${fileManagerName}`}
+ aria-label={`Open in ${fileManagerName}`}
/>
)}
Exists, will be overwritten
diff --git a/packages/studio/src/components/RenderModal/SchemaEditor/SchemaLabel.tsx b/packages/studio/src/components/RenderModal/SchemaEditor/SchemaLabel.tsx
index 4cb0716bfd..e460f594ff 100644
--- a/packages/studio/src/components/RenderModal/SchemaEditor/SchemaLabel.tsx
+++ b/packages/studio/src/components/RenderModal/SchemaEditor/SchemaLabel.tsx
@@ -97,7 +97,7 @@ export const SchemaLabel: React.FC<{
labelContent
)}
{displayedDescription ? (
- <InfoBubble title="Field description" horizontalAlignment="right">
+ <InfoBubble aria-label="Field description" horizontalAlignment="right">
<div style={descriptionStyle}>{displayedDescription}</div>
</InfoBubble>
) : null}
diff --git a/packages/studio/src/components/RenderModal/SchemaEditor/ZodDiscriminatedUnionEditor.tsx b/packages/studio/src/components/RenderModal/SchemaEditor/ZodDiscriminatedUnionEditor.tsx
index b92dac0e0c..fde5f205c0 100644
--- a/packages/studio/src/components/RenderModal/SchemaEditor/ZodDiscriminatedUnionEditor.tsx
+++ b/packages/studio/src/components/RenderModal/SchemaEditor/ZodDiscriminatedUnionEditor.tsx
@@ -94,7 +94,7 @@ export const ZodDiscriminatedUnionEditor: React.FC<{
valid={zodValidation.success}
/>
<Combobox
- title="Select type"
+ aria-label="Select type"
values={comboBoxValues}
selectedId={value[discriminator] as string}
size="small"
diff --git a/packages/studio/src/components/RenderModal/SchemaEditor/ZodEnumEditor.tsx b/packages/studio/src/components/RenderModal/SchemaEditor/ZodEnumEditor.tsx
index 4433c6d141..3cb7c62f2e 100644
--- a/packages/studio/src/components/RenderModal/SchemaEditor/ZodEnumEditor.tsx
+++ b/packages/studio/src/components/RenderModal/SchemaEditor/ZodEnumEditor.tsx
@@ -79,7 +79,7 @@ export const ZodEnumEditor: React.FC<{
<Combobox
values={comboBoxValues}
selectedId={value}
- title={value}
+ aria-label={value}
size="small"
/>
</div>
diff --git a/packages/studio/src/components/RenderModal/SchemaEditor/ZodFieldValidation.tsx b/packages/studio/src/components/RenderModal/SchemaEditor/ZodFieldValidation.tsx
index 6358c82254..6e01811851 100644
--- a/packages/studio/src/components/RenderModal/SchemaEditor/ZodFieldValidation.tsx
+++ b/packages/studio/src/components/RenderModal/SchemaEditor/ZodFieldValidation.tsx
@@ -35,7 +35,7 @@ export const ZodFieldValidation: React.FC<{
size="compact"
/>
<Spacing x={0.5} />
- <InfoBubble title="Zod validation failure">
+ <InfoBubble aria-label="Zod validation failure">
<div style={stackTrace}>
<div style={stackTraceLabel}>Zod Validation has failed:</div>
{zodValidation.error.issues.map((error, index: number) => (
diff --git a/packages/studio/src/components/RenderModal/SchemaEditor/ZodStaticFileEditor.tsx b/packages/studio/src/components/RenderModal/SchemaEditor/ZodStaticFileEditor.tsx
index c502acf5ec..8e9fb9fa73 100644
--- a/packages/studio/src/components/RenderModal/SchemaEditor/ZodStaticFileEditor.tsx
+++ b/packages/studio/src/components/RenderModal/SchemaEditor/ZodStaticFileEditor.tsx
@@ -77,7 +77,7 @@ export const ZodStaticFileEditor: React.FC<{
<Combobox
values={comboBoxValues}
selectedId={value}
- title={value}
+ aria-label={value}
size="small"
/>
</div>
diff --git a/packages/studio/src/components/RenderModal/WebRenderModalAdvanced.tsx b/packages/studio/src/components/RenderModal/WebRenderModalAdvanced.tsx
index 8150bbb5d3..098ecd7523 100644
--- a/packages/studio/src/components/RenderModal/WebRenderModalAdvanced.tsx
+++ b/packages/studio/src/components/RenderModal/WebRenderModalAdvanced.tsx
@@ -285,7 +285,7 @@ export const WebRenderModalAdvanced: React.FC<WebRenderModalAdvancedProps> = ({
<Combobox
values={hardwareAccelerationOptions}
selectedId={hardwareAcceleration}
- title="Hardware Acceleration"
+ aria-label="Hardware Acceleration"
/>
</div>
</div>
@@ -324,7 +324,7 @@ export const WebRenderModalAdvanced: React.FC<WebRenderModalAdvancedProps> = ({
<Combobox
values={pageResponsivenessOptions}
selectedId={selectedPageResponsiveness}
- title="Page Responsiveness"
+ aria-label="Page Responsiveness"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx b/packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
index d19ec756ea..c429fe3bf9 100644
--- a/packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
+++ b/packages/studio/src/components/RenderModal/WebRenderModalAudio.tsx
@@ -140,7 +140,7 @@ export const WebRenderModalAudio: React.FC<{
<Combobox
values={audioBitrateOptions}
selectedId={audioBitrate}
- title="Audio Quality"
+ aria-label="Audio Quality"
/>
</div>
</div>
@@ -154,7 +154,7 @@ export const WebRenderModalAudio: React.FC<{
<Combobox
values={audioCodecOptions}
selectedId={audioCodec}
- title="Audio Codec"
+ aria-label="Audio Codec"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderModal/WebRenderModalBasic.tsx b/packages/studio/src/components/RenderModal/WebRenderModalBasic.tsx
index ea8742f699..daddfcb7be 100644
--- a/packages/studio/src/components/RenderModal/WebRenderModalBasic.tsx
+++ b/packages/studio/src/components/RenderModal/WebRenderModalBasic.tsx
@@ -216,7 +216,7 @@ export const WebRenderModalBasic: React.FC<WebRenderModalBasicProps> = ({
<Combobox
values={containerOptions}
selectedId={container}
- title="Container"
+ aria-label="Container"
/>
</div>
</div>
@@ -234,7 +234,7 @@ export const WebRenderModalBasic: React.FC<WebRenderModalBasicProps> = ({
<Combobox
values={codecOptions}
selectedId={effectiveVideoCodec}
- title="Codec"
+ aria-label="Codec"
/>
</div>
</div>
@@ -274,7 +274,7 @@ export const WebRenderModalBasic: React.FC<WebRenderModalBasicProps> = ({
<Combobox
values={logLevelOptions}
selectedId={logLevel}
- title="Log Level"
+ aria-label="Log Level"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderModal/WebRenderModalPicture.tsx b/packages/studio/src/components/RenderModal/WebRenderModalPicture.tsx
index 62dc850857..7c47e941af 100644
--- a/packages/studio/src/components/RenderModal/WebRenderModalPicture.tsx
+++ b/packages/studio/src/components/RenderModal/WebRenderModalPicture.tsx
@@ -70,7 +70,7 @@ export const WebRenderModalPicture: React.FC<WebRenderModalPictureProps> = ({
<Combobox
values={qualityOptions}
selectedId={videoBitrate}
- title="Quality"
+ aria-label="Quality"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RenderQueue/CaptionQueueItem.tsx b/packages/studio/src/components/RenderQueue/CaptionQueueItem.tsx
index 3aadbab01d..d72242916e 100644
--- a/packages/studio/src/components/RenderQueue/CaptionQueueItem.tsx
+++ b/packages/studio/src/components/RenderQueue/CaptionQueueItem.tsx
@@ -237,7 +237,7 @@ export const CaptionQueueItem: React.FC<{
modalTitle="Transcription failed"
/>
) : (
- <span style={subtitle} title={message}>
+ <span role="group" style={subtitle} aria-label={message}>
{message}
</span>
)}
diff --git a/packages/studio/src/components/RenderQueue/QueueJobError.tsx b/packages/studio/src/components/RenderQueue/QueueJobError.tsx
index 30027fb609..75df3b6785 100644
--- a/packages/studio/src/components/RenderQueue/QueueJobError.tsx
+++ b/packages/studio/src/components/RenderQueue/QueueJobError.tsx
@@ -28,7 +28,7 @@ export const QueueJobError: React.FC<{
onClick={onClick}
type="button"
style={errorStyle}
- title={error.message}
+ aria-label={error.message}
>
{error.message}
</button>
diff --git a/packages/studio/src/components/RenderQueue/RenderQueueError.tsx b/packages/studio/src/components/RenderQueue/RenderQueueError.tsx
index 222a503c7f..f98ad5aa3a 100644
--- a/packages/studio/src/components/RenderQueue/RenderQueueError.tsx
+++ b/packages/studio/src/components/RenderQueue/RenderQueueError.tsx
@@ -31,7 +31,7 @@ export const RenderQueueError: React.FC<{
type="button"
style={outputLocation}
tabIndex={tabIndex}
- title={job.error.message}
+ aria-label={job.error.message}
>
{job.error.message}
</button>
diff --git a/packages/studio/src/components/RenderQueue/RenderQueueOutputName.tsx b/packages/studio/src/components/RenderQueue/RenderQueueOutputName.tsx
index 82a5b49d00..7d7617ac86 100644
--- a/packages/studio/src/components/RenderQueue/RenderQueueOutputName.tsx
+++ b/packages/studio/src/components/RenderQueue/RenderQueueOutputName.tsx
@@ -26,7 +26,7 @@ export const RenderQueueOutputName: React.FC<{
};
return (
- <span style={style} title={getTitle()}>
+ <span role="group" style={style} aria-label={getTitle()}>
{job.outName}
</span>
);
diff --git a/packages/studio/src/components/RenderQueue/RenderQueueProgressMessage.tsx b/packages/studio/src/components/RenderQueue/RenderQueueProgressMessage.tsx
index 2c53af23c4..a16dfac209 100644
--- a/packages/studio/src/components/RenderQueue/RenderQueueProgressMessage.tsx
+++ b/packages/studio/src/components/RenderQueue/RenderQueueProgressMessage.tsx
@@ -39,7 +39,7 @@ export const RenderQueueProgressMessage: React.FC<{
type="button"
style={outputLocation}
tabIndex={tabIndex}
- title={message}
+ aria-label={message}
>
{message}
</button>
diff --git a/packages/studio/src/components/RenderQueue/VideoMattingQueueItem.tsx b/packages/studio/src/components/RenderQueue/VideoMattingQueueItem.tsx
index 7c9fe0a9de..fdb3bfb2fe 100644
--- a/packages/studio/src/components/RenderQueue/VideoMattingQueueItem.tsx
+++ b/packages/studio/src/components/RenderQueue/VideoMattingQueueItem.tsx
@@ -191,7 +191,7 @@ export const VideoMattingQueueItem: React.FC<{
<Spacing x={1} />
<div style={right}>
<div style={title}>{job.displayName}</div>
- <div style={subtitles} title={tooltip}>
+ <div role="group" style={subtitles} aria-label={tooltip}>
{job.status === 'cancelled' ? (
<RenderQueueCancelledMessage />
) : job.status === 'failed' ? (
diff --git a/packages/studio/src/components/RenderingSettings.tsx b/packages/studio/src/components/RenderingSettings.tsx
index 847aef68cb..1a1132849a 100644
--- a/packages/studio/src/components/RenderingSettings.tsx
+++ b/packages/studio/src/components/RenderingSettings.tsx
@@ -446,7 +446,7 @@ export const RenderingSettings: React.FC = () => {
<Combobox
values={codecValues}
selectedId={codec ?? REMOTION_DEFAULT}
- title="Codec"
+ aria-label="Codec"
/>
</div>
</div>
@@ -463,7 +463,7 @@ export const RenderingSettings: React.FC = () => {
<Combobox
values={stillFormatValues}
selectedId={stillImageFormat ?? REMOTION_DEFAULT}
- title="Still image format"
+ aria-label="Still image format"
/>
</div>
</div>
@@ -473,7 +473,7 @@ export const RenderingSettings: React.FC = () => {
<Combobox
values={videoFormatValues}
selectedId={videoImageFormat ?? REMOTION_DEFAULT}
- title="Video frame format"
+ aria-label="Video frame format"
/>
</div>
</div>
@@ -521,7 +521,7 @@ export const RenderingSettings: React.FC = () => {
<Combobox
values={profileValues}
selectedId={proResProfile ?? REMOTION_DEFAULT}
- title="ProRes profile"
+ aria-label="ProRes profile"
/>
</div>
</div>
@@ -533,7 +533,7 @@ export const RenderingSettings: React.FC = () => {
<Combobox
values={presetValues}
selectedId={x264Preset ?? REMOTION_DEFAULT}
- title="x264 preset"
+ aria-label="x264 preset"
/>
</div>
</div>
@@ -546,7 +546,7 @@ export const RenderingSettings: React.FC = () => {
<Combobox
values={audioCodecValues}
selectedId={audioCodec ?? REMOTION_DEFAULT}
- title="Audio codec"
+ aria-label="Audio codec"
/>
</div>
</div>
diff --git a/packages/studio/src/components/RulersAndGuidesToggle.tsx b/packages/studio/src/components/RulersAndGuidesToggle.tsx
index 583d03abc3..d9903fb044 100644
--- a/packages/studio/src/components/RulersAndGuidesToggle.tsx
+++ b/packages/studio/src/components/RulersAndGuidesToggle.tsx
@@ -58,7 +58,6 @@ export const RulersAndGuidesToggle: React.FC<{
dismissOnClick={false}
>
<ControlButton
- title=""
aria-label={accessibilityLabel}
aria-keyshortcuts={
shortcutsDisabled ? undefined : ariaShortcut || undefined
diff --git a/packages/studio/src/components/SegmentedButton.tsx b/packages/studio/src/components/SegmentedButton.tsx
index f31027a3ce..e7b34a2381 100644
--- a/packages/studio/src/components/SegmentedButton.tsx
+++ b/packages/studio/src/components/SegmentedButton.tsx
@@ -37,7 +37,6 @@ type SegmentedButtonSegmentCommon = {
readonly renderContent: (color: string) => React.ReactNode;
readonly segmentId: string;
readonly style: React.CSSProperties | null;
- readonly title: string | null;
readonly tooltipLabel: string | null;
};
@@ -189,7 +188,6 @@ const SegmentedButtonAction: React.FC<{
onPointerDown={onPointerDown}
style={style}
tabIndex={tabIndex}
- title={segment.title ?? undefined}
type="button"
>
{segment.renderContent(CURRENT_COLOR)}
@@ -349,7 +347,6 @@ const SegmentedButtonMenu: React.FC<{
onPointerDown={onPointerDown}
style={style}
tabIndex={tabIndex}
- title={segment.title ?? undefined}
type="button"
>
{segment.renderContent(CURRENT_COLOR)}
@@ -410,10 +407,9 @@ const SegmentedButtonMenu: React.FC<{
export const SegmentedButton: React.FC<{
readonly segments: SegmentedButtonSegment[];
readonly style: React.CSSProperties | null;
- readonly title: string | null;
-}> = ({segments, style, title}) => {
+}> = ({segments, style}) => {
return (
- <div style={{...containerStyle, ...style}} title={title ?? undefined}>
+ <div style={{...containerStyle, ...style}}>
{segments.map((segment, index) => {
if (segment.type === 'action') {
return (
diff --git a/packages/studio/src/components/SettingsButton.tsx b/packages/studio/src/components/SettingsButton.tsx
index ade26a99b6..0aefed77a1 100644
--- a/packages/studio/src/components/SettingsButton.tsx
+++ b/packages/studio/src/components/SettingsButton.tsx
@@ -79,7 +79,6 @@ export const SettingsButton: React.FC<{
onClick={openModal}
renderAction={updateAvailable ? renderUpdateIcon : renderGearIcon}
unhoveredColor={hasBugfixesAvailable ? WARNING_COLOR : WHITE_ALPHA_80}
- title=""
aria-label={label}
/>
</ActionTooltip>
diff --git a/packages/studio/src/components/SettingsModalFooter.tsx b/packages/studio/src/components/SettingsModalFooter.tsx
index 2c5efb770c..2f1bc77e98 100644
--- a/packages/studio/src/components/SettingsModalFooter.tsx
+++ b/packages/studio/src/components/SettingsModalFooter.tsx
@@ -99,7 +99,7 @@ export const SettingsModalFooter: React.FC<{
disabled={restarting}
onClick={restart}
size="compact"
- title="Restart Studio to apply config file changes"
+ aria-label="Restart Studio to apply config file changes"
>
{restarting ? 'Restarting...' : 'Restart Studio'}
</ModalButton>
@@ -108,7 +108,7 @@ export const SettingsModalFooter: React.FC<{
disabled={false}
onClick={openLicenseFaq}
style={{flex: 'none', width: 'fit-content'}}
- title="Open the Remotion License FAQ in a new tab"
+ aria-label="Open the Remotion License FAQ in a new tab"
>
License FAQ
<svg
diff --git a/packages/studio/src/components/SizeSelector.tsx b/packages/studio/src/components/SizeSelector.tsx
index 26ab782db7..f830240501 100644
--- a/packages/studio/src/components/SizeSelector.tsx
+++ b/packages/studio/src/components/SizeSelector.tsx
@@ -155,7 +155,7 @@ export const SizeSelector: React.FC = () => {
return (
<TimelineCombobox
- title={accessibilityLabel}
+ aria-label={accessibilityLabel}
tooltipDelay={800}
selectedId={selectedId}
values={items}
diff --git a/packages/studio/src/components/SkillsSettings.tsx b/packages/studio/src/components/SkillsSettings.tsx
index d8efa6ff0a..40b1ce99a8 100644
--- a/packages/studio/src/components/SkillsSettings.tsx
+++ b/packages/studio/src/components/SkillsSettings.tsx
@@ -174,7 +174,6 @@ export const SkillSettingsRow: React.FC<{
>
<InlineAction
aria-label={`Remove ${skill.name}`}
- title=""
disabled={skillAction !== null}
onClick={() => removeSkill(skill.name)}
renderAction={renderRemoveAction}
@@ -190,7 +189,6 @@ export const SkillSettingsRow: React.FC<{
>
<InlineAction
aria-label={`Install ${skill.name}`}
- title=""
disabled={skillAction !== null}
onClick={() => installSkill(skill.name)}
renderAction={renderInstallAction}
@@ -269,7 +267,7 @@ export const SkillsSettings: React.FC = () => {
variant={null}
onClick={onCopy}
renderAction={renderCopyAction}
- title="Copy install command"
+ aria-label="Copy install command"
/>
</div>
</div>
diff --git a/packages/studio/src/components/SnappingToggle.tsx b/packages/studio/src/components/SnappingToggle.tsx
index 41018897de..bbd7d057f6 100644
--- a/packages/studio/src/components/SnappingToggle.tsx
+++ b/packages/studio/src/components/SnappingToggle.tsx
@@ -35,7 +35,6 @@ export const SnappingToggle: React.FC = () => {
dismissOnClick={false}
>
<ControlButton
- title=""
aria-label={accessibilityLabel}
aria-pressed={editorSnapping}
aria-keyshortcuts={
diff --git a/packages/studio/src/components/StudioSettings.tsx b/packages/studio/src/components/StudioSettings.tsx
index bd65e4dea8..ca7d826884 100644
--- a/packages/studio/src/components/StudioSettings.tsx
+++ b/packages/studio/src/components/StudioSettings.tsx
@@ -94,7 +94,7 @@ const ConfigNumber = ({
onClick={() => onChangeEnd(null)}
size="compact"
style={{color: LIGHT_TEXT}}
- title={`Use default (${defaultValue})`}
+ aria-label={`Use default (${defaultValue})`}
>
<UndoIcon style={resetIcon} />
</Button>
@@ -225,7 +225,7 @@ export const StudioSettings: React.FC = () => {
<div style={label}>
Cross-site isolation
<InfoBubble
- title="About cross-site isolation"
+ aria-label="About cross-site isolation"
horizontalAlignment="right"
>
<div
diff --git a/packages/studio/src/components/TimeValue.tsx b/packages/studio/src/components/TimeValue.tsx
index 096d4a8112..dc9b1aa32a 100644
--- a/packages/studio/src/components/TimeValue.tsx
+++ b/packages/studio/src/components/TimeValue.tsx
@@ -175,11 +175,6 @@ export const TimeValue: React.FC = () => {
onClick={toggleTickFormat}
aria-label="Show timeline ticks as frames"
aria-pressed={showFrames}
- title={
- showFrames
- ? 'Show timeline ticks as timecode'
- : 'Show timeline ticks as frames'
- }
>
{frame}
</button>
diff --git a/packages/studio/src/components/Timeline/EasingEditorModal.tsx b/packages/studio/src/components/Timeline/EasingEditorModal.tsx
index bc70688a68..0f8fb73cb9 100644
--- a/packages/studio/src/components/Timeline/EasingEditorModal.tsx
+++ b/packages/studio/src/components/Timeline/EasingEditorModal.tsx
@@ -661,7 +661,11 @@ const EasingGraphScaffold: React.FC<{
width={topLabelWidth}
height={EASING_GRAPH_LABEL_HEIGHT}
>
- <div style={getEasingGraphLabelStyle('left')} title={labels.end}>
+ <div
+ role="group"
+ style={getEasingGraphLabelStyle('left')}
+ aria-label={labels.end}
+ >
{labels.end}
</div>
</foreignObject>
@@ -676,7 +680,11 @@ const EasingGraphScaffold: React.FC<{
width={bottomLabelWidth}
height={EASING_GRAPH_LABEL_HEIGHT}
>
- <div style={getEasingGraphLabelStyle('right')} title={labels.start}>
+ <div
+ role="group"
+ style={getEasingGraphLabelStyle('right')}
+ aria-label={labels.start}
+ >
{labels.start}
</div>
</foreignObject>
@@ -715,7 +723,6 @@ const EasingPresetButton: React.FC<{
<button
type="button"
style={style}
- title={preset.label}
aria-label={`Apply ${preset.label} easing`}
disabled={disabled}
onClick={handleClick}
diff --git a/packages/studio/src/components/Timeline/TimelineArrayField.tsx b/packages/studio/src/components/Timeline/TimelineArrayField.tsx
index 96fdee1b7d..2211ca3f25 100644
--- a/packages/studio/src/components/Timeline/TimelineArrayField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineArrayField.tsx
@@ -343,7 +343,7 @@ export const TimelineArrayField: React.FC<{
disabled={!canRemove}
onClick={() => onRemove(index)}
style={canRemove ? button : disabledButton}
- title={`Remove item ${index}`}
+ aria-label={`Remove item ${index}`}
type="button"
>
-
@@ -353,7 +353,12 @@ export const TimelineArrayField: React.FC<{
})}
{canAdd ? (
<span style={addButtonRow}>
- <button type="button" style={button} onClick={onAdd} title="Add item">
+ <button
+ type="button"
+ style={button}
+ onClick={onAdd}
+ aria-label="Add item"
+ >
+
</button>
</span>
diff --git a/packages/studio/src/components/Timeline/TimelineAssetField.tsx b/packages/studio/src/components/Timeline/TimelineAssetField.tsx
index b4b29d4803..e227c580f9 100644
--- a/packages/studio/src/components/Timeline/TimelineAssetField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineAssetField.tsx
@@ -317,7 +317,7 @@ export const TimelineAssetField: React.FC<TimelineAssetFieldProps> = ({
variant={null}
onClick={openAssetSelection}
disabled={window.remotion_isReadOnlyStudio}
- title="Change source"
+ aria-label="Change source"
renderAction={(color) => <PenIcon color={color} style={penIcon} />}
/>
);
@@ -350,7 +350,8 @@ export const TimelineAssetField: React.FC<TimelineAssetFieldProps> = ({
linkInfo.kind === 'local' &&
inlineSourceAction !== null &&
inlineSourceAction.onClick !== null;
- const title = inlineSourceAction?.title ?? linkInfo.title;
+ const sourceDescription =
+ inlineSourceAction?.['aria-label'] ?? linkInfo.title;
const onPreviewClick = opensSource
? inlineSourceAction.onClick
: openAssetSelection;
@@ -372,11 +373,11 @@ export const TimelineAssetField: React.FC<TimelineAssetFieldProps> = ({
const previewAction = (
<button
aria-label={previewLabel}
+ aria-description={sourceDescription}
className={`${HOVERABLE_CLASS_NAME} ${FOCUS_VISIBLE_ONLY_CLASS_NAME}`}
disabled={previewDisabled}
onClick={onPreviewClick}
style={previewButtonStyle}
- title={title}
type="button"
>
<span style={thumbnailContainer}>
diff --git a/packages/studio/src/components/Timeline/TimelineColorField.tsx b/packages/studio/src/components/Timeline/TimelineColorField.tsx
index b532e39d38..a7337fc4aa 100644
--- a/packages/studio/src/components/Timeline/TimelineColorField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineColorField.tsx
@@ -80,7 +80,7 @@ export const TimelineColorField: React.FC<{
<button
type="button"
style={setButtonStyle}
- title={`Set ${field.description ?? field.key} to gray`}
+ aria-label={`Set ${field.description ?? field.key} to gray`}
onClick={() => onChangeComplete(DEFAULT_SET_COLOR)}
>
Set
@@ -100,7 +100,7 @@ export const TimelineColorField: React.FC<{
height={SWATCH_HEIGHT}
disabled={false}
name={field.key}
- title={currentValue}
+ aria-label={currentValue}
/>
</span>
);
diff --git a/packages/studio/src/components/Timeline/TimelineDuplicateCount.tsx b/packages/studio/src/components/Timeline/TimelineDuplicateCount.tsx
index 126a5a9d2e..3ea3e05416 100644
--- a/packages/studio/src/components/Timeline/TimelineDuplicateCount.tsx
+++ b/packages/studio/src/components/Timeline/TimelineDuplicateCount.tsx
@@ -26,7 +26,7 @@ export const TimelineDuplicateCount: React.FC<{
const label = `${count} other programmatically duplicated ${count === 1 ? 'instance is' : 'instances are'} hidden`;
return (
- <span style={badgeStyle} title={label} aria-label={label}>
+ <span role="group" style={badgeStyle} aria-label={label}>
+{count}
</span>
);
diff --git a/packages/studio/src/components/Timeline/TimelineEffectItem.tsx b/packages/studio/src/components/Timeline/TimelineEffectItem.tsx
index c82a0625b3..5cc18eb9f2 100644
--- a/packages/studio/src/components/Timeline/TimelineEffectItem.tsx
+++ b/packages/studio/src/components/Timeline/TimelineEffectItem.tsx
@@ -515,7 +515,7 @@ export const TimelineEffectItem: React.FC<{
outerHeight={null}
>
<div style={labelContainerStyle}>
- <span title={label} style={labelStyle}>
+ <span role="group" aria-label={label} style={labelStyle}>
{label}
</span>
<TimelineExpandArrowButton
diff --git a/packages/studio/src/components/Timeline/TimelineEnumField.tsx b/packages/studio/src/components/Timeline/TimelineEnumField.tsx
index d9e7981e83..cf94a652ae 100644
--- a/packages/studio/src/components/Timeline/TimelineEnumField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineEnumField.tsx
@@ -63,7 +63,7 @@ export const TimelineEnumField: React.FC<{
return (
<Combobox
size="small"
- title={field.key}
+ aria-label={field.key}
selectedId={current}
values={items}
/>
diff --git a/packages/studio/src/components/Timeline/TimelineFieldLabel.tsx b/packages/studio/src/components/Timeline/TimelineFieldLabel.tsx
index 68bd09081a..559099b553 100644
--- a/packages/studio/src/components/Timeline/TimelineFieldLabel.tsx
+++ b/packages/studio/src/components/Timeline/TimelineFieldLabel.tsx
@@ -57,7 +57,7 @@ export const TimelineFieldLabel: React.FC<{
return (
<div style={labelRowStyle}>
- <span style={fieldNameStyle} title={label}>
+ <span role="group" style={fieldNameStyle} aria-label={label}>
{label}
</span>
</div>
diff --git a/packages/studio/src/components/Timeline/TimelineFontFamilyField.tsx b/packages/studio/src/components/Timeline/TimelineFontFamilyField.tsx
index 8066db6a8b..0e45c1d777 100644
--- a/packages/studio/src/components/Timeline/TimelineFontFamilyField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineFontFamilyField.tsx
@@ -729,7 +729,7 @@ export const TimelineFontFamilyField: React.FC<{
<>
<button
ref={buttonRef}
- title={field.key}
+ aria-label={field.key}
tabIndex={tabIndex}
type="button"
style={style}
@@ -748,7 +748,8 @@ export const TimelineFontFamilyField: React.FC<{
onMouseLeave={() => setHovered(false)}
>
<div
- title={selected.label}
+ role="group"
+ aria-label={selected.label}
style={{...triggerLabel, ...selectedPreviewStyle}}
>
{selected.label}
diff --git a/packages/studio/src/components/Timeline/TimelineFontWeightField.tsx b/packages/studio/src/components/Timeline/TimelineFontWeightField.tsx
index 6e479e24b1..12f6606c7f 100644
--- a/packages/studio/src/components/Timeline/TimelineFontWeightField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineFontWeightField.tsx
@@ -86,7 +86,7 @@ export const TimelineFontWeightField: React.FC<{
return (
<Combobox
size="small"
- title={field.key}
+ aria-label={field.key}
selectedId={String(currentValue)}
values={keywordItems}
/>
diff --git a/packages/studio/src/components/Timeline/TimelineKeyframeControls.tsx b/packages/studio/src/components/Timeline/TimelineKeyframeControls.tsx
index 6f0db9a675..7525569f82 100644
--- a/packages/studio/src/components/Timeline/TimelineKeyframeControls.tsx
+++ b/packages/studio/src/components/Timeline/TimelineKeyframeControls.tsx
@@ -892,7 +892,6 @@ export const TimelineKeyframeControls: React.FC<{
disabled={previousDisabled}
onPointerDown={previousDisabled ? undefined : onPrevious}
aria-label="Go to previous keyframe"
- title="Previous keyframe"
>
<svg width="14" height="14" viewBox="0 0 10 10" style={svgStyle}>
<path d="M7 1.5L3 5L7 8.5Z" fill={LIGHT_GRAY} />
@@ -908,7 +907,6 @@ export const TimelineKeyframeControls: React.FC<{
aria-label={
hasKeyframeAtCurrentFrame ? 'Remove keyframe' : 'Add keyframe'
}
- title={hasKeyframeAtCurrentFrame ? 'Remove keyframe' : 'Add keyframe'}
>
<TimelineKeyframeDiamondIcon color={diamondColor} size={12} />
</button>
@@ -918,7 +916,6 @@ export const TimelineKeyframeControls: React.FC<{
disabled={nextDisabled}
onPointerDown={nextDisabled ? undefined : onNext}
aria-label="Go to next keyframe"
- title="Next keyframe"
>
<svg width="14" height="14" viewBox="0 0 10 10" style={svgStyle}>
<path d="M3 1.5L7 5L3 8.5Z" fill={LIGHT_GRAY} />
diff --git a/packages/studio/src/components/Timeline/TimelineKeyframeDiamond.tsx b/packages/studio/src/components/Timeline/TimelineKeyframeDiamond.tsx
index f9d11dc820..9ca3a81121 100644
--- a/packages/studio/src/components/Timeline/TimelineKeyframeDiamond.tsx
+++ b/packages/studio/src/components/Timeline/TimelineKeyframeDiamond.tsx
@@ -80,7 +80,6 @@ const TimelineKeyframeDiamondUnmemoized: React.FC<{
{...{[TIMELINE_MARQUEE_ITEM_ATTR]: true}}
type="button"
style={style}
- title={`Keyframe at frame ${frame}`}
aria-label={`Select keyframe at frame ${frame}`}
onPointerDown={selectable ? onPointerDown : undefined}
>
diff --git a/packages/studio/src/components/Timeline/TimelineKeyframeEasingLine.tsx b/packages/studio/src/components/Timeline/TimelineKeyframeEasingLine.tsx
index 86e69f65b8..212e2d702b 100644
--- a/packages/studio/src/components/Timeline/TimelineKeyframeEasingLine.tsx
+++ b/packages/studio/src/components/Timeline/TimelineKeyframeEasingLine.tsx
@@ -220,7 +220,6 @@ const TimelineKeyframeEasingLineInteraction: React.FC<
{...{[TIMELINE_MARQUEE_ITEM_ATTR]: true}}
type="button"
style={interactiveStyle}
- title={`Easing from frame ${fromFrame} to ${toFrame}`}
aria-label={`Select easing from frame ${fromFrame} to ${toFrame}`}
onPointerDown={selectable ? onPointerDown : undefined}
>
diff --git a/packages/studio/src/components/Timeline/TimelineLayerChildren.tsx b/packages/studio/src/components/Timeline/TimelineLayerChildren.tsx
index 45abb6a45d..00d579122c 100644
--- a/packages/studio/src/components/Timeline/TimelineLayerChildren.tsx
+++ b/packages/studio/src/components/Timeline/TimelineLayerChildren.tsx
@@ -175,7 +175,6 @@ export const TimelineLayerChildrenToggle: React.FC<{
className={`${HOVERABLE_CLASS_NAME} ${FOCUS_VISIBLE_ONLY_CLASS_NAME}`}
aria-label={label}
aria-expanded={!isCollapsed}
- title={label}
onClick={onClick}
onPointerDown={stopPropagation}
onDoubleClick={stopPropagation}
diff --git a/packages/studio/src/components/Timeline/TimelineMediaInfo.tsx b/packages/studio/src/components/Timeline/TimelineMediaInfo.tsx
index dee8068adb..aacfaaf939 100644
--- a/packages/studio/src/components/Timeline/TimelineMediaInfo.tsx
+++ b/packages/studio/src/components/Timeline/TimelineMediaInfo.tsx
@@ -45,7 +45,11 @@ export const TimelineMediaInfo: React.FC<{
const {linkInfo, fileNameStyle} = useAssetLink(src);
return (
- <div style={fileNameStyle} title={linkInfo ? linkInfo.title : fileName}>
+ <div
+ role="group"
+ style={fileNameStyle}
+ aria-label={linkInfo ? linkInfo.title : fileName}
+ >
{fileName}
</div>
);
diff --git a/packages/studio/src/components/Timeline/TimelineScaleField.tsx b/packages/studio/src/components/Timeline/TimelineScaleField.tsx
index 0dddf8d53b..6c66a1d348 100644
--- a/packages/studio/src/components/Timeline/TimelineScaleField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineScaleField.tsx
@@ -127,7 +127,6 @@ const LinkToggle: React.FC<{
type="button"
style={toggleStyle}
onPointerDown={onPointerDown}
- title={linked ? 'Unlink scale axes' : 'Link scale axes'}
aria-label={linked ? 'Unlink scale axes' : 'Link scale axes'}
>
{linked ? (
diff --git a/packages/studio/src/components/Timeline/TimelineSchemaField.tsx b/packages/studio/src/components/Timeline/TimelineSchemaField.tsx
index 1b20ad2294..7c1c88273a 100644
--- a/packages/studio/src/components/Timeline/TimelineSchemaField.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSchemaField.tsx
@@ -112,10 +112,13 @@ export const UnsupportedStatus: React.FC<{
return (
<span
+ role="group"
style={unsupportedStatusWrapper}
onPointerEnter={() => setHovered(true)}
onPointerLeave={() => setHovered(false)}
- title={formattedValue && typeof label === 'string' ? label : undefined}
+ aria-label={
+ formattedValue && typeof label === 'string' ? label : undefined
+ }
>
<span
style={formattedValue ? computedValue : unsupportedLabel}
@@ -128,7 +131,7 @@ export const UnsupportedStatus: React.FC<{
type="button"
className={`${FOCUS_VISIBLE_ONLY_CLASS_NAME} ${HOVERABLE_CLASS_NAME}`}
style={fixLink}
- title="Fix computed Studio value"
+ aria-label="Fix computed Studio value"
onClick={(event) => {
stopMousePropagation(event);
onFix();
diff --git a/packages/studio/src/components/Timeline/TimelineSequence.tsx b/packages/studio/src/components/Timeline/TimelineSequence.tsx
index 0885c24965..6e8482497c 100644
--- a/packages/studio/src/components/Timeline/TimelineSequence.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSequence.tsx
@@ -355,9 +355,10 @@ const TimelineSequenceCurrentFrame: React.FC<{
return (
<div
ref={ref}
+ role="group"
{...{[TIMELINE_MARQUEE_ITEM_ATTR]: true}}
style={actualStyle}
- title={s.displayName}
+ aria-label={s.displayName}
onPointerDownCapture={onPointerDownCapture}
onPointerDown={selectable ? onPointerDown : undefined}
onClick={onClick ?? undefined}
diff --git a/packages/studio/src/components/Timeline/TimelineSequenceName.tsx b/packages/studio/src/components/Timeline/TimelineSequenceName.tsx
index 4177681ec1..2c9c937d23 100644
--- a/packages/studio/src/components/Timeline/TimelineSequenceName.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSequenceName.tsx
@@ -152,7 +152,7 @@ export const TimelineSequenceName: React.FC<{
}
return (
- <div title={text} style={style}>
+ <div role="group" aria-label={text} style={style}>
{text}
</div>
);
diff --git a/packages/studio/src/components/Timeline/TimelineSequenceRightEdgeDragHandle.tsx b/packages/studio/src/components/Timeline/TimelineSequenceRightEdgeDragHandle.tsx
index c022b50c63..fd9b5b5d46 100644
--- a/packages/studio/src/components/Timeline/TimelineSequenceRightEdgeDragHandle.tsx
+++ b/packages/studio/src/components/Timeline/TimelineSequenceRightEdgeDragHandle.tsx
@@ -1483,7 +1483,7 @@ const TimelineSequenceLeftEdgeDragHandleInner: React.FC<{
<div
role="separator"
aria-orientation="vertical"
- title="Drag to trim start"
+ aria-label="Drag to trim start"
style={style}
onPointerDown={onPointerDown}
/>
@@ -2080,7 +2080,7 @@ const TimelineSequenceRightEdgeDragHandleInner: React.FC<{
<div
role="separator"
aria-orientation="vertical"
- title="Drag to change duration"
+ aria-label="Drag to change duration"
style={style}
onPointerDown={onPointerDown}
/>
diff --git a/packages/studio/src/components/Timeline/TimelineZoomControls.tsx b/packages/studio/src/components/Timeline/TimelineZoomControls.tsx
index 8ff19df675..44858967ce 100644
--- a/packages/studio/src/components/Timeline/TimelineZoomControls.tsx
+++ b/packages/studio/src/components/Timeline/TimelineZoomControls.tsx
@@ -77,7 +77,7 @@ const TimelineZoomSlider: React.FC<{
return (
<input
style={maxWidth === undefined ? undefined : {maxWidth}}
- title={`Timeline zoom (${roundedZoom}px/frame)`}
+ aria-label={`Timeline zoom (${roundedZoom}px/frame)`}
alt={`Timeline zoom (${roundedZoom}px/frame)`}
type="range"
min={TIMELINE_ZOOM_SLIDER_PROPS.min}
@@ -146,7 +146,6 @@ const TimelineZoomControlsInner: React.FC<{
<ControlButton
onClick={onMinusClicked}
style={buttonStyle}
- title=""
aria-label="Zoom out timeline"
type="button"
>
@@ -164,7 +163,6 @@ const TimelineZoomControlsInner: React.FC<{
<ControlButton
onClick={onPlusClicked}
style={buttonStyle}
- title=""
aria-label="Zoom in timeline"
type="button"
>
diff --git a/packages/studio/src/components/Timeline/get-sequence-split-menu-item.tsx b/packages/studio/src/components/Timeline/get-sequence-split-menu-item.tsx
index 3534f20e68..2dd0f2ee78 100644
--- a/packages/studio/src/components/Timeline/get-sequence-split-menu-item.tsx
+++ b/packages/studio/src/components/Timeline/get-sequence-split-menu-item.tsx
@@ -51,13 +51,14 @@ export const getSequenceSplitMenuItem = ({
id: 'split-sequence',
label: (
<span
+ role="group"
style={{
fontFamily: 'inherit',
fontSize: 'inherit',
lineHeight: 'inherit',
color: 'inherit',
}}
- title={disabledReason ?? 'Split at the playhead'}
+ aria-label={disabledReason ?? 'Split at the playhead'}
>
Split clip
</span>
diff --git a/packages/studio/src/components/TimelineCombobox.tsx b/packages/studio/src/components/TimelineCombobox.tsx
index 75cab0a817..3a292b5fa7 100644
--- a/packages/studio/src/components/TimelineCombobox.tsx
+++ b/packages/studio/src/components/TimelineCombobox.tsx
@@ -30,7 +30,7 @@ type SelectionItem = Extract<ComboboxValue, {type: 'item'}>;
export const TimelineCombobox: React.FC<{
readonly values: ComboboxValue[];
readonly selectedId: string | number;
- readonly title: string;
+ readonly 'aria-label': string;
readonly tooltipDelay: number | null;
readonly labelWidth?: number;
readonly renderLeftItem?: RenderInlineAction;
@@ -38,7 +38,7 @@ export const TimelineCombobox: React.FC<{
}> = ({
values,
selectedId,
- title,
+ 'aria-label': ariaLabel,
tooltipDelay,
labelWidth = 32,
renderLeftItem,
@@ -49,7 +49,7 @@ export const TimelineCombobox: React.FC<{
| undefined;
const segments: SegmentedButtonSegment[] = [
{
- ariaLabel: title,
+ ariaLabel,
buttonId: null,
disabled: false,
idleColor: unhoveredIconColor,
@@ -65,7 +65,8 @@ export const TimelineCombobox: React.FC<{
) : null}
{selected ? (
<div
- title={
+ role="group"
+ aria-label={
tooltipDelay === null && typeof selected.label === 'string'
? selected.label
: undefined
@@ -82,7 +83,6 @@ export const TimelineCombobox: React.FC<{
segmentId: 'selector',
selectedId,
style: {fontFamily: 'inherit', padding: '0 4px'},
- title: tooltipDelay === null ? title : null,
tooltipLabel: null,
type: 'menu',
values,
@@ -90,18 +90,14 @@ export const TimelineCombobox: React.FC<{
];
const button = (
- <SegmentedButton
- segments={segments}
- style={segmentedButtonStyle}
- title={null}
- />
+ <SegmentedButton segments={segments} style={segmentedButtonStyle} />
);
return tooltipDelay === null ? (
button
) : (
<ActionTooltip
- label={title}
+ label={ariaLabel}
shortcut={null}
delay={tooltipDelay}
dismissOnClick
diff --git a/packages/studio/src/components/TimelineInOutToggle.tsx b/packages/studio/src/components/TimelineInOutToggle.tsx
index 713355b197..9eefad1291 100644
--- a/packages/studio/src/components/TimelineInOutToggle.tsx
+++ b/packages/studio/src/components/TimelineInOutToggle.tsx
@@ -308,7 +308,6 @@ export const TimelineInOutPointToggle: React.FC = () => {
dismissOnClick
>
<ControlButton
- title=""
aria-label="In point"
aria-description="Right click to clear"
aria-keyshortcuts={
@@ -334,7 +333,6 @@ export const TimelineInOutPointToggle: React.FC = () => {
dismissOnClick
>
<ControlButton
- title=""
aria-label="Out point"
aria-description="Right click to clear"
aria-keyshortcuts={
diff --git a/packages/studio/src/components/Transcription/TranscriptionModal.tsx b/packages/studio/src/components/Transcription/TranscriptionModal.tsx
index f11a4a8e78..5e0cd8aa56 100644
--- a/packages/studio/src/components/Transcription/TranscriptionModal.tsx
+++ b/packages/studio/src/components/Transcription/TranscriptionModal.tsx
@@ -198,7 +198,7 @@ const TranscriptionSettingLabel: React.FC<{
</label>
)}
<Spacing x={0.5} />
- <InfoBubble title={`Learn more about ${name}`}>
+ <InfoBubble aria-label={`Learn more about ${name}`}>
<div style={tooltipContent}>{children}</div>
</InfoBubble>
</div>
@@ -326,7 +326,7 @@ const ModelSettings: React.FC<{
<Combobox
values={modelOptions}
selectedId={selectedModel}
- title="Whisper model"
+ aria-label="Whisper model"
style={controlStyle}
/>
</div>
@@ -338,7 +338,7 @@ const ModelSettings: React.FC<{
<Combobox
values={languageOptions}
selectedId={selectedLanguage}
- title="Spoken language"
+ aria-label="Spoken language"
style={controlStyle}
/>
</div>
@@ -351,7 +351,7 @@ const ModelSettings: React.FC<{
<Combobox
values={taskOptions}
selectedId={effectiveTask}
- title="Task"
+ aria-label="Task"
style={controlStyle}
/>
</div>
@@ -447,7 +447,7 @@ const OutputSettings: React.FC<{
<InlineAction
onClick={openExistingOutput}
renderAction={renderOpenIcon}
- title={`Open in ${fileManagerName}`}
+ aria-label={`Open in ${fileManagerName}`}
variant={null}
/>
)}
@@ -896,7 +896,7 @@ export const TranscriptionModal: React.FC<TranscriptionModalState> = ({
<Button
onClick={onAddToQueue}
disabled={!canTranscribe}
- title={transcribeDisabledReason}
+ aria-label={transcribeDisabledReason}
style={{
...buttonStyle,
backgroundColor: canTranscribe
diff --git a/packages/studio/src/components/UndoRedoButtons.tsx b/packages/studio/src/components/UndoRedoButtons.tsx
index 69f905b79b..2d05f83b46 100644
--- a/packages/studio/src/components/UndoRedoButtons.tsx
+++ b/packages/studio/src/components/UndoRedoButtons.tsx
@@ -166,7 +166,7 @@ export const UndoRedoButtons: React.FC = () => {
variant={null}
onClick={onUndo}
renderAction={renderUndo}
- title={undoTooltip}
+ aria-label={undoTooltip}
disabled={!canUndo}
unhoveredColor={WHITE_ALPHA_80}
/>
@@ -174,7 +174,7 @@ export const UndoRedoButtons: React.FC = () => {
variant={null}
onClick={onRedo}
renderAction={renderRedo}
- title={redoTooltip}
+ aria-label={redoTooltip}
disabled={!canRedo}
unhoveredColor={WHITE_ALPHA_80}
/>
diff --git a/packages/studio/src/components/UpdatesSettings.tsx b/packages/studio/src/components/UpdatesSettings.tsx
index c670383ccb..fdc2ee6690 100644
--- a/packages/studio/src/components/UpdatesSettings.tsx
+++ b/packages/studio/src/components/UpdatesSettings.tsx
@@ -227,7 +227,7 @@ const RenderedReleaseNotes: React.FC<{
scrolling="no"
srcDoc={document}
style={{...releaseNotesFrame, height}}
- title={`Release notes for Remotion v${release.version}`}
+ aria-label={`Release notes for Remotion v${release.version}`}
/>
)}
</>
@@ -437,7 +437,7 @@ export const UpdatesSettings: React.FC = () => {
variant={null}
onClick={onClick}
renderAction={renderCopyAction}
- title="Copy command"
+ aria-label="Copy command"
/>
</div>
{info.updateAvailable ? (
diff --git a/packages/studio/src/components/VideoMatting/VideoMattingModal.tsx b/packages/studio/src/components/VideoMatting/VideoMattingModal.tsx
index e17a9c8b10..0e37dab18f 100644
--- a/packages/studio/src/components/VideoMatting/VideoMattingModal.tsx
+++ b/packages/studio/src/components/VideoMatting/VideoMattingModal.tsx
@@ -253,7 +253,9 @@ export const VideoMattingModal: React.FC<VideoMattingModalState> = ({
<Button
disabled={!canSubmit}
onClick={submit}
- title={support.type === 'unsupported' ? support.message : undefined}
+ aria-label={
+ support.type === 'unsupported' ? support.message : undefined
+ }
style={{
...buttonStyle,
backgroundColor: canSubmit
@@ -317,7 +319,7 @@ export const VideoMattingModal: React.FC<VideoMattingModalState> = ({
<Combobox
values={modelOptions}
selectedId={model}
- title="Model"
+ aria-label="Model"
style={controlStyle}
/>
</div>
@@ -337,7 +339,7 @@ export const VideoMattingModal: React.FC<VideoMattingModalState> = ({
<Combobox
values={audioOptions}
selectedId={audio}
- title="Audio"
+ aria-label="Audio"
style={controlStyle}
/>
</div>
@@ -348,7 +350,7 @@ export const VideoMattingModal: React.FC<VideoMattingModalState> = ({
<Combobox
values={qualityOptions}
selectedId={String(videoBitrate)}
- title="Video quality"
+ aria-label="Video quality"
style={controlStyle}
/>
</div>
diff --git a/packages/studio/src/error-overlay/remotion-overlay/CompositionIdListItem.tsx b/packages/studio/src/error-overlay/remotion-overlay/CompositionIdListItem.tsx
index a41a09d4a6..8f45027b69 100644
--- a/packages/studio/src/error-overlay/remotion-overlay/CompositionIdListItem.tsx
+++ b/packages/studio/src/error-overlay/remotion-overlay/CompositionIdListItem.tsx
@@ -41,7 +41,7 @@ export const CompositionIdListItem: React.FC<{
...(hover ? listItemHoverStyle : {}),
...(isActive ? listItemActiveStyle : {}),
}}
- title={id}
+ aria-label={id}
>
{id}
</div>
diff --git a/packages/studio/src/error-overlay/remotion-overlay/OpenInEditor.tsx b/packages/studio/src/error-overlay/remotion-overlay/OpenInEditor.tsx
index f8c34c2cb6..ad9519c4a6 100644
--- a/packages/studio/src/error-overlay/remotion-overlay/OpenInEditor.tsx
+++ b/packages/studio/src/error-overlay/remotion-overlay/OpenInEditor.tsx
@@ -145,7 +145,6 @@ export const OpenInEditor: React.FC<{
onClick={openPreferredEditor}
size={size}
style={null}
- title={`Open in ${editorName}`}
>
<EditorIcon editorId={editorId} size={size === 'default' ? 14 : 18} />
Open in {editorName}
diff --git a/packages/studio/src/error-overlay/remotion-overlay/StackFrame.tsx b/packages/studio/src/error-overlay/remotion-overlay/StackFrame.tsx
index d9c734b46c..43a3e377f7 100644
--- a/packages/studio/src/error-overlay/remotion-overlay/StackFrame.tsx
+++ b/packages/studio/src/error-overlay/remotion-overlay/StackFrame.tsx
@@ -144,8 +144,9 @@ export const StackElement: React.FC<{
{fileLocation ? (
<div
ref={locationRef}
+ role="group"
style={{...locationContainer, fontSize}}
- title={locationOverflows ? fileLocation : undefined}
+ aria-label={locationOverflows ? fileLocation : undefined}
>
{canOpenFileLocation ? (
<button