Skip to content

🎥 Make videos programmatically with React

Internal: Eliminate recurring CI test races

Jonny Burgereb5b2e2dfc70
diff --git a/packages/browser-studio/e2e/browser-studio.test.ts b/packages/browser-studio/e2e/browser-studio.test.ts
index 3a7f91fc5d..842440141d 100644
--- a/packages/browser-studio/e2e/browser-studio.test.ts
+++ b/packages/browser-studio/e2e/browser-studio.test.ts
@@ -73,15 +73,6 @@ const waitForBrowserStudioOperations = async (studio: FrameLocator) => {
.toBe(true);
};
-test('runs Browser Studio in Safari', async ({page}) => {
- await page.goto('/');
-
- expect(await page.evaluate(() => window.crossOriginIsolated)).toBe(true);
- await expect(
- page.frameLocator('iframe').getByTitle('/project').getByText('MyComp'),
- ).toBeVisible();
-});
-
test('selects a composition inserted from the Add composition dialog', async ({
page,
}) => {
diff --git a/packages/browser-studio/playwright.config.ts b/packages/browser-studio/playwright.config.ts
index 1a9c0e48fe..345c35e103 100644
--- a/packages/browser-studio/playwright.config.ts
+++ b/packages/browser-studio/playwright.config.ts
@@ -19,14 +19,8 @@ export default defineConfig({
projects: [
{
name: 'chromium',
- grepInvert: /runs Browser Studio in Safari/,
use: {...devices['Desktop Chrome']},
},
- {
- name: 'webkit',
- grep: /runs Browser Studio in Safari/,
- use: {...devices['Desktop Safari']},
- },
],
webServer: {
command: `PORT=${port} bun e2e/server.ts`,
diff --git a/packages/studio-server/src/test/open-in-coding-agent.test.ts b/packages/studio-server/src/test/open-in-coding-agent.test.ts
index e5800deffc..40aaa2ea37 100644
--- a/packages/studio-server/src/test/open-in-coding-agent.test.ts
+++ b/packages/studio-server/src/test/open-in-coding-agent.test.ts
@@ -318,13 +318,20 @@ test.skipIf(process.platform === 'win32')(
});
expect(success).toBe(true);
- for (let attempt = 0; attempt < 100 && !existsSync(output); attempt++) {
+ const expectedOutput = 'app\n/Users/test/My Project\n';
+ let receivedOutput = '';
+ for (let attempt = 0; attempt < 100; attempt++) {
+ if (existsSync(output)) {
+ receivedOutput = readFileSync(output, 'utf8');
+ if (receivedOutput === expectedOutput) {
+ break;
+ }
+ }
+
await Bun.sleep(10);
}
- expect(readFileSync(output, 'utf8')).toBe(
- 'app\n/Users/test/My Project\n',
- );
+ expect(receivedOutput).toBe(expectedOutput);
} finally {
rmSync(directory, {force: true, recursive: true});
}
@@ -370,13 +377,20 @@ test.skipIf(process.platform === 'win32')(
});
expect(success).toBe(true);
- for (let attempt = 0; attempt < 100 && !existsSync(output); attempt++) {
+ const expectedOutput = `${realpathSync(projectPath)}\n`;
+ let receivedOutput = '';
+ for (let attempt = 0; attempt < 100; attempt++) {
+ if (existsSync(output)) {
+ receivedOutput = readFileSync(output, 'utf8');
+ if (receivedOutput === expectedOutput) {
+ break;
+ }
+ }
+
await Bun.sleep(10);
}
- expect(readFileSync(output, 'utf8')).toBe(
- `${realpathSync(projectPath)}\n`,
- );
+ expect(receivedOutput).toBe(expectedOutput);
} finally {
rmSync(directory, {force: true, recursive: true});
}
diff --git a/packages/web-renderer/src/test/render-media.test.tsx b/packages/web-renderer/src/test/render-media.test.tsx
index dcca05d527..c56dd38efb 100644
--- a/packages/web-renderer/src/test/render-media.test.tsx
+++ b/packages/web-renderer/src/test/render-media.test.tsx
@@ -198,74 +198,6 @@ test('should not increase page scroll dimensions while rendering', async (t) =>
);
});
-test('should throttle onProgress callback to 250ms', {retry: 2}, async (t) => {
- if (t.task.file.projectName === 'webkit') {
- t.skip();
- return;
- }
-
- const Component: React.FC = () => {
- const frame = useCurrentFrame();
- return (
- <svg viewBox="0 0 100 100" style={{width: 400, height: 400}}>
- <circle
- cx="50"
- cy="50"
- r="50"
- fill={interpolateColors(frame, [0, 30], ['red', 'blue'])}
- />
- </svg>
- );
- };
-
- const progressCalls: Array<{
- time: number;
- progress: RenderMediaOnWebProgress;
- }> = [];
- const startTime = Date.now();
-
- await renderMediaOnWeb({
- composition: {
- component: Component,
- id: 'throttle-test',
- width: 400,
- height: 400,
- fps: 30,
- durationInFrames: 30,
- },
- inputProps: {},
- onProgress: (progress) => {
- progressCalls.push({
- time: Date.now() - startTime,
- progress: {...progress},
- });
- },
- });
-
- // Should have at least one progress call
- expect(progressCalls.length).toBeGreaterThan(0);
-
- // Final call should have all frames rendered and encoded
- const finalCall = progressCalls[progressCalls.length - 1];
- expect(finalCall.progress).toEqual({
- renderedFrames: 30,
- encodedFrames: 30,
- doneIn: expect.any(Number),
- renderEstimatedTime: 0,
- progress: 1,
- });
-
- // Check that calls are throttled (if we have multiple calls)
- if (progressCalls.length > 1) {
- for (let i = 1; i < progressCalls.length - 1; i++) {
- const timeDiff = progressCalls[i].time - progressCalls[i - 1].time;
- // Allow some variance but should be around 250ms
- // We use 200ms as lower bound to account for timing variations
- expect(timeDiff).toBeGreaterThanOrEqual(200);
- }
- }
-});
-
test(
'should provide progress estimates while rendering',
{retry: 2},