🎥 Make videos programmatically with React
`remotion`: Fix unnecessary context updates in `<Freeze>`
Jonny Burgerf90096202001
diff --git a/packages/core/src/freeze.tsx b/packages/core/src/freeze.tsxindex f4a6a21e49..88767b443e 100644--- a/packages/core/src/freeze.tsx+++ b/packages/core/src/freeze.tsx@@ -72,14 +72,12 @@ export const Freeze: React.FC<FreezeProps> = ({const relativeFrom = sequenceContext?.relativeFrom ?? 0;const playbackRate = sequenceContext?.playbackRate ?? 1;+ const {audioAndVideoTags} = timelineContext;- const timelineValue: TimelineContextValue = useMemo(() => {- if (!isActive) {- return timelineContext;- }-+ // Advancing the outer timeline must not invalidate the frozen clock.+ const frozenTimelineValue: TimelineContextValue = useMemo(() => {return {- ...timelineContext,+ audioAndVideoTags,isPlaying: () => false,isInsideFreeze: true,frame: {@@ -87,8 +85,7 @@ export const Freeze: React.FC<FreezeProps> = ({},};}, [- isActive,- timelineContext,+ audioAndVideoTags,videoConfig.id,frameToFreeze,relativeFrom,@@ -117,7 +114,9 @@ export const Freeze: React.FC<FreezeProps> = ({(Boolean(isActive) && !_remotionInternalIsPremounting)}>- <TimelineContext.Provider value={timelineValue}>+ <TimelineContext.Provider+ value={isActive ? frozenTimelineValue : timelineContext}+ ><SequenceContext.Provider value={newSequenceContext}>{children}</SequenceContext.Provider>diff --git a/packages/example/src/WhatsNew/WhatsNew.tsx b/packages/example/src/WhatsNew/WhatsNew.tsxindex 8641593405..6221a9e278 100644--- a/packages/example/src/WhatsNew/WhatsNew.tsx+++ b/packages/example/src/WhatsNew/WhatsNew.tsx@@ -14,11 +14,28 @@ import {SneakPeekScene} from './scenes/SneakPeek';import {SoundEffectsScene} from './scenes/SoundEffects';import {VercelScene} from './scenes/Vercel';+const Score: React.FC = () => {+ const frame = useCurrentFrame();++ return (+ <Audio+ name="Score"+ src={+ 'https://remotion.media/announcements/whats-new-in-remotion/cursor/music/score.wav'+ }+ volume={interpolate(+ frame,+ [0, 16, 106, 114, 204, 226, 6250, 6280, 7160, 7172, 7296, 7328],+ [0, 0.3, 0.3, 0.55, 0.55, 0.13, 0.13, 0.17, 0.17, 0.7, 0.7, 0],+ {extrapolateLeft: 'clamp', extrapolateRight: 'clamp'},+ )}+ />+ );+};+// Every scene is a whole number of beats (16 frames at 112.5 BPM), so each// chapter starts on a downbeat of the score.export const WhatsNew: React.FC = () => {- const frame = useCurrentFrame();-return (<AbsoluteFill style={{backgroundColor: '#000'}}><TransitionSeries name="Chapters">@@ -117,18 +134,7 @@ export const WhatsNew: React.FC = () => {</TransitionSeries.Sequence></TransitionSeries>- <Audio- name="Score"- src={- 'https://remotion.media/announcements/whats-new-in-remotion/cursor/music/score.wav'- }- volume={interpolate(- frame,- [0, 16, 106, 114, 204, 226, 6250, 6280, 7160, 7172, 7296, 7328],- [0, 0.3, 0.3, 0.55, 0.55, 0.13, 0.13, 0.17, 0.17, 0.7, 0.7, 0],- {extrapolateLeft: 'clamp', extrapolateRight: 'clamp'},- )}- />+ <Score /></AbsoluteFill>);};diff --git a/packages/jonnys-videos/src/roller-skis/Composition.tsx b/packages/jonnys-videos/src/roller-skis/Composition.tsxindex 737574e852..aa52a07e5b 100644--- a/packages/jonnys-videos/src/roller-skis/Composition.tsx+++ b/packages/jonnys-videos/src/roller-skis/Composition.tsx@@ -645,10 +645,40 @@ export const PresenterIntroduction: React.FC = () => {);};-const RollerSkiRoughCut: React.FC = () => {+const EndCardSequence: React.FC = () => {const frame = useCurrentFrame();const {fps} = useVideoConfig();+ return (+ <Sequence+ name="Jonny Burger YouTube end card"+ from={END_CARD_START}+ durationInFrames={END_CARD_DURATION_IN_FRAMES}+ premountFor={fps}+ >+ <AbsoluteFill+ style={{+ translate: interpolate(+ frame,+ [12115, 12139],+ ['1920px 0px', '0px 0px'],+ {+ easing: [Easing.bezier(0.22, 1, 0.36, 1)],+ extrapolateLeft: 'clamp',+ extrapolateRight: 'clamp',+ },+ ),+ }}+ >+ <YouTubeEndCard />+ </AbsoluteFill>+ </Sequence>+ );+};++const RollerSkiRoughCut: React.FC = () => {+ const {fps} = useVideoConfig();+return (<><Series>@@ -1360,10 +1390,7 @@ const RollerSkiRoughCut: React.FC = () => {objectFit="cover"premountFor={fps}effects={[lut({content: outdoorLut})]}- volume={interpolate(frame, [2697, 2896], [1, 1], {- extrapolateLeft: 'clamp',- extrapolateRight: 'clamp',- })}+ volume={1}/><BasicCaptionsname="Climbing the incline captions"@@ -3997,29 +4024,7 @@ const RollerSkiRoughCut: React.FC = () => {/></Series.Sequence></Series>- <Sequence- name="Jonny Burger YouTube end card"- from={END_CARD_START}- durationInFrames={END_CARD_DURATION_IN_FRAMES}- premountFor={fps}- >- <AbsoluteFill- style={{- translate: interpolate(- frame,- [12115, 12139],- ['1920px 0px', '0px 0px'],- {- easing: [Easing.bezier(0.22, 1, 0.36, 1)],- extrapolateLeft: 'clamp',- extrapolateRight: 'clamp',- },- ),- }}- >- <YouTubeEndCard />- </AbsoluteFill>- </Sequence>+ <EndCardSequence /><Audioname="No School Today music"src={rollerSkiAsset('audio/no-school-today-femme-tov.wav')}