🎥 Make videos programmatically with React
Fix HLS video playback in Chrome
Igor Samokhovetsfaa9d0c2c608
diff --git a/packages/docs/src/components/MuxVideo.tsx b/packages/docs/src/components/MuxVideo.tsxindex e61f77aa4a..7b21463ee2 100644--- a/packages/docs/src/components/MuxVideo.tsx+++ b/packages/docs/src/components/MuxVideo.tsx@@ -25,14 +25,12 @@ const MuxVideoForward: React.ForwardRefRenderFunction<let hls: Hls;if (videoRef.current) {const {current} = videoRef;- if (current.canPlayType('application/vnd.apple.mpegurl')) {- // Some browers (safari and ie edge) support HLS natively- current.src = vidUrl;- } else if (Hls.isSupported()) {- // This will run in all other modern browsers+ if (Hls.isSupported()) {hls = new Hls();hls.loadSource(vidUrl);hls.attachMedia(current);+ } else if (current.canPlayType('application/vnd.apple.mpegurl')) {+ current.src = vidUrl;} else {console.error("This is a legacy browser that doesn't support MSE");}diff --git a/packages/docs/src/components/VideoPlayerWithControls.tsx b/packages/docs/src/components/VideoPlayerWithControls.tsxindex 9393a6a7b2..5e1f30354c 100644--- a/packages/docs/src/components/VideoPlayerWithControls.tsx+++ b/packages/docs/src/components/VideoPlayerWithControls.tsx@@ -150,11 +150,7 @@ export const VideoPlayerWithControls = forwardRef<captions: {active: true, language: 'auto', update: true},});- if (video.canPlayType('application/vnd.apple.mpegurl')) {- // This will run in safari, where HLS is supported natively- video.src = src;- } else if (Hls.isSupported()) {- // This will run in all other modern browsers+ if (Hls.isSupported()) {hls = new Hls();hls.loadSource(src);hls.attachMedia(video);@@ -163,6 +159,8 @@ export const VideoPlayerWithControls = forwardRef<videoError(new ErrorEvent('HLS.js fatal error'));}});+ } else if (video.canPlayType('application/vnd.apple.mpegurl')) {+ video.src = src;} else {console.error('This is an old browser that does not support MSE https://developer.mozilla.org/en-US/docs/Web/API/Media_Source_Extensions_API',diff --git a/packages/promo-pages/src/components/homepage/MuxVideo.tsx b/packages/promo-pages/src/components/homepage/MuxVideo.tsxindex c4df9c77db..e06e4b6a8d 100644--- a/packages/promo-pages/src/components/homepage/MuxVideo.tsx+++ b/packages/promo-pages/src/components/homepage/MuxVideo.tsx@@ -24,14 +24,12 @@ const MuxVideoForward: React.ForwardRefRenderFunction<let hls: Hls;if (videoRef.current) {const {current} = videoRef;- if (current.canPlayType('application/vnd.apple.mpegurl')) {- // Some browers (safari and ie edge) support HLS natively- current.src = vidUrl;- } else if (Hls.isSupported()) {- // This will run in all other modern browsers+ if (Hls.isSupported()) {hls = new Hls();hls.loadSource(vidUrl);hls.attachMedia(current);+ } else if (current.canPlayType('application/vnd.apple.mpegurl')) {+ current.src = vidUrl;} else {// eslint-disable-next-line no-consoleconsole.error("This is a legacy browser that doesn't support MSE");diff --git a/packages/promo-pages/src/components/homepage/VideoPlayerWithControls.tsx b/packages/promo-pages/src/components/homepage/VideoPlayerWithControls.tsxindex b57d51119d..93558c3a15 100644--- a/packages/promo-pages/src/components/homepage/VideoPlayerWithControls.tsx+++ b/packages/promo-pages/src/components/homepage/VideoPlayerWithControls.tsx@@ -136,11 +136,7 @@ export const VideoPlayerWithControls = forwardRef<captions: {active: true, language: 'auto', update: true},});- if (video.canPlayType('application/vnd.apple.mpegurl')) {- // This will run in safari, where HLS is supported natively- video.src = src;- } else if (Hls.isSupported()) {- // This will run in all other modern browsers+ if (Hls.isSupported()) {hls = new Hls();hls.loadSource(src);hls.attachMedia(video);@@ -149,6 +145,8 @@ export const VideoPlayerWithControls = forwardRef<videoError(new ErrorEvent('HLS.js fatal error'));}});+ } else if (video.canPlayType('application/vnd.apple.mpegurl')) {+ video.src = src;} else {console.error('This is an old browser that does not support MSE https://developer.mozilla.org/en-US/docs/Web/API/Media_Source_Extensions_API',