Skip to content

🎥 Make videos programmatically with React

Rename render queue tab to Jobs

JonnyBurgerfe2a9d7ba6d0
diff --git a/packages/example/e2e/render-output-drag.test.mts b/packages/example/e2e/render-output-drag.test.mts
index d10a4aa722..b75c8ae58a 100644
--- a/packages/example/e2e/render-output-drag.test.mts
+++ b/packages/example/e2e/render-output-drag.test.mts
@@ -1,6 +1,6 @@
+import {expect, test} from '@playwright/test';
import fs from 'node:fs';
import path from 'node:path';
-import {expect, test} from '@playwright/test';
import {apiCall} from './api-call.mts';
import {STUDIO_URL, exampleDir} from './constants.mts';
import {startStudio, stopStudio} from './studio-server.mts';
@@ -63,7 +63,7 @@ test.describe('render output dragging', () => {
window.localStorage.setItem('remotion.sidebarPanel', 'renders');
});
await page.reload();
- await expect(page.getByText('Renders', {exact: true})).toBeVisible();
+ await expect(page.getByText('Jobs', {exact: true})).toBeVisible();
const result = await apiCall('/api/register-client-render', {
id,
type: 'client-video',
diff --git a/packages/studio/src/components/RendersTab.tsx b/packages/studio/src/components/RendersTab.tsx
index e5bb85dd63..76dd934567 100644
--- a/packages/studio/src/components/RendersTab.tsx
+++ b/packages/studio/src/components/RendersTab.tsx
@@ -33,9 +33,6 @@ export const RendersTab: React.FC<{
(job) => job.status === 'failed',
).length;
const jobCount = jobs.length + captionJobs.length;
- const hasRunningCaptionJob = captionJobs.some(
- (job) => job.status === 'running',
- );
const badgeStyle: React.CSSProperties = useMemo(() => {
return {
@@ -51,7 +48,7 @@ export const RendersTab: React.FC<{
return (
<Tab selected={selected} onClick={onClick}>
<div style={row}>
- {hasRunningCaptionJob ? 'Jobs' : 'Renders'}
+ Jobs
{jobCount > 0 ? (
<>
<Flex />
diff --git a/packages/studio/src/test/renders-tab-caption-jobs.test.tsx b/packages/studio/src/test/renders-tab-caption-jobs.test.tsx
index e87d54f231..6afc64f8c7 100644
--- a/packages/studio/src/test/renders-tab-caption-jobs.test.tsx
+++ b/packages/studio/src/test/renders-tab-caption-jobs.test.tsx
@@ -67,7 +67,7 @@ const baseJob = {
noRepeatNgramSize: 0,
} as const;
-test('labels the renders tab as Jobs while a caption job is running', () => {
+test('labels the render queue tab as Jobs while a caption job is running', () => {
renderWithCaptionJob({
...baseJob,
status: 'running',
@@ -100,7 +100,7 @@ test('opens a completed caption output as an asset without showing its caption c
captionCount: 10,
});
- expect(screen.getByText('Renders')).toBeTruthy();
+ expect(screen.getByText('Jobs')).toBeTruthy();
expect(screen.queryByText(/10 captions/)).toBeNull();
expect(screen.getByText('dialogue-captions.json')).toBeTruthy();
fireEvent.click(screen.getByText('dialogue-captions.json'));