🎥 Make videos programmatically with React
Fix short AAC MP4 exports in web renderer
Alec Wattsff9922e5940b
diff --git a/packages/web-renderer/src/render-media-on-web.tsx b/packages/web-renderer/src/render-media-on-web.tsxindex df547280df..055a1df7a0 100644--- a/packages/web-renderer/src/render-media-on-web.tsx+++ b/packages/web-renderer/src/render-media-on-web.tsx@@ -500,9 +500,13 @@ const internalRenderMediaOnWeb = async <outputWithCleanup.output.addAudioTrack(audioSampleSource.audioSampleSource,{- // ~1 packet per 10ms, + 33% buffer+ // ~1 packet per 10ms, + 33% buffer; short AAC renders+ // need room for encoder flush packets beyond their duration.// https://mediabunny.dev/api/BaseTrackMetadata#maximumpacketcount- maximumPacketCount: Math.ceil(durationInSeconds * 100 * 1.33),+ maximumPacketCount: Math.max(+ 8,+ Math.ceil(durationInSeconds * 100 * 1.33),+ ),},);}diff --git a/packages/web-renderer/src/test/render-media.test.tsx b/packages/web-renderer/src/test/render-media.test.tsxindex c56dd38efb..2ed858bc94 100644--- a/packages/web-renderer/src/test/render-media.test.tsx+++ b/packages/web-renderer/src/test/render-media.test.tsx@@ -57,6 +57,46 @@ test('should render media on web', async (t) => {});});+test.each([false, true])(+ 'should render a one-frame 60fps MP4 with AAC (streaming: %s)',+ async (streaming, t) => {+ if (t.task.file.projectName === 'webkit') {+ t.skip();+ return;+ }++ const chunks: StreamTargetChunk[] = [];+ const outputWritable = streaming+ ? new WritableStream<StreamTargetChunk>({+ write: (chunk) => {+ chunks.push(chunk);+ },+ })+ : undefined;+ const result = await renderMediaOnWeb({+ composition: {+ component: () => null,+ id: 'short-mp4-aac-test',+ width: 100,+ height: 100,+ fps: 60,+ durationInFrames: 1,+ },+ inputProps: {},+ container: 'mp4',+ videoCodec: 'h264',+ audioCodec: 'aac',+ ...(outputWritable ? {outputWritable} : {}),+ });++ if (streaming) {+ expect(chunks.length).toBeGreaterThan(0);+ } else {+ expect((await result.getBlob()).size).toBeGreaterThan(0);+ }+ },+);+test('should render media to a writable stream', async (t) => {if (t.task.file.projectName === 'webkit') {t.skip();