Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
"""Tests for the post-commit hook installer's legacy-block migration.
Pre-marker repowise versions wrote a hook body without start/end markers
that ended in `exit 0`, which made any later marker-based block dead code.
On Windows the legacy invocation also tended to fail every commit because
`uv run repowise update` would rebuild the venv from scratch. The
installer must detect those bodies and excise them before appending the
new marker block.
"""
from __future__ import annotations
import subprocess
import pytest
from repowise.cli.hooks import _strip_legacy_block, install, status
@pytest.fixture
def git_repo(tmp_path):
subprocess.run(["git", "init", "-q"], cwd=tmp_path, check=True)
return tmp_path
_LEGACY_BODY = """\
#!/bin/sh
# post-commit hook: auto-update repowise wiki after each commit
# Runs in the background so it doesn't block your terminal
echo "[repowise] Triggering incremental wiki update..."
(
cd "$(git rev-parse --show-toplevel)" || exit 1
powershell.exe -Command "uv run repowise update" > /tmp/repowise-update.log 2>&1
) &
exit 0
"""
def test_strip_legacy_block_removes_only_legacy_section():
after_block = "# my own custom hook\necho 'kept'\n"
content = _LEGACY_BODY + "\n" + after_block
cleaned, stripped = _strip_legacy_block(content)
assert stripped is True
assert "Triggering incremental wiki update" not in cleaned
assert "/tmp/repowise-update.log" not in cleaned
assert "echo 'kept'" in cleaned
def test_strip_legacy_block_noop_for_clean_content():
content = "#!/bin/sh\necho 'fine'\n"
cleaned, stripped = _strip_legacy_block(content)
assert stripped is False
assert cleaned == content
class TestInstallMigratesLegacyHook:
def test_install_over_legacy_replaces_with_marker_block(self, git_repo):
hook = git_repo / ".git" / "hooks" / "post-commit"
hook.parent.mkdir(parents=True, exist_ok=True)
hook.write_text(_LEGACY_BODY, encoding="utf-8")
result = install(git_repo)
assert result == "installed"
content = hook.read_text(encoding="utf-8")
assert "# repowise-hook-start" in content
assert "# repowise-hook-end" in content
# Legacy fingerprints must be gone
assert "Triggering incremental wiki update" not in content
assert "/tmp/repowise-update.log" not in content
# And there must be no leftover `exit 0` that would shadow the new
# marker block.
assert "\nexit 0\n" not in content
def test_install_over_legacy_plus_marker_returns_migrated(self, git_repo):
# Existing file already has both: legacy block (unreachable) AND
# a marker block. Installer should strip the legacy half and
# report the migration.
from repowise.cli.hooks import _HOOK_SCRIPT
hook = git_repo / ".git" / "hooks" / "post-commit"
hook.parent.mkdir(parents=True, exist_ok=True)
hook.write_text(
_LEGACY_BODY + "\n" + _HOOK_SCRIPT, encoding="utf-8"
)
result = install(git_repo)
assert result == "migrated legacy hook"
content = hook.read_text(encoding="utf-8")
assert "Triggering incremental wiki update" not in content
assert "# repowise-hook-start" in content
def test_install_already_marker_only_is_idempotent(self, git_repo):
install(git_repo) # First install — fresh
result = install(git_repo) # Second install — should be a no-op
assert result == "already installed"
assert status(git_repo) == "installed"
def test_install_preserves_unrelated_hook_content(self, git_repo):
hook = git_repo / ".git" / "hooks" / "post-commit"
hook.parent.mkdir(parents=True, exist_ok=True)
hook.write_text(
"#!/bin/sh\n# my project's lint hook\necho 'lint'\n",
encoding="utf-8",
)
install(git_repo)
content = hook.read_text(encoding="utf-8")
assert "echo 'lint'" in content
assert "# repowise-hook-start" in content
# Snapshot of the marker-bracketed hook body that shipped before the
# cross-platform / coalescing rewrite. Used to verify ``install`` upgrades
# the block in place (vs. bailing with "already installed", which was the
# behaviour that left users stuck on a buggy hook).
_PREVIOUS_MARKER_HOOK = """\
# repowise-hook-start
# Auto-syncs repowise wiki after each commit (background, non-blocking).
# Installed by: repowise hook install
(
cd "$(git rev-parse --show-toplevel)" || exit 1
if [ -d ".repowise" ]; then
if command -v repowise >/dev/null 2>&1; then
repowise update > /dev/null 2>&1
elif command -v uv >/dev/null 2>&1; then
uv run repowise update > /dev/null 2>&1
elif command -v powershell.exe >/dev/null 2>&1; then
powershell.exe -Command "uv run repowise update" > /dev/null 2>&1
fi
fi
) &
# repowise-hook-end
"""
class TestInstallUpgradesMarkerBlock:
"""``install`` over an existing marker block whose body differs from the
current ``_HOOK_SCRIPT`` should replace the block in place, preserving
any other content around the markers."""
def test_install_upgrades_in_place_when_body_differs(self, git_repo):
hook = git_repo / ".git" / "hooks" / "post-commit"
hook.parent.mkdir(parents=True, exist_ok=True)
hook.write_text("#!/bin/sh\n" + _PREVIOUS_MARKER_HOOK, encoding="utf-8")
result = install(git_repo)
assert result == "upgraded"
content = hook.read_text(encoding="utf-8")
# The new hook writes the queued marker before backgrounding; the
# old hook didn't. Use that signal as the upgrade fingerprint.
assert ".update.queued" in content
# And the silent /dev/null sink from the old hook must be gone.
assert "repowise update > /dev/null 2>&1" not in content
def test_install_upgrades_preserves_surrounding_hooks(self, git_repo):
hook = git_repo / ".git" / "hooks" / "post-commit"
hook.parent.mkdir(parents=True, exist_ok=True)
hook.write_text(
"#!/bin/sh\n"
"# my lint hook\n"
"echo 'pre-existing lint'\n\n"
+ _PREVIOUS_MARKER_HOOK
+ "\n# trailing hook\necho 'trailing'\n",
encoding="utf-8",
)
install(git_repo)
content = hook.read_text(encoding="utf-8")
assert "pre-existing lint" in content
assert "trailing" in content
assert ".update.queued" in content
def test_install_idempotent_when_body_already_current(self, git_repo):
install(git_repo) # Fresh install of the current body.
result = install(git_repo)
assert result == "already installed"
class TestInstallInWorktree:
"""Issue #1609: a git worktree stores ``.git`` as a *file*, not a
directory, so the naive ``root / \".git\" / \"hooks\"`` path crashed
``install``/``status`` with ``NotADirectoryError`` and took down ``init``.
``_hooks_dir`` resolves the real hooks path via git instead."""
@pytest.fixture
def worktree(self, tmp_path):
main = tmp_path / "main"
main.mkdir()
subprocess.run(["git", "init", "-q"], cwd=main, check=True)
(main / "f.txt").write_text("hi\n", encoding="utf-8")
subprocess.run(["git", "add", "."], cwd=main, check=True)
subprocess.run(
["git", "-c", "user.email=t@t", "-c", "user.name=t", "commit", "-qm", "init"],
cwd=main,
check=True,
)
wt = tmp_path / "wt"
subprocess.run(["git", "worktree", "add", "-q", str(wt)], cwd=main, check=True)
assert (wt / ".git").is_file(), "expected .git to be a file in a worktree"
return wt
def test_install_does_not_crash_in_worktree(self, worktree):
result = install(worktree)
assert result == "installed"
assert status(worktree) == "installed"
def test_status_in_worktree_is_not_an_error(self, worktree):
assert status(worktree) == "not installed"
class TestInstalledHookScript:
"""Sanity checks on the shipped hook script so platform-specific
regressions (e.g. accidentally introducing bash-only syntax) get caught
by unit tests rather than by a user's git commit."""
def test_hook_does_not_use_bash_only_features(self):
from repowise.cli.hooks import _HOOK_SCRIPT
# ``[[ ]]``, ``$( <(...) )``, named arrays — all bashisms that fail
# under plain ``/bin/sh`` on Alpine and minimal Mac installs. The
# hook must stay POSIX-clean.
assert "[[" not in _HOOK_SCRIPT
assert "<(" not in _HOOK_SCRIPT
def test_hook_writes_queued_marker_and_log(self):
from repowise.cli.hooks import _HOOK_SCRIPT
# Two invariants the augment-hook tests rely on.
assert ".update.queued" in _HOOK_SCRIPT
assert ".update.log" in _HOOK_SCRIPT
# And no silent /dev/null sink — that was the original bug.
assert "> /dev/null 2>&1" not in _HOOK_SCRIPT or ">> \"$LOG\"" in _HOOK_SCRIPT