Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

fix(ui): render MetricCard label and description as blocks (#3875)

Raghav Chamadiya094dce1c2f22
diff --git a/packages/ui/__tests__/shared/metric-card.test.tsx b/packages/ui/__tests__/shared/metric-card.test.tsx
index 567869048..562cd3a8c 100644
--- a/packages/ui/__tests__/shared/metric-card.test.tsx
+++ b/packages/ui/__tests__/shared/metric-card.test.tsx
@@ -9,6 +9,15 @@ describe("MetricCard", () => {
expect(screen.getByText("42")).toBeInTheDocument();
});
+ it("keeps block nodes in the label and description out of a <p>", () => {
+ // StatGridSkeleton passes a Skeleton <div> for both; inside a <p> that is
+ // invalid HTML and a hydration error.
+ const { container } = render(
+ <MetricCard label={<div>label</div>} value="1" description={<div>desc</div>} />,
+ );
+ expect(container.querySelector("p div")).toBeNull();
+ });
+
it("renders an optional description when provided", () => {
render(<MetricCard label="Coverage" value="87%" description="last 30 days" />);
expect(screen.getByText("last 30 days")).toBeInTheDocument();
diff --git a/packages/ui/src/shared/metric-card.tsx b/packages/ui/src/shared/metric-card.tsx
index 68ab649d1..02d98440d 100644
--- a/packages/ui/src/shared/metric-card.tsx
+++ b/packages/ui/src/shared/metric-card.tsx
@@ -62,9 +62,9 @@ export function MetricCard({
<CardContent className="p-4">
<div className="flex items-start justify-between gap-2">
<div className="min-w-0 space-y-1">
- <p className="text-xs font-medium uppercase tracking-wider text-[var(--color-text-tertiary)]">
+ <div className="text-xs font-medium uppercase tracking-wider text-[var(--color-text-tertiary)]">
{label}
- </p>
+ </div>
<div className="flex items-baseline gap-2">
<div className="text-2xl font-bold tabular-nums text-[var(--color-text-primary)]">
{value}
@@ -85,7 +85,7 @@ export function MetricCard({
)}
</div>
{description && (
- <p className="text-xs text-[var(--color-text-secondary)]">{description}</p>
+ <div className="text-xs text-[var(--color-text-secondary)]">{description}</div>
)}
</div>
{icon && (