Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix: scope superseded decision references (#3748)
Aykut Güney0a0285e21202
diff --git a/packages/server/src/repowise/server/routers/decisions.py b/packages/server/src/repowise/server/routers/decisions.pyindex f3cdb72b6..28cdb26ec 100644--- a/packages/server/src/repowise/server/routers/decisions.py+++ b/packages/server/src/repowise/server/routers/decisions.py@@ -640,13 +640,23 @@ async def create_decision(async def _transition_status(- session: AsyncSession, decision_id: str, status: str, superseded_by: str | None+ session: AsyncSession,+ repo_id: str,+ decision_id: str,+ status: str,+ superseded_by: str | None,):"""Move a decision to *status* as a person on the web, or 400/404."""# The successor is a caller-supplied id too, and storing a retired one# would record a pointer that no longer resolves.if superseded_by is not None:- superseded_by = await _live_decision_id(session, superseded_by)+ successor = await _decision_in_repo(session, repo_id, superseded_by)+ if successor.id == decision_id:+ raise HTTPException(+ status_code=400,+ detail="A decision cannot supersede itself",+ )+ superseded_by = successor.idtry:rec = await crud.update_decision_status(session,@@ -685,7 +695,9 @@ async def patch_decision(decision_id = rec.idif body.status is not None:- rec = await _transition_status(session, decision_id, body.status, body.superseded_by)+ rec = await _transition_status(+ session, repo_id, decision_id, body.status, body.superseded_by+ )elif body.superseded_by is not None:raise HTTPException(status_code=400,diff --git a/tests/unit/server/test_decisions_patch.py b/tests/unit/server/test_decisions_patch.pyindex 99360f864..ece7499bc 100644--- a/tests/unit/server/test_decisions_patch.py+++ b/tests/unit/server/test_decisions_patch.py@@ -12,18 +12,21 @@ from httpx import AsyncClientfrom repowise.core.persistence import crudfrom repowise.core.persistence.database import get_session+from repowise.core.persistence.models import DecisionAliasfrom tests.unit.server.conftest import create_test_repo-async def _seed_decision(session_factory, repo_id: str) -> str:+async def _seed_decision(+ session_factory, repo_id: str, title: str = "Use SQLite for the dev DB"+) -> str:async with get_session(session_factory) as session:rec = await crud.upsert_decision(session,repository_id=repo_id,- title="Use SQLite for the dev DB",+ title=title,status="active",context="Local dev needs zero-config storage.",- decision="SQLite via aiosqlite for all unit tests and CLI runs.",+ decision=f"Use {title} for all unit tests and CLI runs.",affected_modules=["packages/core"],affected_files=["packages/core/src/repowise/core/persistence/database.py"],source="cli",@@ -90,22 +93,105 @@ async def test_patch_decision_clear_files(client: AsyncClient, app) -> None:async def test_patch_decision_status_and_modules(client: AsyncClient, app) -> None:repo = await create_test_repo(client)decision_id = await _seed_decision(app.state.session_factory, repo["id"])+ successor_id = await _seed_decision(+ app.state.session_factory, repo["id"], "Use PostgreSQL in production"+ )resp = await client.patch(f"/api/repos/{repo['id']}/decisions/{decision_id}",json={"status": "superseded",- "superseded_by": "abc123",+ "superseded_by": successor_id,"affected_modules": ["packages/server"],},)assert resp.status_code == 200body = resp.json()assert body["status"] == "superseded"- assert body["superseded_by"] == "abc123"+ assert body["superseded_by"] == successor_idassert body["affected_modules"] == ["packages/server"]+async def test_patch_decision_rejects_unknown_successor(client: AsyncClient, app) -> None:+ repo = await create_test_repo(client)+ decision_id = await _seed_decision(app.state.session_factory, repo["id"])++ resp = await client.patch(+ f"/api/repos/{repo['id']}/decisions/{decision_id}",+ json={"status": "superseded", "superseded_by": "no-such-decision"},+ )++ assert resp.status_code == 404+ current = await client.get(f"/api/repos/{repo['id']}/decisions/{decision_id}")+ assert current.status_code == 200+ assert current.json()["status"] == "active"+ assert current.json()["superseded_by"] is None+++async def test_patch_decision_rejects_cross_repo_successor(client: AsyncClient, app) -> None:+ repo_a = await create_test_repo(client)+ repo_b = await create_test_repo(client)+ decision_id = await _seed_decision(app.state.session_factory, repo_a["id"])+ foreign_id = await _seed_decision(+ app.state.session_factory, repo_b["id"], "Use PostgreSQL in the other repo"+ )++ resp = await client.patch(+ f"/api/repos/{repo_a['id']}/decisions/{decision_id}",+ json={"status": "superseded", "superseded_by": foreign_id},+ )++ assert resp.status_code == 404+ current = await client.get(f"/api/repos/{repo_a['id']}/decisions/{decision_id}")+ assert current.status_code == 200+ assert current.json()["status"] == "active"+ assert current.json()["superseded_by"] is None+++async def test_patch_decision_resolves_same_repo_successor_alias(+ client: AsyncClient, app+) -> None:+ repo = await create_test_repo(client)+ sf = app.state.session_factory+ successor_id = await _seed_decision(sf, repo["id"], "Use the successor decision")+ decision_id = await _seed_decision(sf, repo["id"], "Retire this decision")+ retired_id = "f" * 32+ async with get_session(sf) as session:+ session.add(+ DecisionAlias(+ alias_id=retired_id,+ repository_id=repo["id"],+ decision_id=successor_id,+ reason="superseded",+ )+ )+ await session.commit()++ resp = await client.patch(+ f"/api/repos/{repo['id']}/decisions/{decision_id}",+ json={"status": "superseded", "superseded_by": retired_id},+ )++ assert resp.status_code == 200+ assert resp.json()["superseded_by"] == successor_id+++async def test_patch_decision_rejects_self_successor(client: AsyncClient, app) -> None:+ repo = await create_test_repo(client)+ decision_id = await _seed_decision(app.state.session_factory, repo["id"])++ resp = await client.patch(+ f"/api/repos/{repo['id']}/decisions/{decision_id}",+ json={"status": "superseded", "superseded_by": decision_id},+ )++ assert resp.status_code == 400++@pytest.mark.asyncioasync def test_patch_decision_not_found(client: AsyncClient) -> None:repo = await create_test_repo(client)