Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

fix(analysis): align barrel filename definitions with file_reachability (#1491) (#1557)

Rishabh Mishra0b114babcb88
diff --git a/packages/core/src/repowise/core/analysis/dead_code/file_reachability.py b/packages/core/src/repowise/core/analysis/dead_code/file_reachability.py
index 137dbfece..43566dbe8 100644
--- a/packages/core/src/repowise/core/analysis/dead_code/file_reachability.py
+++ b/packages/core/src/repowise/core/analysis/dead_code/file_reachability.py
@@ -68,6 +68,7 @@ BARREL_FILENAMES: frozenset[str] = frozenset(
"index.cts",
"index.mjs",
"index.cjs",
+ "mod.rs",
}
)
@@ -288,6 +289,8 @@ def is_file_reachable(
return True
if path in rescues.whitelist:
return True
+ # BARREL_FILENAMES entries are strictly lowercase matching standard file-system conventions
+ # (e.g. index.ts, __init__.py, mod.rs).
if PurePosixPath(path).name in BARREL_FILENAMES:
return True
# Bundler ``resolve.alias`` targets are reached through the aliased package
diff --git a/packages/core/src/repowise/core/analysis/health/refactoring/split_file.py b/packages/core/src/repowise/core/analysis/health/refactoring/split_file.py
index 32e89a71c..6f55497cc 100644
--- a/packages/core/src/repowise/core/analysis/health/refactoring/split_file.py
+++ b/packages/core/src/repowise/core/analysis/health/refactoring/split_file.py
@@ -54,6 +54,7 @@ from typing import Any
from repowise.core.analysis.execution_graph import is_reliable_call_edge
from ....test_paths import is_test_related_path
+from ...dead_code.file_reachability import BARREL_FILENAMES
from .models import RefactoringContext, RefactoringSuggestion
from .registry import RefactoringDetector, effort_bucket, register
@@ -126,7 +127,7 @@ def _is_generated_path(path: str) -> bool:
or ".generated." in base
or base.endswith(".min.js")
# Barrel / package-init re-export files: nothing of substance to split.
- or base in ("__init__.py", "index.ts", "index.js", "mod.rs")
+ or base in BARREL_FILENAMES
)
diff --git a/tests/unit/test_no_barrel_filename_copies.py b/tests/unit/test_no_barrel_filename_copies.py
new file mode 100644
index 000000000..748fe2c14
--- /dev/null
+++ b/tests/unit/test_no_barrel_filename_copies.py
@@ -0,0 +1,114 @@
+from __future__ import annotations
+
+import ast
+import pathlib
+
+import pytest
+
+from repowise.core.analysis.health.refactoring.split_file import _is_generated_path
+
+_KNOWN: frozenset[str] = frozenset(
+ {
+ "packages/core/src/repowise/core/entry_candidacy.py",
+ "packages/core/src/repowise/core/ingestion/tsconfig_resolver.py",
+ "packages/server/src/repowise/server/services/c4_builder/architecture.py",
+ }
+)
+
+_PACKAGES = pathlib.Path(__file__).resolve().parents[2] / "packages"
+_HOME = "packages/core/src/repowise/core/analysis/dead_code/file_reachability.py"
+_BARREL_MARKERS = {
+ "index.ts",
+ "index.tsx",
+ "index.js",
+ "index.jsx",
+ "index.mts",
+ "index.cts",
+ "index.mjs",
+ "index.cjs",
+ "__init__.py",
+ "mod.rs",
+}
+
+
+def _check_assignment(node: ast.AST) -> list[str]:
+ if (
+ isinstance(node, ast.Assign)
+ and any(
+ isinstance(target, ast.Name) and target.id == "BARREL_FILENAMES" for target in node.targets
+ )
+ ) or (
+ isinstance(node, ast.AnnAssign)
+ and isinstance(node.target, ast.Name)
+ and node.target.id == "BARREL_FILENAMES"
+ ):
+ return ["BARREL_FILENAMES"]
+ return []
+
+
+def _check_literals(node: ast.AST) -> list[str]:
+ if not isinstance(node, ast.Tuple | ast.Set | ast.List):
+ return []
+ str_elts = {
+ elt.value
+ for elt in node.elts
+ if isinstance(elt, ast.Constant) and isinstance(elt.value, str)
+ }
+ matched = str_elts & _BARREL_MARKERS
+ if len(matched) >= 2:
+ return [f"literal {sorted(matched)}"]
+ return []
+
+
+def _analyze_file(path: pathlib.Path) -> list[str]:
+ try:
+ tree = ast.parse(path.read_text(encoding="utf-8"))
+ except (SyntaxError, UnicodeDecodeError):
+ return []
+
+ hits: list[str] = []
+ for node in ast.walk(tree):
+ hits.extend(_check_assignment(node))
+ hits.extend(_check_literals(node))
+ return sorted(set(hits))
+
+
+def _offenders() -> dict[str, list[str]]:
+ found: dict[str, list[str]] = {}
+ for path in _PACKAGES.rglob("*.py"):
+ rel = path.relative_to(_PACKAGES.parents[0]).as_posix()
+ if rel == _HOME:
+ continue
+ hits = _analyze_file(path)
+ if hits:
+ found[rel] = hits
+ return found
+
+
+def test_no_new_barrel_filename_copies() -> None:
+ offenders = {p: hits for p, hits in _offenders().items() if p not in _KNOWN}
+ assert not offenders, (
+ "New inline barrel-filename definition(s) outside file_reachability.py:\n"
+ + "\n".join(f" {p}: {', '.join(hits)}" for p, hits in sorted(offenders.items()))
+ )
+
+
+ "path, expected",
+ [
+ ("src/index.ts", True),
+ ("src/index.tsx", True),
+ ("src/index.js", True),
+ ("src/index.jsx", True),
+ ("src/index.mts", True),
+ ("src/index.cts", True),
+ ("src/index.mjs", True),
+ ("src/index.cjs", True),
+ ("pkg/__init__.py", True),
+ ("src/mod.rs", True),
+ ("src/utils.ts", False),
+ ("src/component.tsx", False),
+ ],
+)
+def test_split_file_is_generated_path_covers_all_barrels(path: str, expected: bool) -> None:
+ assert _is_generated_path(path) is expected