Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

refactor(generation): shrink the frozen evidence-files mapping (#1250)

Sergei Iakhnitskii23174eaa044b
diff --git a/packages/core/src/repowise/core/generation/models.py b/packages/core/src/repowise/core/generation/models.py
index 8624d39cd..8a112450e 100644
--- a/packages/core/src/repowise/core/generation/models.py
+++ b/packages/core/src/repowise/core/generation/models.py
@@ -14,6 +14,7 @@ from collections.abc import Iterable, Iterator, Mapping
from copy import deepcopy
from dataclasses import dataclass, field, fields
from datetime import UTC, datetime
+from types import MappingProxyType
from typing import Any, Literal
from repowise.core.reasoning import ReasoningMode, normalize_reasoning
@@ -68,28 +69,33 @@ def _source_evidence_page_keys() -> set[str]:
class _FrozenEvidenceFiles(Mapping[str, tuple[str, ...]]):
- """Small immutable mapping that preserves the frozen config contract."""
-
- __slots__ = ("_items",)
+ """Small immutable mapping that preserves the frozen config contract.
+
+ The config is ``frozen=True`` and hash-tested, so the stored value must be
+ hashable and read-only. Backed by a ``MappingProxyType`` over a plain dict:
+ O(1) lookup and no in-place mutation, still hashable because ``__hash__``
+ runs over ``frozenset(items())`` rather than the proxy. The ``__setattr__``
+ guard blocks rebinding ``_items``. ``__reduce__`` stays because a
+ ``mappingproxy`` is not picklable on its own; it rebuilds from a plain dict,
+ which also serves ``copy``/``deepcopy``. ``__slots__`` and the explicit
+ ``__copy__``/``__deepcopy__`` are gone — ``__reduce__`` covers all three.
+ """
def __init__(self, values: Mapping[str, tuple[str, ...]] | None = None) -> None:
object.__setattr__(
self,
"_items",
- tuple((key, tuple(paths)) for key, paths in (values or {}).items()),
+ MappingProxyType({key: tuple(paths) for key, paths in (values or {}).items()}),
)
def __setattr__(self, name: str, value: object) -> None:
raise TypeError("source_evidence_files is immutable")
def __getitem__(self, key: str) -> tuple[str, ...]:
- for candidate, paths in self._items:
- if candidate == key:
- return paths
- raise KeyError(key)
+ return self._items[key]
def __iter__(self) -> Iterator[str]:
- return (key for key, _ in self._items)
+ return iter(self._items)
def __len__(self) -> int:
return len(self._items)
@@ -102,13 +108,6 @@ class _FrozenEvidenceFiles(Mapping[str, tuple[str, ...]]):
def __hash__(self) -> int:
return hash(frozenset(self.items()))
- def __copy__(self) -> _FrozenEvidenceFiles:
- return self
-
- def __deepcopy__(self, memo: dict[int, object]) -> _FrozenEvidenceFiles:
- memo[id(self)] = self
- return self
-
def __reduce__(self) -> tuple[type[_FrozenEvidenceFiles], tuple[dict[str, tuple[str, ...]]]]:
return type(self), (dict(self),)
diff --git a/tests/unit/generation/test_models.py b/tests/unit/generation/test_models.py
index b450b5479..3247e8d94 100644
--- a/tests/unit/generation/test_models.py
+++ b/tests/unit/generation/test_models.py
@@ -184,6 +184,10 @@ def test_generation_config_remains_hashable_and_evidence_mapping_is_immutable():
dict.__setitem__(config.source_evidence_files, "repo_overview", ("other.md",)) # type: ignore[arg-type]
with pytest.raises((AttributeError, TypeError)):
config.source_evidence_files._items = () # type: ignore[attr-defined]
+ # The backing store itself is read-only, so a reachable private handle
+ # cannot mutate it in place and corrupt the cached hash.
+ with pytest.raises(TypeError):
+ config.source_evidence_files._items["repo_overview"] = ("other.md",) # type: ignore[index]
reordered = GenerationConfig(
source_evidence_files={