Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

fix(server): fail job explicitly on unknown execution mode (#881) (#911)

Akshat malik23b6e463c834
diff --git a/packages/server/src/repowise/server/job_executor.py b/packages/server/src/repowise/server/job_executor.py
index 088088c09..5cf5ac51a 100644
--- a/packages/server/src/repowise/server/job_executor.py
+++ b/packages/server/src/repowise/server/job_executor.py
@@ -108,6 +108,19 @@ def _repo_wiki_style(repo: Any, repo_path: str) -> str:
return resolve_style(style, repo_path=repo_path).name
+# Valid job execution modes handled by execute_job.
+# NOTE: "generate" (HTTP repowise generate) and "single_page" (scoped page resync)
+# are dispatched to _run_generate_job below, so validation must accept them upfront.
+VALID_JOB_MODES: set[str] = {
+ "sync",
+ "full_resync",
+ "initial_index",
+ "index_only",
+ "generate",
+ "single_page",
+}
+
+
# Phase → numeric level mapping for job.current_level
_PHASE_LEVELS = {
"traverse": 0,
@@ -342,7 +355,13 @@ async def execute_job(
# Resolve the wiki style while ``repo`` is still session-attached.
wiki_style = _repo_wiki_style(repo, repo_path)
config = json.loads(job.config_json) if job.config_json else {}
- mode = config.get("mode") or "sync"
+ mode = str(config.get("mode") or "sync")
+ if mode not in VALID_JOB_MODES:
+ valid_str = ", ".join(sorted(VALID_JOB_MODES))
+ raise ValueError(
+ f"Invalid job mode '{mode}'. Expected one of: {valid_str}"
+ )
+
is_full_resync = mode == "full_resync"
is_initial_index = mode == "initial_index"
is_index_only = mode == "index_only"
diff --git a/tests/unit/server/test_job_executor.py b/tests/unit/server/test_job_executor.py
index 361e77d42..dfd19e111 100644
--- a/tests/unit/server/test_job_executor.py
+++ b/tests/unit/server/test_job_executor.py
@@ -568,3 +568,132 @@ async def test_index_only_job_does_not_generate_docs(session_factory, tmp_path):
assert run_pipeline_mock.await_args.kwargs["generate_docs"] is False
assert run_pipeline_mock.await_args.kwargs["mode"] == OrchestratorMode.STANDARD
+
+
+async def test_execute_job_fails_on_unknown_mode(session_factory, tmp_path):
+ """An unrecognized job mode explicitly fails the job rather than running partial work."""
+ from repowise.core.persistence.crud import get_generation_job
+
+ async with session_factory() as session:
+ repo = await upsert_repository(session, name="test-repo", local_path=str(tmp_path))
+ job = await upsert_generation_job(
+ session,
+ repository_id=repo.id,
+ config={"mode": "incremental"},
+ )
+ await session.commit()
+ job_id = job.id
+
+ app_state = SimpleNamespace(session_factory=session_factory, fts=None, vector_store=None)
+
+ run_pipeline_mock = AsyncMock(return_value=_fake_result())
+ with (
+ patch("repowise.server.job_executor.run_pipeline", run_pipeline_mock),
+ patch("repowise.server.job_executor.persist_pipeline_result", AsyncMock()),
+ ):
+ await execute_job(job_id, app_state)
+
+ # Pipeline should not run when mode is invalid
+ run_pipeline_mock.assert_not_called()
+
+ # Job status should be recorded as failed in the DB with clear error message
+ async with session_factory() as session:
+ updated_job = await get_generation_job(session, job_id)
+ assert updated_job is not None
+ assert updated_job.status == "failed"
+ assert "Invalid job mode 'incremental'" in (updated_job.error_message or "")
+
+
+async def test_execute_job_defaults_to_sync_when_mode_absent(session_factory, tmp_path):
+ """A missing mode key (config={}) defaults to 'sync' and proceeds without failing."""
+ async with session_factory() as session:
+ repo = await upsert_repository(session, name="test-repo", local_path=str(tmp_path))
+ job = await upsert_generation_job(
+ session,
+ repository_id=repo.id,
+ config={},
+ )
+ await session.commit()
+ job_id = job.id
+
+ app_state = SimpleNamespace(session_factory=session_factory, fts=None, vector_store=None)
+
+ run_pipeline_mock = AsyncMock(return_value=_fake_result())
+ get_provider_mock = MagicMock(side_effect=RuntimeError("no provider"))
+ with (
+ patch("repowise.server.job_executor.run_pipeline", run_pipeline_mock),
+ patch("repowise.server.job_executor.persist_pipeline_result", AsyncMock()),
+ patch(
+ "repowise.server.provider_config.get_chat_provider_instance",
+ get_provider_mock,
+ ),
+ ):
+ await execute_job(job_id, app_state)
+
+ # Pipeline must have run
+ run_pipeline_mock.assert_awaited_once()
+ # Provider lookup was attempted — proves fallback is "sync", not "index_only"
+ get_provider_mock.assert_called_once()
+
+
+async def test_execute_job_defaults_to_sync_when_mode_empty_string(session_factory, tmp_path):
+ """An explicit empty-string mode also defaults to 'sync' via the `or` fallback."""
+ async with session_factory() as session:
+ repo = await upsert_repository(session, name="test-repo", local_path=str(tmp_path))
+ job = await upsert_generation_job(
+ session,
+ repository_id=repo.id,
+ config={"mode": ""},
+ )
+ await session.commit()
+ job_id = job.id
+
+ app_state = SimpleNamespace(session_factory=session_factory, fts=None, vector_store=None)
+
+ run_pipeline_mock = AsyncMock(return_value=_fake_result())
+ get_provider_mock = MagicMock(side_effect=RuntimeError("no provider"))
+ with (
+ patch("repowise.server.job_executor.run_pipeline", run_pipeline_mock),
+ patch("repowise.server.job_executor.persist_pipeline_result", AsyncMock()),
+ patch(
+ "repowise.server.provider_config.get_chat_provider_instance",
+ get_provider_mock,
+ ),
+ ):
+ await execute_job(job_id, app_state)
+
+ # Pipeline must have run
+ run_pipeline_mock.assert_awaited_once()
+ get_provider_mock.assert_called_once()
+
+
+async def test_execute_job_dispatches_generate_mode(session_factory, tmp_path):
+ """A job with mode='generate' passes validation and dispatches to _run_generate_job."""
+ async with session_factory() as session:
+ repo = await upsert_repository(session, name="test-repo", local_path=str(tmp_path))
+ job = await upsert_generation_job(
+ session,
+ repository_id=repo.id,
+ config={"mode": "generate"},
+ )
+ await session.commit()
+ job_id = job.id
+
+ app_state = SimpleNamespace(session_factory=session_factory, fts=None, vector_store=None)
+
+ run_generate_mock = AsyncMock()
+ with (
+ patch("repowise.server.job_executor._run_generate_job", run_generate_mock),
+ patch(
+ "repowise.server.provider_config.get_chat_provider_instance",
+ MagicMock(return_value=MagicMock()),
+ ),
+ ):
+ await execute_job(job_id, app_state)
+
+ run_generate_mock.assert_awaited_once()
+