Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(mcp): name unknown get_overview include values in ignored_arguments (#3916)
Raghav Chamadiya2a8c03fe99c1
diff --git a/docs/reference/MCP_RESPONSE_FIELDS.md b/docs/reference/MCP_RESPONSE_FIELDS.mdindex 626b91bb5..3805e5a0e 100644--- a/docs/reference/MCP_RESPONSE_FIELDS.md+++ b/docs/reference/MCP_RESPONSE_FIELDS.md@@ -99,7 +99,7 @@ The key is absent when every argument was understood. One entry per argument.| `get_dead_code` | `kind`, `tier`, `min_confidence` | Top-level list, as above || `get_context` | `include` | Top-level list || `search_codebase` | `kind`, `mode` (an unknown `mode` runs as `auto`), `pattern` when `query` is also given (entry carries `"superseded_by": "query"`) | Top-level list |-| `get_risk`, `get_change_risk` | `include` | Top-level list |+| `get_risk`, `get_change_risk`, `get_overview` | `include` | Top-level list || `get_answer` | `include` | `_meta.ignored_arguments`, a map: `{"include": [...]}` || `get_health` | `refactoring_*` and `performance_*` filters, `scope`, `counts` | Top-level flat map of argument to dropped value, e.g. `{"counts": "code-shape"}` |diff --git a/packages/server/src/repowise/server/mcp_server/tool_overview/tool.py b/packages/server/src/repowise/server/mcp_server/tool_overview/tool.pyindex 43705a3d4..a7446ff75 100644--- a/packages/server/src/repowise/server/mcp_server/tool_overview/tool.py+++ b/packages/server/src/repowise/server/mcp_server/tool_overview/tool.py@@ -22,7 +22,9 @@ from repowise.server.mcp_server._helpers import (_get_exclude_spec,_get_repo,_resolve_repo_context,+ attach_ignored_arguments,filter_rows_by_attr,+ resolve_enum_argument,)from repowise.server.mcp_server._meta import (build_meta_with_full_scope as _build_meta_with_full_scope,@@ -59,6 +61,11 @@ from repowise.server.mcp_server.tool_overview.workspace import (_workspace_overview,)+#: The ``include`` values get_overview serves; anything else is named, not applied.+_INCLUDE_BLOCKS = frozenset(+ {"content", "outline", "tour", "decisions", "graph", "ownership", "components", "changes"}+)+@mcp.tool(surface_order=80, artifact_type="overview", presentation="overview")async def get_overview(repo: str | None = None, include: list[str] | None = None) -> dict:@@ -104,7 +111,12 @@ async def get_overview(repo: str | None = None, include: list[str] | None = Nonecollector = OmissionCollector("get_overview", repo_root=ctx.path)async with get_session(ctx.session_factory) as session:repository = await _get_repo(session)- want = set(include or [])+ ignored: list[dict[str, Any]] = []+ want = {+ k+ for k in include or []+ if resolve_enum_argument(k, _INCLUDE_BLOCKS, argument="include", ignored=ignored)+ }result = await _repo_overview(session, ctx.session_factory, repository, exclude_spec, want, collector)@@ -124,6 +136,7 @@ async def get_overview(repo: str | None = None, include: list[str] | None = None# other response's compact projection points at is worth its bytes.result["_meta"] = _build_meta_with_full_scope(repository=repository)collector.attach(result)+ attach_ignored_arguments(result, ignored)return resultdiff --git a/tests/unit/server/mcp/test_overview.py b/tests/unit/server/mcp/test_overview.pyindex 71b030dd2..4c6abf96e 100644--- a/tests/unit/server/mcp/test_overview.py+++ b/tests/unit/server/mcp/test_overview.py@@ -100,3 +100,15 @@ async def test_include_flag_restores_its_block(setup_mcp, flag, key):from repowise.server.mcp_server import get_overviewassert key in await get_overview(include=[flag])+++async def test_an_unknown_include_value_is_named_not_silently_dropped(setup_mcp):+ from repowise.server.mcp_server import get_overview++ result = await get_overview(include=["tour", "outlines"])+ assert "reading_order" in result+ [entry] = result["ignored_arguments"]+ assert entry["argument"] == "include" and entry["values"] == ["outlines"]+ assert "outline" in entry["valid"]+ assert "ignored_arguments" not in await get_overview(include=["tour"])