Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

fix(ui): read the tiered get_dead_code shape in the chat card (#2729)

Raghav Chamadiya2d12987c82cc
diff --git a/packages/types/__tests__/contracts.test.ts b/packages/types/__tests__/contracts.test.ts
index 3cbaa4186..3c5ed58ba 100644
--- a/packages/types/__tests__/contracts.test.ts
+++ b/packages/types/__tests__/contracts.test.ts
@@ -63,7 +63,9 @@ describe("ChatArtifact discriminated union", () => {
expectTypeOf(a.data.distance).toEqualTypeOf<number>();
} else if (a.type === "dead_code") {
expectTypeOf(a).toEqualTypeOf<DeadCodeArtifact>();
- expectTypeOf(a.data.total_findings).toEqualTypeOf<number>();
+ if (a.data.mode !== "finding") {
+ expectTypeOf(a.data.summary.total_findings).toEqualTypeOf<number>();
+ }
} else if (a.type === "diagram") {
expectTypeOf(a).toEqualTypeOf<DiagramArtifact>();
expectTypeOf(a.data.mermaid_syntax).toEqualTypeOf<string>();
diff --git a/packages/types/src/chat.ts b/packages/types/src/chat.ts
index 0f5b38389..37d03dbc0 100644
--- a/packages/types/src/chat.ts
+++ b/packages/types/src/chat.ts
@@ -488,27 +488,46 @@ export interface DecisionsArtifact extends ArtifactEnvelopeIdentity {
data: DecisionsArtifactData;
}
-/** `get_dead_code` — confidence-tiered dead-code findings. */
-export interface DeadCodeArtifactData {
- total_findings: number;
- deletable_lines: number;
- high_confidence: Array<{
- file_path: string;
- symbol_name?: string | null;
- kind: string;
- confidence: number;
- reason: string;
- lines: number | null;
- safe_to_delete: boolean;
- }>;
- medium_confidence: Array<{
- file_path: string;
- symbol_name?: string | null;
- kind: string;
- confidence: number;
- reason: string;
- }>;
+/** One finding inside a `get_dead_code` tier. */
+export interface DeadCodeArtifactFinding {
+ file_path: string;
+ symbol_name?: string | null;
+ kind: string;
+ confidence: number;
+ reason: string;
+ lines: number | null;
+ safe_to_delete: boolean;
+}
+
+/** One confidence tier of a `get_dead_code` result. */
+export interface DeadCodeArtifactTier {
+ count: number;
+ findings: DeadCodeArtifactFinding[];
+ truncated: boolean;
+}
+
+/**
+ * `get_dead_code`: confidence-tiered dead-code findings. Totals sit in
+ * `summary`; a `tier` argument drops the tiers it did not ask for.
+ */
+export interface DeadCodeArtifactTiers {
+ mode?: undefined;
+ summary: {
+ total_findings: number;
+ deletable_lines: number;
+ };
+ tiers: Partial<Record<"high" | "medium" | "low", DeadCodeArtifactTier>>;
}
+
+/** `get_dead_code(finding_id=...)`: one finding, or none when the id is unknown. */
+export interface DeadCodeArtifactLookup {
+ mode: "finding";
+ finding_id: string;
+ finding: DeadCodeArtifactFinding | null;
+ resolved: boolean;
+}
+
+export type DeadCodeArtifactData = DeadCodeArtifactTiers | DeadCodeArtifactLookup;
export interface DeadCodeArtifact extends ArtifactEnvelopeIdentity {
type: "dead_code";
data: DeadCodeArtifactData;
diff --git a/packages/ui/__tests__/chat/artifacts.test.tsx b/packages/ui/__tests__/chat/artifacts.test.tsx
index 5ae80dfff..022e785b9 100644
--- a/packages/ui/__tests__/chat/artifacts.test.tsx
+++ b/packages/ui/__tests__/chat/artifacts.test.tsx
@@ -269,31 +269,45 @@ describe("chat artifact renderers", () => {
).toBeInTheDocument();
});
- it("DeadCodeRenderer separates high and medium confidence", () => {
+ it("DeadCodeRenderer reads the tiered get_dead_code shape", () => {
+ // The wire shape of get_dead_code: totals under `summary`, findings
+ // grouped by confidence under `tiers`.
render(
<DeadCodeRenderer
data={{
- total_findings: 3,
- deletable_lines: 88,
- high_confidence: [
- {
- file_path: "src/legacy.ts",
- symbol_name: "oldFn",
- kind: "unused_export",
- confidence: 0.95,
- reason: "No callers found.",
- lines: 30,
- safe_to_delete: true,
+ summary: { total_findings: 3, deletable_lines: 88 },
+ tiers: {
+ high: {
+ count: 1,
+ truncated: false,
+ findings: [
+ {
+ file_path: "src/legacy.ts",
+ symbol_name: "oldFn",
+ kind: "unused_export",
+ confidence: 0.95,
+ reason: "No callers found.",
+ lines: 30,
+ safe_to_delete: true,
+ },
+ ],
},
- ],
- medium_confidence: [
- {
- file_path: "src/maybe.ts",
- kind: "unreachable_file",
- confidence: 0.6,
- reason: "Possibly imported via dynamic require.",
+ medium: {
+ count: 4,
+ truncated: true,
+ findings: [
+ {
+ file_path: "src/maybe.ts",
+ kind: "unreachable_file",
+ confidence: 0.6,
+ reason: "Possibly imported via dynamic require.",
+ lines: null,
+ safe_to_delete: false,
+ },
+ ],
},
- ],
+ low: { count: 0, truncated: false, findings: [] },
+ },
}}
/>,
);
@@ -302,6 +316,69 @@ describe("chat artifact renderers", () => {
expect(screen.getByText(/src\/legacy\.ts::oldFn/)).toBeInTheDocument();
expect(screen.getByText("src/maybe.ts")).toBeInTheDocument();
expect(screen.getByText("95%")).toBeInTheDocument();
+ expect(screen.getByText("1 of 4 shown")).toBeInTheDocument();
+ expect(screen.queryByText("Low confidence")).not.toBeInTheDocument();
+ });
+
+ it("DeadCodeRenderer shows the one finding a finding_id lookup returns", () => {
+ render(
+ <DeadCodeRenderer
+ data={{
+ mode: "finding",
+ finding_id: "dc_1",
+ resolved: true,
+ finding: {
+ file_path: "src/legacy.ts",
+ symbol_name: "oldFn",
+ kind: "unused_export",
+ confidence: 0.95,
+ reason: "No callers found.",
+ lines: 30,
+ safe_to_delete: true,
+ },
+ }}
+ />,
+ );
+ expect(screen.getByText(/src\/legacy\.ts::oldFn/)).toBeInTheDocument();
+ expect(screen.getByText(/30 lines/)).toBeInTheDocument();
+ });
+
+ it("DeadCodeRenderer names an id the lookup did not resolve", () => {
+ render(
+ <DeadCodeRenderer
+ data={{ mode: "finding", finding_id: "dc_gone", resolved: false, finding: null }}
+ />,
+ );
+ expect(screen.getByText("dc_gone")).toBeInTheDocument();
+ });
+
+ it("DeadCodeRenderer renders only the tier a tier-filtered call returned", () => {
+ render(
+ <DeadCodeRenderer
+ data={{
+ summary: { total_findings: 2, deletable_lines: 0 },
+ tiers: {
+ low: {
+ count: 1,
+ truncated: false,
+ findings: [
+ {
+ file_path: "src/dynamic.py",
+ kind: "unused_export",
+ confidence: 0.3,
+ reason: "Only reached through a string lookup.",
+ lines: 12,
+ safe_to_delete: false,
+ },
+ ],
+ },
+ },
+ }}
+ />,
+ );
+ expect(screen.getByText("Low confidence")).toBeInTheDocument();
+ expect(screen.getByText("src/dynamic.py")).toBeInTheDocument();
+ expect(screen.queryByText("High confidence")).not.toBeInTheDocument();
});
it("DiagramRenderer falls back gracefully when no syntax", () => {
diff --git a/packages/ui/__tests__/chat/source-citations.test.tsx b/packages/ui/__tests__/chat/source-citations.test.tsx
index 020e47dde..8cc58e0fd 100644
--- a/packages/ui/__tests__/chat/source-citations.test.tsx
+++ b/packages/ui/__tests__/chat/source-citations.test.tsx
@@ -41,7 +41,7 @@ describe("extractSources", () => {
id: "d1",
name: "get_dead_code",
arguments: {},
- result: { high_confidence: [{ file_path: "packages/web/unused.ts" }] },
+ result: { tiers: { high: { findings: [{ file_path: "packages/web/unused.ts" }] } } },
status: "done",
},
{
diff --git a/packages/ui/src/chat/artifacts.tsx b/packages/ui/src/chat/artifacts.tsx
index 6586b3349..8a257c77d 100644
--- a/packages/ui/src/chat/artifacts.tsx
+++ b/packages/ui/src/chat/artifacts.tsx
@@ -25,6 +25,7 @@ import type {
ChangeFindingRow,
ContextArtifactData,
DeadCodeArtifactData,
+ DeadCodeArtifactFinding,
DecisionsArtifactData,
DiagramArtifactData,
GraphPathArtifactData,
@@ -887,41 +888,55 @@ export function DecisionsRenderer({ data }: { data: DecisionsArtifactData }) {
// Dead code
// ---------------------------------------------------------------------------
+const DEAD_CODE_TIERS = [
+ { key: "high", label: "High confidence", icon: CheckCircle2 },
+ { key: "medium", label: "Medium confidence", icon: AlertTriangle },
+ { key: "low", label: "Low confidence", icon: AlertTriangle },
+] as const;
+
export function DeadCodeRenderer({ data }: { data: DeadCodeArtifactData }) {
+ if (data.mode === "finding") {
+ return data.finding ? (
+ <DeadCodeRow finding={data.finding} showLines />
+ ) : (
+ <p className="text-xs text-[var(--color-text-tertiary)]">
+ No open dead-code finding matches{" "}
+ <span className="break-all font-mono">{data.finding_id}</span>.
+ </p>
+ );
+ }
return (
<div className="space-y-4">
<div className="grid grid-cols-2 gap-2">
<StatRow
label="Findings"
- value={data.total_findings.toLocaleString()}
+ value={data.summary.total_findings.toLocaleString()}
/>
<StatRow
label="Candidate lines"
- value={data.deletable_lines.toLocaleString()}
+ value={data.summary.deletable_lines.toLocaleString()}
/>
</div>
- {data.high_confidence.length > 0 && (
- <div>
- <SectionTitle icon={CheckCircle2}>High confidence</SectionTitle>
- <div className="space-y-1.5">
- {data.high_confidence.map((f, i) => (
- <DeadCodeRow key={`${f.file_path}:${i}`} finding={f} showLines />
- ))}
- </div>
- </div>
- )}
-
- {data.medium_confidence.length > 0 && (
- <div>
- <SectionTitle icon={AlertTriangle}>Medium confidence</SectionTitle>
- <div className="space-y-1.5">
- {data.medium_confidence.map((f, i) => (
- <DeadCodeRow key={`${f.file_path}:${i}`} finding={f} />
- ))}
+ {DEAD_CODE_TIERS.map(({ key, label, icon }) => {
+ const tier = data.tiers?.[key];
+ if (!tier || tier.findings.length === 0) return null;
+ return (
+ <div key={key}>
+ <SectionTitle icon={icon}>{label}</SectionTitle>
+ <div className="space-y-1.5">
+ {tier.findings.map((f, i) => (
+ <DeadCodeRow key={`${f.file_path}:${i}`} finding={f} showLines={key === "high"} />
+ ))}
+ </div>
+ {tier.truncated && (
+ <p className="mt-1.5 text-[10px] text-[var(--color-text-tertiary)]">
+ {tier.findings.length} of {tier.count.toLocaleString()} shown
+ </p>
+ )}
</div>
- </div>
- )}
+ );
+ })}
</div>
);
}
@@ -930,15 +945,7 @@ function DeadCodeRow({
finding,
showLines = false,
}: {
- finding: {
- file_path: string;
- symbol_name?: string | null;
- kind: string;
- confidence: number;
- reason: string;
- lines?: number | null;
- safe_to_delete?: boolean;
- };
+ finding: DeadCodeArtifactFinding;
showLines?: boolean;
}) {
return (
diff --git a/packages/ui/src/chat/source-citations.tsx b/packages/ui/src/chat/source-citations.tsx
index b1d0a603b..3757afb40 100644
--- a/packages/ui/src/chat/source-citations.tsx
+++ b/packages/ui/src/chat/source-citations.tsx
@@ -143,9 +143,12 @@ export function extractSources(
}
if (tc.name === "get_dead_code") {
+ const tiers = (result.tiers as Record<string, { findings?: Array<Record<string, unknown>> }>) ?? {};
+ const lookup = result.finding as Record<string, unknown> | null | undefined;
const rows = [
- ...((result.high_confidence as Array<Record<string, unknown>>) ?? []),
- ...((result.medium_confidence as Array<Record<string, unknown>>) ?? []),
+ ...(lookup ? [lookup] : []),
+ ...(tiers.high?.findings ?? []),
+ ...(tiers.medium?.findings ?? []),
];
for (const r of rows.slice(0, 10)) pushFile(tc.id, tc.name, r.file_path);
}