Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(security): drop empty public_env_secret assignments (#4037)
Pasit Nusso3e74f4fe1225
diff --git a/packages/core/src/repowise/core/analysis/security/credentials.py b/packages/core/src/repowise/core/analysis/security/credentials.pyindex c5a9f7bc3..308121e69 100644--- a/packages/core/src/repowise/core/analysis/security/credentials.py+++ b/packages/core/src/repowise/core/analysis/security/credentials.py@@ -146,6 +146,11 @@ def _redaction(val: str) -> str:# (``=``, ``:``, ``=>``, ``??``, ``||``) or plain whitespace (a Dockerfile# ``ENV NAME value``), then the value, quoted or not._PUBLIC_VALUE = re.compile(r"""\A['"\]]*(?:\s*[:=>?|]+\s*|\s+)(['"`]?)(?=[^\s;,)])""")+# Blank template lines (``VITE_API_TOKEN=``, ``NEXT_PUBLIC_KEY=""``, or with+# trailing comment) in .env or config files carry no secret.+_PUBLIC_EMPTY_ASSIGNMENT = re.compile(+ r"""\A['"\]]*\s*(?:=(?!=)|:=|:|=>)\s*(?:""|'')?\s*(?:[,;])?\s*(?:#.*)?\Z"""+)_SECRET_PATTERNS = [(p, kind) for p, kind, _ in _PATTERNS if kind in SECRET_KINDS]_PUBLIC_ENV_PATTERN = next(p for p, kind, _ in _PATTERNS if kind == "public_env_secret")@@ -201,9 +206,15 @@ def _public_env_value(line: str, name_end: int) -> tuple[int, int] | None:return Nonestart = name_end + value.end()if value.group(1):- return start, _string_end(line, start)+ end = _string_end(line, start)+ return (start, end) if end > start else Nonestop = next((i for i in range(start, len(line)) if line[i].isspace()), len(line))- return start, stop+ return (start, stop) if stop > start else None+++def _is_empty_public_env_assignment(line: str, name_end: int) -> bool:+ """Whether the public env name ending at *name_end* is followed by an empty assignment."""+ return _PUBLIC_EMPTY_ASSIGNMENT.search(line[name_end:]) is not Nonedef _secret_spans(line: str) -> list[tuple[int, int]]:diff --git a/packages/core/src/repowise/core/analysis/security/scanner.py b/packages/core/src/repowise/core/analysis/security/scanner.pyindex 5f5bf3e3f..085f73879 100644--- a/packages/core/src/repowise/core/analysis/security/scanner.py+++ b/packages/core/src/repowise/core/analysis/security/scanner.py@@ -14,6 +14,7 @@ from .credentials import (_PEM_BODY_LINE,_PEM_HEADER_LINE,_assignment_name,+ _is_empty_public_env_assignment,_is_secret_value,_redaction,_snippet,@@ -124,6 +125,8 @@ def scan_source(file_path: str, source: str, symbols: Iterable[Any] = ()) -> lis# alone: the name is often quoted (``ENV["NEXT_PUBLIC_KEY"]``).uncommented = masked_line(lineno, line, strings=False)match = _match_starting_in(pattern, line, uncommented)+ if match and _is_empty_public_env_assignment(line, match.end()):+ match = Noneelse:# Vendor key shapes are real wherever they sit, comments included.match = pattern.search(line)diff --git a/packages/core/src/repowise/core/analysis/security_scan.py b/packages/core/src/repowise/core/analysis/security_scan.pyindex 7d2cd2464..e39f70094 100644--- a/packages/core/src/repowise/core/analysis/security_scan.py+++ b/packages/core/src/repowise/core/analysis/security_scan.py@@ -50,6 +50,7 @@ from repowise.core.analysis.security.credentials import (_PEM_BODY_LINE,_PEM_HEADER_LINE,_PEM_INLINE_BODY,+ _PUBLIC_EMPTY_ASSIGNMENT,_PUBLIC_ENV_PATTERN,_PUBLIC_VALUE,_SCHEME_TEMPLATE_VALUE,@@ -59,6 +60,7 @@ from repowise.core.analysis.security.credentials import (_TEMPLATE_VALUE,_UPPER_KEY_NAME_VALUE,_assignment_name,+ _is_empty_public_env_assignment,_is_own_name_value,_is_plain_word,_is_secret_value,diff --git a/tests/unit/analysis/golden/security_scan_corpus.json b/tests/unit/analysis/golden/security_scan_corpus.jsonindex c996f81b6..07fbbe9ea 100644--- a/tests/unit/analysis/golden/security_scan_corpus.json+++ b/tests/unit/analysis/golden/security_scan_corpus.json@@ -469,12 +469,6 @@"severity": "high","snippet": "NEXT_PUBLIC_STRIPE_SECRET=sk_l****","line": 1- },- {- "kind": "public_env_secret",- "severity": "high",- "snippet": "VITE_API_TOKEN=",- "line": 2}]},diff --git a/tests/unit/analysis/test_security_scan.py b/tests/unit/analysis/test_security_scan.pyindex fa7b29827..acaddea51 100644--- a/tests/unit/analysis/test_security_scan.py+++ b/tests/unit/analysis/test_security_scan.py@@ -995,6 +995,32 @@ class TestScanSource:(hit,) = [f for f in scan_source("config.ts", source) if f["kind"] == "public_env_secret"]assert hit["snippet"] == source.strip()+ @pytest.mark.parametrize(+ "source",+ [+ "VITE_API_TOKEN=\n",+ 'NEXT_PUBLIC_API_SECRET=""\n',+ "VITE_AUTH_TOKEN=''\n",+ "VITE_API_TOKEN= # set in .env.local\n",+ ],+ )+ def test_empty_public_env_secret_is_dropped(self, source: str) -> None:+ assert [f for f in scan_source(".env", source) if f["kind"] == "public_env_secret"] == []++ def test_public_env_secret_with_value_still_fires(self) -> None:+ hits = [f for f in scan_source(".env", "VITE_API_TOKEN=abc123\n") if f["kind"] == "public_env_secret"]+ assert len(hits) == 1+ assert hits[0]["snippet"] == "VITE_API_TOKEN=abc1****"++ def test_public_env_secret_code_read_still_fires(self) -> None:+ hits = [+ f+ for f in scan_source("app.ts", "const t = import.meta.env.VITE_API_TOKEN;\n")+ if f["kind"] == "public_env_secret"+ ]+ assert len(hits) == 1+ assert hits[0]["snippet"] == "const t = import.meta.env.VITE_API_TOKEN;"+def test_secret_kinds_and_history_gate_are_unchanged(self) -> None:from repowise.core.analysis.history_scan import HistorySecurityScannerfrom repowise.core.analysis.security_scan import SECRET_KINDS