Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

fix(update): ask one embedder helper instead of spelling provider names in upgrade_flow (#4268)

Aman456d97944297
diff --git a/packages/cli/src/repowise/cli/commands/upgrade_flow.py b/packages/cli/src/repowise/cli/commands/upgrade_flow.py
index 1e025a9b5..bdfe628c2 100644
--- a/packages/cli/src/repowise/cli/commands/upgrade_flow.py
+++ b/packages/cli/src/repowise/cli/commands/upgrade_flow.py
@@ -57,6 +57,7 @@ from repowise.cli.helpers import (
run_async,
save_state,
)
+from repowise.cli.providers import is_free_embedder
from repowise.core.decision_lanes import plan_decision_lanes
from repowise.core.index_scope import FAST_TO_FULL_COMMAND, file_page_scope
from repowise.core.update_lock import release_update_lock, try_acquire_update_lock
@@ -339,10 +340,7 @@ async def _run_upgrade(
# Show the bill before running it, as init does: the user reaching for
# `--full` has never been shown a cost for this repo. Documentation built
# from code with a free embedder has no bill to show.
- free_run = getattr(config, "deterministic", False) and (embedder_name or "mock") in (
- "mock",
- "ollama",
- )
+ free_run = getattr(config, "deterministic", False) and is_free_embedder(embedder_name or "mock")
if not free_run:
_gate_cost(
parsed_files,
diff --git a/packages/cli/src/repowise/cli/providers/__init__.py b/packages/cli/src/repowise/cli/providers/__init__.py
index 2ad0be11d..11f48c451 100644
--- a/packages/cli/src/repowise/cli/providers/__init__.py
+++ b/packages/cli/src/repowise/cli/providers/__init__.py
@@ -16,6 +16,7 @@ from repowise.cli.providers.cost_tracking import (
from repowise.cli.providers.embedders import (
build_embedder,
embedder_was_requested,
+ is_free_embedder,
keyless_run_embedder,
model_run_embedder,
pin_names_an_embedder,
@@ -42,6 +43,7 @@ __all__ = [
"embedder_was_requested",
"existing_vector_dim",
"flush_cost_tracker",
+ "is_free_embedder",
"keyless_run_embedder",
"make_cost_tracker",
"model_run_embedder",
diff --git a/packages/cli/src/repowise/cli/providers/embedders.py b/packages/cli/src/repowise/cli/providers/embedders.py
index fcb8eeb72..1e029df23 100644
--- a/packages/cli/src/repowise/cli/providers/embedders.py
+++ b/packages/cli/src/repowise/cli/providers/embedders.py
@@ -152,6 +152,16 @@ def embedder_was_requested(embedder_flag: str | None, pinned_embedder: Any = Non
)
+def is_free_embedder(name: str) -> bool:
+ """Whether an embedder can never put anything on the bill.
+
+ The keyless mock and the local ollama server cost nothing; every other
+ built-in calls a hosted endpoint. Runs that promise "no spend" ask this
+ instead of spelling the names, so the answer lives in one place.
+ """
+ return name in ("mock", "ollama")
+
+
def template_run_embedder(embedder_name_resolved: str, embedder_was_requested: bool) -> str:
"""The embedder a template-only run actually embeds with.
@@ -163,7 +173,7 @@ def template_run_embedder(embedder_name_resolved: str, embedder_was_requested: b
Shared because ``init`` has to predict this answer before the pipeline, to
build the run's vector store with the backend generation will actually use.
"""
- hosted = embedder_name_resolved not in ("mock", "ollama")
+ hosted = not is_free_embedder(embedder_name_resolved)
return "mock" if hosted and not embedder_was_requested else embedder_name_resolved
diff --git a/tests/unit/cli/test_embedder_resolution.py b/tests/unit/cli/test_embedder_resolution.py
index 1176f62a2..4ceb25290 100644
--- a/tests/unit/cli/test_embedder_resolution.py
+++ b/tests/unit/cli/test_embedder_resolution.py
@@ -974,6 +974,15 @@ def test_template_run_embedder_downgrades_only_an_unasked_hosted_backend(
assert providers.template_run_embedder(resolved, requested) == expected
+ ("name", "free"),
+ [("mock", True), ("ollama", True), ("openai", False), ("gemini", False), ("edenai", False)],
+)
+def test_is_free_embedder_names_only_the_backends_that_cannot_bill(name: str, free: bool) -> None:
+ """``update --full`` skips its cost gate for these, so a hosted one must not slip in."""
+ assert providers.is_free_embedder(name) is free
+
+
# --- the recorded width: the steady state never imports lancedb -------------