Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(decisions): stop a starved token budget silently losing whole batches (#2447)
Raghav Chamadiya5efdcaa045eb
diff --git a/packages/core/src/repowise/core/analysis/decisions/extractor.py b/packages/core/src/repowise/core/analysis/decisions/extractor.pyindex d2a6f981f..0173e279b 100644--- a/packages/core/src/repowise/core/analysis/decisions/extractor.py+++ b/packages/core/src/repowise/core/analysis/decisions/extractor.py@@ -140,6 +140,12 @@ def _coerce_dt(value: datetime | str) -> datetime:# ---------------------------------------------------------------------------+#: The output budget for one batch of either commit prompt. Reasoning tokens+#: are charged to it, so a budget that only fits the answer buys an empty+#: body rather than a short one. Roughly twice the largest completion measured+#: on this repository; see decision ``1c228ed8``.+_BATCH_MAX_TOKENS = 8000+#: How many of a commit's files either commit prompt will show. The model has#: to read the list to pick from it, and a commit that touched ninety files is#: not one whose decisions can be assigned by reading the list anyway.@@ -238,6 +244,15 @@ class DecisionSourceError(RuntimeError):"""+class EmptyModelResponseError(DecisionSourceError):+ """The model returned no body at all for one batch.++ Distinct from ``[]``, which is a real answer and the common one. Raised so+ the batch lands in :func:`_collect_batches` as a failure rather than as a+ source with nothing in it.+ """++def _collect_batches(source: str,results: list[Any],@@ -798,7 +813,7 @@ class DecisionExtractor:prompt = GIT_ARCHAEOLOGY_PROMPT.format(commits_block=commits_block)response = await provider.generate(- _SYSTEM_PROMPT, prompt, max_tokens=2000, temperature=0.2+ _SYSTEM_PROMPT, prompt, max_tokens=_BATCH_MAX_TOKENS, temperature=0.2)extracted = self._parse_decisions_json(response.content)@@ -1075,7 +1090,7 @@ class DecisionExtractor:# requests" — the exact zero-that-means-failure this change exists# to remove.response = await provider.generate(- _SYSTEM_PROMPT, prompt, max_tokens=2500, temperature=0.2+ _SYSTEM_PROMPT, prompt, max_tokens=_BATCH_MAX_TOKENS, temperature=0.2)extracted = self._parse_decisions_json(response.content)for d in extracted:@@ -1698,9 +1713,17 @@ class DecisionExtractor:return tagsdef _parse_decisions_json(self, content: str) -> list[ExtractedDecision]:- """Parse LLM response as JSON array of decisions."""+ """Parse LLM response as JSON array of decisions.++ A blank body raises :class:`EmptyModelResponseError`; every caller+ sits inside a gather or a fallback that counts that as a lost batch.+ """# Extract JSON from response (may be wrapped in markdown code blocks)content = content.strip()+ if not content:+ raise EmptyModelResponseError(+ "the model returned no content for this batch"+ )if content.startswith("```"):# Remove markdown code fenceslines = content.split("\n")diff --git a/tests/unit/analysis/test_decision_batch_budget.py b/tests/unit/analysis/test_decision_batch_budget.pynew file mode 100644index 000000000..9d249c599--- /dev/null+++ b/tests/unit/analysis/test_decision_batch_budget.py@@ -0,0 +1,159 @@+"""An empty model response is a lost batch, not an empty repository.++The defect these pin: a miner whose output budget was too small got an empty+body back, ``_parse_decisions_json`` read that as "no decisions here", and a+lane that had lost every batch reported nothing found. The budget that caused+it and the measurement behind its replacement are recorded in decision+``decision-batch-token-budget``.+"""++from __future__ import annotations++import json+from types import SimpleNamespace++import pytest++from repowise.core.analysis.decisions.extractor import (+ _BATCH_MAX_TOKENS,+ DecisionExtractor,+ DecisionSourceError,+ EmptyModelResponseError,+ _collect_batches,+)++_SHA = "9a0b27a7"+_FILES = [f"packages/core/src/repowise/core/mod{i:02d}.py" for i in range(4)]+++def _meta_map() -> dict[str, dict]:+ commit = {+ "sha": _SHA,+ "message": "perf: resolve CLI command modules lazily",+ "subject": "perf: resolve CLI command modules lazily",+ # Needs a PR-ish marker and a decision signal keyword ("replace"), or+ # the candidate filter drops it before any model call.+ "body": (+ "## Why\n\nImporting all 35 command modules charged the dependency "+ "tree for every invocation. We replace eager imports with lazy "+ "resolution, because the cost was paid even when dispatching one "+ "command."+ ),+ "pr_number": 2441,+ "author": "someone",+ "date": "2026-09-01",+ }+ return {f: {"significant_commits_json": json.dumps([commit])} for f in _FILES}+++class _Provider:+ """Returns whatever content it is given, and records the budget asked for."""++ def __init__(self, content: str) -> None:+ self._content = content+ self.max_tokens: list[int] = []++ async def generate(self, system, prompt, **kwargs):+ self.max_tokens.append(kwargs.get("max_tokens"))+ return SimpleNamespace(content=self._content)+++def _extractor(tmp_path, content: str) -> DecisionExtractor:+ provider = _Provider(content)+ ex = DecisionExtractor(+ repo_path=tmp_path, provider=provider, git_meta_map=_meta_map()+ )+ ex.test_provider = provider+ return ex+++# --- the guard -------------------------------------------------------------+++def test_a_blank_body_raises_rather_than_reading_as_no_decisions(tmp_path):+ ex = _extractor(tmp_path, "")+ with pytest.raises(EmptyModelResponseError):+ ex._parse_decisions_json("")+++def test_whitespace_is_blank_too(tmp_path):+ ex = _extractor(tmp_path, "")+ with pytest.raises(EmptyModelResponseError):+ ex._parse_decisions_json(" \n\t ")+++def test_an_empty_array_is_a_real_answer_and_does_not_raise(tmp_path):+ """The distinction the whole guard rests on.++ ``[]`` is the model saying these commits hold no architectural decision,+ which is correct for most commits. Only a missing body is a failure.+ """+ ex = _extractor(tmp_path, "[]")+ assert ex._parse_decisions_json("[]") == []+++def test_unparseable_content_still_reads_as_nothing_found(tmp_path):+ """Not every parse failure is a lost batch.++ Prose where JSON was asked for is the model declining in its own words,+ and that has always read as nothing found. Widening the guard to cover it+ would turn a working lane into a failing one.+ """+ ex = _extractor(tmp_path, "x")+ assert ex._parse_decisions_json("I could not find any decisions.") == []+++# --- what the miners do with it -------------------------------------------+++async def test_a_lost_batch_fails_the_pr_source_instead_of_returning_zero(tmp_path):+ ex = _extractor(tmp_path, "")+ with pytest.raises(DecisionSourceError):+ await ex.mine_pr_bodies()+++async def test_a_lost_batch_fails_the_archaeology_source_too(tmp_path):+ ex = _extractor(tmp_path, "")+ with pytest.raises(DecisionSourceError):+ await ex.mine_git_archaeology()+++async def test_the_failure_reaches_the_report_as_a_failure(tmp_path):+ """What the user sees: a named failure, not "Nothing found in"."""++ async def _empty() -> list:+ return []++ ex = _extractor(tmp_path, "")+ for name in ("scan_inline_markers", "discover_adrs", "mine_comment_archaeology"):+ setattr(ex, name, _empty)++ report = await ex.extract_all()++ assert "pr" in report.failures+ assert report.by_source["pr"] == 0+ assert "no content" in report.failures["pr"]+++def test_a_partly_lost_source_keeps_what_survived():+ """Some batches empty is degraded, not failed: partial supply beats none."""+ kept = _collect_batches(+ "git_archaeology",+ [["a", "b"], EmptyModelResponseError("no content"), ["c"]],+ )+ assert kept == ["a", "b", "c"]+++# --- the budget ------------------------------------------------------------+++async def test_both_commit_miners_ask_for_the_measured_budget(tmp_path):+ """One constant, so a change cannot raise one lane and starve the other."""+ assert _BATCH_MAX_TOKENS >= 8000++ ex = _extractor(tmp_path, "[]")+ await ex.mine_pr_bodies()+ await ex.mine_git_archaeology()++ assert ex.test_provider.max_tokens+ assert set(ex.test_provider.max_tokens) == {_BATCH_MAX_TOKENS}