Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(decisions): read significant-commit metadata the same way in both commit miners (#2605)
Raghav Chamadiya6e51929926ba
diff --git a/packages/core/src/repowise/core/analysis/decisions/commit_mining.py b/packages/core/src/repowise/core/analysis/decisions/commit_mining.pyindex f4544bfc5..e9774a0a3 100644--- a/packages/core/src/repowise/core/analysis/decisions/commit_mining.py+++ b/packages/core/src/repowise/core/analysis/decisions/commit_mining.py@@ -4,7 +4,6 @@ from __future__ import annotationsimport jsonfrom collections.abc import Sequence-from typing import Anyfrom repowise.core.analysis.decisions.scope import (SCOPE_BASIS_SELECTED,@@ -112,19 +111,21 @@ def _attribute_to_commit(return sha-def _significant_commits(meta: dict) -> Any:- """A file's ``significant_commits_json`` as the miner reads it.+def _significant_commits(meta: dict) -> list[dict]:+ """A file's ``significant_commits_json`` as the commit dicts both miners read.- A string that does not decode yields no commits; anything else passes- through as-is.+ Accepts the stored JSON string or an already-decoded list. Any other shape,+ or a string that does not decode to a list, reads as no commits."""- commits_json = meta.get("significant_commits_json", "[]")- if not isinstance(commits_json, str):- return commits_json- try:- return json.loads(commits_json)- except (json.JSONDecodeError, TypeError):+ value = meta.get("significant_commits_json")+ if isinstance(value, str):+ try:+ value = json.loads(value)+ except json.JSONDecodeError:+ return []+ if not isinstance(value, list):return []+ return [c for c in value if isinstance(c, dict)]def _admit_signal_commit(commit: dict, commit_map: dict[str, dict]) -> bool:@@ -158,19 +159,6 @@ def signal_commits(return commit_map, commit_files-def _loads_commits(value: Any) -> list[dict]:- """Parse a ``significant_commits_json`` blob into a list of dicts."""- if isinstance(value, list):- return value- if isinstance(value, str):- try:- data = json.loads(value)- except (json.JSONDecodeError, TypeError):- return []- return data if isinstance(data, list) else []- return []--def _pr_candidate(commit: dict, body: str) -> dict | None:"""The prompt-ready record of a PR-shaped body with decision signals, else None."""low = body.lower()@@ -195,7 +183,7 @@ def pr_candidates(candidates: dict[str, dict] = {}files_by_sha: dict[str, list[str]] = {}for fp, meta in git_meta_map.items():- for c in _loads_commits(meta.get("significant_commits_json")):+ for c in _significant_commits(meta):sha = c.get("sha", "")if not sha:continuediff --git a/tests/unit/analysis/test_decision_commit_selection.py b/tests/unit/analysis/test_decision_commit_selection.pyindex fd262400a..2f05925c8 100644--- a/tests/unit/analysis/test_decision_commit_selection.py+++ b/tests/unit/analysis/test_decision_commit_selection.py@@ -20,6 +20,9 @@ import jsonfrom pathlib import Pathfrom types import SimpleNamespace+import pytest++from repowise.core.analysis.decisions.commit_mining import pr_candidates, signal_commitsfrom repowise.core.analysis.decisions.extractor import (DecisionExtractor,_coerce_paths,@@ -257,6 +260,40 @@ async def test_git_archaeology_shows_the_files_in_a_reproducible_order(tmp_path)assert shown == sorted(shown)+# --- stored commit metadata in a shape the miners cannot use ---------------++_UNUSABLE_COMMIT_METADATA = {+ "none": None,+ "json_dict": json.dumps({"sha": _SHA, "message": "not a list"}),+ "json_list_of_non_dicts": json.dumps([1, "two", None]),+ "malformed_json": '[{"sha": ',+}++[email protected]("value", _UNUSABLE_COMMIT_METADATA.values(), ids=_UNUSABLE_COMMIT_METADATA)+async def test_both_miners_read_unusable_commit_metadata_as_no_commits(tmp_path, value):+ """Git archaeology and the PR miner degrade alike instead of raising."""+ ex = _extractor(tmp_path, _payload(affected_files=[_SUBJECT]))+ ex._git_meta_map = {_SUBJECT: {"significant_commits_json": value}}++ assert await ex.mine_git_archaeology() == []+ assert await ex.mine_pr_bodies() == []+ assert ex.test_provider.prompts == [] # type: ignore[attr-defined]++[email protected]("value", _UNUSABLE_COMMIT_METADATA.values(), ids=_UNUSABLE_COMMIT_METADATA)+def test_one_unusable_file_does_not_hide_the_valid_ones(value):+ meta = {**_meta_map([_SUBJECT]), "packages/other.py": {"significant_commits_json": value}}++ commit_map, commit_files = signal_commits(meta)+ candidates, files_by_sha = pr_candidates(meta)++ assert list(commit_map) == [_SHA]+ assert commit_files == {_SHA: [_SUBJECT]}+ assert list(candidates) == [_SHA]+ assert files_by_sha == {_SHA: [_SUBJECT]}++# --- what the model returned, when it is not a list of paths ---------------