Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(cli): surface broken built-in seam imports in `repowise plugins` (#4748)
Siddheya Kulkarni82f94e8285c7
diff --git a/packages/cli/src/repowise/cli/commands/plugins_cmd.py b/packages/cli/src/repowise/cli/commands/plugins_cmd.pyindex a234eb47b..c4153d65a 100644--- a/packages/cli/src/repowise/cli/commands/plugins_cmd.py+++ b/packages/cli/src/repowise/cli/commands/plugins_cmd.py@@ -33,8 +33,12 @@ def _import_builtin_seams() -> None:module = importlib.import_module(name)if name == "repowise.server.chat_datasets":module.dataset_names() # imports the built-in dataset families- except ImportError: # server extras not installed: those seams go unlisted- continue+ except ModuleNotFoundError as exc:+ # Only a missing third-party package (server extras not installed)+ # leaves a seam unlisted; a broken repowise import must surface.+ missing = exc.name or ""+ if missing == "repowise" or missing.startswith("repowise."):+ raise@click.command("plugins")diff --git a/tests/unit/registry/test_plugins.py b/tests/unit/registry/test_plugins.pyindex 51e8a80d4..fc266f704 100644--- a/tests/unit/registry/test_plugins.py+++ b/tests/unit/registry/test_plugins.py@@ -2,6 +2,7 @@from __future__ import annotations+import importlibimport importlib.metadataimport jsonimport os@@ -298,6 +299,52 @@ def test_plugins_command_with_nothing_installed():assert "No plugins loaded" in result.output+def _fail_import_of(monkeypatch, target, error):+ from repowise.cli.commands import plugins_cmd++ real = importlib.import_module++ def broken(name, *args, **kwargs):+ if name == target:+ raise error+ return real(name, *args, **kwargs)++ monkeypatch.setattr(plugins_cmd.importlib, "import_module", broken)+ return plugins_cmd.plugins_command+++ "error",+ [+ ImportError("cannot import name 'CloudEvent' from 'repowise.core.events.model'"),+ ModuleNotFoundError("No module named 'repowise.core.gone'", name="repowise.core.gone"),+ ],+)+def test_plugins_command_fails_when_a_builtin_module_is_broken(monkeypatch, error):+ command = _fail_import_of(monkeypatch, "repowise.core.events.sinks", error)+ result = CliRunner().invoke(command, ["--format", "json"])+ assert result.exit_code != 0+ assert result.exception is error+++def test_plugins_command_fails_on_a_third_party_import_error_that_is_not_a_missing_package(+ monkeypatch,+):+ error = ImportError("cannot import name 'x' from 'fastapi'", name="fastapi")+ command = _fail_import_of(monkeypatch, "repowise.server.auth", error)+ result = CliRunner().invoke(command, ["--format", "json"])+ assert result.exit_code != 0+ assert result.exception is error+++def test_plugins_command_skips_a_builtin_module_missing_a_third_party_package(monkeypatch):+ error = ModuleNotFoundError("No module named 'fastapi'", name="fastapi")+ command = _fail_import_of(monkeypatch, "repowise.server.auth", error)+ result = CliRunner().invoke(command, ["--format", "json"])+ assert result.exit_code == 0, result.output+ assert "seams" in json.loads(result.output)++def test_dispatching_a_builtin_command_never_runs_discovery():"""Discovery costs ~100 ms, so a known command must not pay it."""probe = (