Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

Handle corrupt LanceDB reads during resume (#1882)

Siddhesh84f0afb1ec06
diff --git a/packages/core/src/repowise/core/persistence/vector_store/lancedb_store.py b/packages/core/src/repowise/core/persistence/vector_store/lancedb_store.py
index 734ccd68d..49eebe578 100644
--- a/packages/core/src/repowise/core/persistence/vector_store/lancedb_store.py
+++ b/packages/core/src/repowise/core/persistence/vector_store/lancedb_store.py
@@ -2,6 +2,7 @@
from __future__ import annotations
+import logging
from pathlib import Path
from typing import Any
@@ -24,6 +25,8 @@ __all__ = ["STORED_SNIPPET_CHARS", "LanceDBVectorStore", "read_recorded_vector_d
# gigabytes before returning even though the selected result is small.
_SUMMARY_PATH_BATCH_SIZE = 100
+logger = logging.getLogger(__name__)
+
# LanceDB caches each table version's manifest (default cap 1 GiB), and every
# manifest lists all fragments so far. Writes are batched below, but update runs
# and long-lived servers still accumulate versions; reads only need the latest.
@@ -472,8 +475,20 @@ class LanceDBVectorStore(VectorStore):
await self._ensure_connected()
if self._table is None:
return set()
- rows = await self._table.query().select(["page_id"]).to_list() # type: ignore[union-attr]
- return {r["page_id"] for r in rows}
+
+ try:
+ rows = await self._table.query().select(["page_id"]).to_list() # type: ignore[union-attr]
+ return {r["page_id"] for r in rows}
+ except Exception as exc:
+ logger.warning(
+ "Failed to read page IDs from LanceDB vector store at %s. "
+ "The vector store may be damaged. Repowise will regenerate "
+ "pages instead. Run 'repowise reindex' to rebuild the vector store. "
+ "Error: %s",
+ self._db_path,
+ exc,
+ )
+ return set()
async def get_page_summary_by_path(self, path: str) -> dict | None:
"""Return {'summary': str, 'key_exports': list[str]} for a previously-indexed page, or None.
diff --git a/tests/unit/persistence/test_vector_store.py b/tests/unit/persistence/test_vector_store.py
index 9dc324c8c..40ee05eb2 100644
--- a/tests/unit/persistence/test_vector_store.py
+++ b/tests/unit/persistence/test_vector_store.py
@@ -7,6 +7,7 @@ LanceDB-specific tests are skipped if lancedb is not installed.
from __future__ import annotations
+import logging
import math
import pytest
@@ -525,6 +526,50 @@ async def test_lancedb_embed_batch_isolates_failed_chunk(tmp_path):
finally:
await store.close()
+async def test_lancedb_list_page_ids_handles_corrupt_store(tmp_path, mock_embedder, caplog):
+ """A damaged LanceDB table must not crash resume generation."""
+ caplog.set_level(logging.WARNING, logger="repowise.core.persistence.vector_store.lancedb_store")
+ pytest.importorskip("lancedb")
+ from repowise.core.persistence.vector_store import LanceDBVectorStore
+
+ db_path = tmp_path / "lance"
+
+ store = LanceDBVectorStore(str(db_path), mock_embedder)
+
+ try:
+ await store.embed_and_upsert(
+ "p1",
+ "test content",
+ {"target_path": "a.py"},
+ )
+
+ # Healthy store still returns its page IDs.
+ assert await store.list_page_ids() == {"p1"}
+
+ # Simulate a corrupted LanceDB read.
+ class BrokenQuery:
+ def select(self, columns):
+ return self
+
+ async def to_list(self):
+ raise RuntimeError("simulated LanceDB corruption")
+
+ class BrokenTable:
+ def query(self):
+ return BrokenQuery()
+
+ store._table = BrokenTable()
+
+ # Corruption must degrade safely instead of crashing.
+ assert await store.list_page_ids() == set()
+
+ assert "vector store may be damaged" in caplog.text.lower()
+ assert "repowise reindex" in caplog.text.lower()
+
+ finally:
+ await store.close()
+
@pytest.mark.asyncio
async def test_lancedb_embed_batch_writes_in_few_versions(tmp_path):