Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(health): count Go select arms and TS/JS default arms in complexity (#2255)
JikSau-Db1bd01a8e760
diff --git a/packages/core/src/repowise/core/analysis/health/complexity/languages.py b/packages/core/src/repowise/core/analysis/health/complexity/languages.pyindex b07354930..4ad294053 100644--- a/packages/core/src/repowise/core/analysis/health/complexity/languages.py+++ b/packages/core/src/repowise/core/analysis/health/complexity/languages.py@@ -394,7 +394,7 @@ _TS = LanguageNodeMap(try_kinds=frozenset({"try_statement"}),catch_kinds=frozenset({"catch_clause"}),switch_kinds=frozenset({"switch_statement"}),- case_kinds=frozenset({"switch_case"}),+ case_kinds=frozenset({"switch_case", "switch_default"}),boolean_operator_kinds=frozenset(),boolean_operator_text_kinds=frozenset({"binary_expression"}),class_kinds=frozenset({"class_declaration", "class", "abstract_class_declaration"}),@@ -438,8 +438,10 @@ _GO = LanguageNodeMap(loop_kinds=frozenset({"for_statement"}),try_kinds=frozenset(),catch_kinds=frozenset(),- switch_kinds=frozenset({"expression_switch_statement", "type_switch_statement"}),- case_kinds=frozenset({"expression_case", "type_case", "default_case"}),+ switch_kinds=frozenset(+ {"expression_switch_statement", "type_switch_statement", "select_statement"}+ ),+ case_kinds=frozenset({"expression_case", "type_case", "default_case", "communication_case"}),boolean_operator_kinds=frozenset(),boolean_operator_text_kinds=frozenset({"binary_expression"}),# No class-level fields: Go methods attach to a type via an externaldiff --git a/tests/unit/health/test_language_node_maps.py b/tests/unit/health/test_language_node_maps.pyindex f0683d2ab..64c0afff2 100644--- a/tests/unit/health/test_language_node_maps.py+++ b/tests/unit/health/test_language_node_maps.py@@ -264,3 +264,156 @@ def test_fsharp_single_expression_body_is_a_known_undercount() -> None:"""_require_language("fsharp")assert _rows("fsharp", "let f x =\n if x > 0 then 1 else 2\n", "fs") == {"f": 1}+++# --------------------------------------------------------------------------- #+# Go+# --------------------------------------------------------------------------- #++_GO_CASES: list[tuple[str, str, dict[str, int]]] = [+ (+ "a flat select counts once for the dispatch, at any width",+ "package main\n\nfunc drain(ch chan int, done chan bool) int {\n"+ "\ttotal := 0\n"+ "\tselect {\n"+ "\tcase v := <-ch:\n\t\ttotal += v\n"+ "\tcase <-done:\n\t\ttotal += 100\n"+ "\tcase ch <- 1:\n\t\ttotal += 1\n"+ "\t}\n"+ "\treturn total\n}\n",+ {"drain": 2},+ ),+ (+ "a select with a default arm stays flat",+ "package main\n\nfunc drain(ch chan int, done chan bool) int {\n"+ "\ttotal := 0\n"+ "\tselect {\n"+ "\tcase v := <-ch:\n\t\ttotal += v\n"+ "\tcase <-done:\n\t\ttotal += 100\n"+ "\tdefault:\n\t\ttotal -= 1\n"+ "\t}\n"+ "\treturn total\n}\n",+ {"drain": 2},+ ),+ (+ "control flow inside a select arm counts on top of the dispatch",+ "package main\n\nfunc pick(ch chan int) int {\n"+ "\tselect {\n"+ "\tcase v := <-ch:\n"+ "\t\tif v > 0 {\n\t\t\treturn v\n\t\t}\n"+ "\t\treturn 0\n"+ "\tdefault:\n\t\treturn -1\n"+ "\t}\n}\n",+ {"pick": 4},+ ),+]+++ ("source", "expected"),+ [(src, exp) for _, src, exp in _GO_CASES],+ ids=[label for label, _, _ in _GO_CASES],+)+def test_go_complexity(source: str, expected: dict[str, int]) -> None:+ _require_language("go")+ assert _rows("go", source, "go") == expected+++def test_go_select_agrees_with_an_equivalent_switch() -> None:+ """``select`` is a dispatch, so an arm is worth what a ``switch`` case is.++ tree-sitter-go spells the construct ``select_statement`` with+ ``communication_case`` arms; neither type appeared in the map, so every arm+ was invisible and a three-arm select scored CCN 1 (a straight line) while+ the equivalent three-case switch scored 2. Only ``default`` registered,+ because ``default_case`` is shared with ``switch``.+ """+ _require_language("go")+ select = (+ "package main\n\nfunc pick(ch chan int) int {\n"+ "\tselect {\n"+ "\tcase v := <-ch:\n"+ "\t\tif v > 0 {\n\t\t\treturn v\n\t\t}\n"+ "\t\treturn 0\n"+ "\tdefault:\n\t\treturn -1\n"+ "\t}\n}\n"+ )+ switch = (+ "package main\n\nfunc pick(ch chan int) int {\n"+ "\tswitch {\n"+ "\tcase ch != nil:\n"+ "\t\tif ch != nil {\n\t\t\treturn 1\n\t\t}\n"+ "\t\treturn 0\n"+ "\tdefault:\n\t\treturn -1\n"+ "\t}\n}\n"+ )+ assert _rows("go", select, "go")["pick"] == _rows("go", switch, "go")["pick"] == 4+++# --------------------------------------------------------------------------- #+# TypeScript / JavaScript+# --------------------------------------------------------------------------- #++_TS_CASES: list[tuple[str, str, dict[str, int]]] = [+ (+ "a flat switch counts once for the dispatch, default included",+ """+function pick(x: number): number {+ switch (x) { case 1: return 1; case 2: return 2; default: return 0; }+}+""",+ {"pick": 2},+ ),+ (+ "control flow inside a default arm counts on top of the dispatch",+ """+function pick(x: number): number {+ switch (x) {+ case 1: return 1;+ default: { if (x > 0) { return 2; } return 3; }+ }+}+""",+ {"pick": 4},+ ),+]+++ ("source", "expected"),+ [(src, exp) for _, src, exp in _TS_CASES],+ ids=[label for label, _, _ in _TS_CASES],+)+def test_typescript_complexity(source: str, expected: dict[str, int]) -> None:+ _require_language("typescript")+ assert _rows("typescript", source, "ts") == expected+++def test_typescript_default_arm_agrees_with_java() -> None:+ """``switch_default`` is a separate node in the JS/TS grammar.++ ``case_kinds`` named only ``switch_case``, so a complex ``default:`` arm+ never counted while Java / C# / Objective-C / C counted theirs. The same+ dispatch must score the same in both languages.+ """+ _require_language("typescript")+ _require_language("java")+ typescript = """+function pick(x: number): number {+ switch (x) {+ case 1: return 1;+ default: { if (x > 0) { return 2; } return 3; }+ }+}+"""+ java = """+public class A {+ int pick(int x) {+ switch (x) {+ case 1: return 1;+ default: { if (x > 0) { return 2; } return 3; }+ }+ }+}+"""+ assert _rows("typescript", typescript, "ts")["pick"] == _rows("java", java, "java")["pick"] == 4