Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

refactor(mcp): share the signature and stale-status helpers (#3976)

Raghav Chamadiyabbc09fa68135
diff --git a/packages/core/src/repowise/core/generation/page_selection.py b/packages/core/src/repowise/core/generation/page_selection.py
index cdbdb3410..7ed92a029 100644
--- a/packages/core/src/repowise/core/generation/page_selection.py
+++ b/packages/core/src/repowise/core/generation/page_selection.py
@@ -30,6 +30,11 @@ from repowise.core.generation.models import MODEL_WRITTEN_PAGE_TYPES
STALE_STATUSES = frozenset({"stale", "expired"})
+def is_stale_status(status: str | None) -> bool:
+ """Whether a page's ``freshness_status`` counts as stale."""
+ return status in STALE_STATUSES
+
+
@dataclass(frozen=True)
class PageRecord:
"""A minimal view of one persisted wiki page.
@@ -47,7 +52,7 @@ class PageRecord:
@property
def is_stale(self) -> bool:
- return self.freshness_status in STALE_STATUSES
+ return is_stale_status(self.freshness_status)
@dataclass(frozen=True)
diff --git a/packages/server/src/repowise/server/mcp_server/_helpers.py b/packages/server/src/repowise/server/mcp_server/_helpers.py
index 3fe078926..6db248582 100644
--- a/packages/server/src/repowise/server/mcp_server/_helpers.py
+++ b/packages/server/src/repowise/server/mcp_server/_helpers.py
@@ -152,6 +152,16 @@ async def _get_repo(session: AsyncSession, repo: str | None = None) -> Repositor
# ---------------------------------------------------------------------------
+def clean_signature(signature: str | None) -> str:
+ """Collapse a stored signature onto one line.
+
+ Signatures indexed from CRLF files carry literal ``\\r\\n`` plus the
+ original indentation. Whitespace runs collapse to single spaces; the text
+ is unchanged otherwise.
+ """
+ return " ".join((signature or "").split())
+
+
def _is_workspace_mode() -> bool:
"""Return True if the MCP server is running in workspace mode."""
return _state._registry is not None
diff --git a/packages/server/src/repowise/server/mcp_server/tool_context/targets.py b/packages/server/src/repowise/server/mcp_server/tool_context/targets.py
index 5ca5b3b5c..35651f579 100644
--- a/packages/server/src/repowise/server/mcp_server/tool_context/targets.py
+++ b/packages/server/src/repowise/server/mcp_server/tool_context/targets.py
@@ -22,7 +22,7 @@ from repowise.core.analysis.communities import has_community
from repowise.core.analysis.decisions.lifecycle import is_governing
from repowise.core.analysis.decisions.scope import binds_to_paths
from repowise.core.attribution import attribution_enabled, file_share
-from repowise.core.generation.page_selection import STALE_STATUSES
+from repowise.core.generation.page_selection import is_stale_status
from repowise.core.ingestion.models import (
NON_DEPENDENCY_EDGE_TYPES,
SYMBOL_USE_EDGE_TYPES,
@@ -51,6 +51,7 @@ from repowise.server.mcp_server._edit_sites import reference_edit_set
from repowise.server.mcp_server._helpers import (
LIKE_ESCAPE,
_decision_body,
+ clean_signature,
escape_like,
filter_dicts_by_key,
filter_path_list,
@@ -160,7 +161,7 @@ async def _compact_symbol_rows(
row: dict[str, Any] = {
"name": s.name,
"kind": s.kind,
- "signature": _clean_signature(s.signature),
+ "signature": clean_signature(s.signature),
"line": s.start_line,
}
sid = symbol_identity(s.symbol_id)
@@ -362,16 +363,6 @@ def _file_preview(repo_root: Any, file_path: str) -> dict[str, Any] | None:
return preview
-def _clean_signature(signature: str | None) -> str:
- """Collapse a stored signature onto one line.
-
- Signatures indexed from CRLF files carry literal ``\\r\\n`` plus the
- original indentation — pure token waste in a triage card. Whitespace
- runs collapse to single spaces; the text is unchanged otherwise.
- """
- return " ".join((signature or "").split())
-
-
def _size_exclusion_note(repo_root: Any, target: str) -> str | None:
"""Explain a missing file that ingestion dropped on size, else None.
@@ -844,7 +835,7 @@ async def _resolve_one_target(
{
"name": s.name,
"kind": s.kind,
- "signature": _clean_signature(s.signature),
+ "signature": clean_signature(s.signature),
"start_line": s.start_line,
"end_line": s.end_line,
"symbol_id": symbol_identity(s.symbol_id),
@@ -981,7 +972,7 @@ async def _resolve_one_target(
):
value = getattr(sym, attr, None)
if value:
- docs[key] = _clean_signature(value) if attr == "signature" else value
+ docs[key] = clean_signature(value) if attr == "signature" else value
# File page summary (full content gated behind include=["full_doc"])
sym_page_id = f"file_page:{sym.file_path}"
sym_page = await session.get(Page, sym_page_id)
@@ -1321,27 +1312,23 @@ async def _resolve_one_target(
)
# --- Freshness ---
- # ``is_stale`` uses ``STALE_STATUSES``, the set ``repowise generate --stale``
+ # ``is_stale`` uses ``is_stale_status``, the rule ``repowise generate --stale``
# uses, so "stale" means one thing. Not ``confidence``: that rates how far a
# page can be trusted, not whether it has fallen behind the code.
if include is None or "freshness" in include:
freshness: dict[str, Any] = {}
- def _is_stale(row: Page) -> bool:
- # The column is NOT NULL, but a hand-written None reads as fresh.
- return (row.freshness_status or "fresh") in STALE_STATUSES
-
if page:
freshness["confidence_score"] = page.confidence
freshness["freshness_status"] = page.freshness_status
- freshness["is_stale"] = _is_stale(page)
+ freshness["is_stale"] = is_stale_status(page.freshness_status)
elif target_type == "symbol" and file_path_for_git:
sym_page_id = f"file_page:{file_path_for_git}"
sym_page = await session.get(Page, sym_page_id)
if sym_page:
freshness["confidence_score"] = sym_page.confidence
freshness["freshness_status"] = sym_page.freshness_status
- freshness["is_stale"] = _is_stale(sym_page)
+ freshness["is_stale"] = is_stale_status(sym_page.freshness_status)
else:
freshness["confidence_score"] = None
freshness["freshness_status"] = None
diff --git a/packages/server/src/repowise/server/mcp_server/tool_symbol.py b/packages/server/src/repowise/server/mcp_server/tool_symbol.py
index b50067a7a..164d887a8 100644
--- a/packages/server/src/repowise/server/mcp_server/tool_symbol.py
+++ b/packages/server/src/repowise/server/mcp_server/tool_symbol.py
@@ -65,6 +65,7 @@ from repowise.server.mcp_server._helpers import (
_is_workspace_mode,
_resolve_repo_context,
_unsupported_repo_all,
+ clean_signature,
is_excluded,
read_repo_file_text,
)
@@ -357,7 +358,7 @@ def _prepare_callee_entries(
"name": row.name,
"file": row.file_path,
"kind": row.kind,
- "signature": _clean_symbol_signature(row.signature),
+ "signature": clean_signature(row.signature),
"depth": hop.number,
}
if row.file_path not in text_cache:
@@ -489,11 +490,6 @@ async def _expand_callees(
return block
-def _clean_symbol_signature(signature: str | None) -> str:
- """Collapse a stored signature onto one line (CRLF indices keep the \\r\\n)."""
- return " ".join((signature or "").split())
-
-
def _extract_omission_ref(symbol_id: str) -> str | None:
"""Return the 12-hex omission ref when *symbol_id* is ref-shaped, else None."""
from repowise.server.mcp_server._references import omission_reference
@@ -843,7 +839,7 @@ async def _container_outline(
entry: dict[str, Any] = {
"symbol_id": symbol_identity(member.symbol_id),
"kind": member.kind,
- "signature": _clean_symbol_signature(member.signature),
+ "signature": clean_signature(member.signature),
"start_line": check.start_line,
"end_line": check.end_line,
}
diff --git a/packages/server/src/repowise/server/scheduler.py b/packages/server/src/repowise/server/scheduler.py
index 17832d8c5..9afc829a7 100644
--- a/packages/server/src/repowise/server/scheduler.py
+++ b/packages/server/src/repowise/server/scheduler.py
@@ -75,6 +75,7 @@ def setup_scheduler(
"""Find stale pages and log them for regeneration."""
from sqlalchemy import func, select
+ from repowise.core.generation.page_selection import STALE_STATUSES
from repowise.core.persistence.database import get_session
from repowise.core.persistence.models import Page, Repository
@@ -89,7 +90,7 @@ def setup_scheduler(
.select_from(Page)
.where(
Page.repository_id == repo.id,
- Page.freshness_status.in_(["stale", "expired"]),
+ Page.freshness_status.in_(sorted(STALE_STATUSES)),
)
)
stale_count = stale_result.scalar()