Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(cli): reindex exits non-zero when every embed failed (#1732)
Sloedfe6196b0894
diff --git a/packages/cli/src/repowise/cli/commands/reindex_cmd.py b/packages/cli/src/repowise/cli/commands/reindex_cmd.pyindex 1b9906cf9..113a313e3 100644--- a/packages/cli/src/repowise/cli/commands/reindex_cmd.py+++ b/packages/cli/src/repowise/cli/commands/reindex_cmd.py@@ -253,3 +253,10 @@ async def _reindex(repo_path, embedder_name: str, batch_size: int) -> None:+ (f" ({below_floor} held back as too thin to index)" if below_floor else "")+ f" -> {lance_dir}")++ # A reindex that indexed nothing but failed on every item is a failed+ # build, not a success: an automated pipeline (or an agent) must not treat+ # an empty vector index as a successful reindex. Exit non-zero so the+ # failure is visible in the exit status, not just in the printed count.+ if indexed == 0 and failed > 0:+ raise click.Abort()diff --git a/tests/unit/cli/test_reindex_cmd.py b/tests/unit/cli/test_reindex_cmd.pyindex 639bab080..06a675dbb 100644--- a/tests/unit/cli/test_reindex_cmd.py+++ b/tests/unit/cli/test_reindex_cmd.py@@ -5,6 +5,9 @@ from __future__ import annotationsfrom pathlib import Pathfrom typing import Any+import click+import pytest+from repowise.cli.commands import reindex_cmd@@ -69,3 +72,91 @@ async def test_reindex_uses_shared_database_engine(assert created["url"] == db_urlassert created["init_engine"] is created["engine"]assert created["engine"].disposed is True+++async def test_reindex_aborts_when_every_item_failed(+ monkeypatch,+ tmp_path: Path,+) -> None:+ """A reindex that indexed nothing but failed on every item must not exit 0.++ An automated pipeline (or an agent) treats a zero exit as a successful+ build, so an empty vector index after a total embedder failure would be+ mistaken for a healthy reindex.+ """+ db_url = f"sqlite+aiosqlite:///{tmp_path / 'wiki.db'}"++ def fake_create_engine(url: str):+ return _DummyEngine()++ async def fake_init_db(engine: object) -> None:+ return None++ monkeypatch.setenv("OPENAI_API_KEY", "sk-test")+ monkeypatch.setattr(reindex_cmd, "get_db_url_for_repo", lambda _repo_path: db_url)+ monkeypatch.setattr(+ "repowise.core.persistence.database.create_engine",+ fake_create_engine,+ )+ monkeypatch.setattr("repowise.core.persistence.database.init_db", fake_init_db)+ monkeypatch.setattr("sqlalchemy.ext.asyncio.async_sessionmaker", _sessionmaker)++ # No pages in the DB → nothing to index, nothing failed → no abort.+ await reindex_cmd._reindex(tmp_path, "openai", batch_size=20)++ # Force the failure path: every item fails to embed. Patch the vector+ # store's embed_batch to raise, and give the store a page to process.+ class _FailingStore:+ async def embed_batch(self, items: list[Any]) -> None:+ raise RuntimeError("embedder down")++ async def embed_and_upsert(self, *args: Any, **kwargs: Any) -> None:+ raise RuntimeError("embedder down")++ async def close(self) -> None:+ return None++ class _Page:+ id = "p1"+ title = "Page"+ page_type = "file_page"+ target_path = "src/main.py"+ summary = ""+ content = "body"+ decision = "a decision"++ class _FailingSession:+ async def __aenter__(self) -> _FailingSession:+ return self++ async def __aexit__(self, *args: object) -> None:+ return None++ async def execute(self, _stmt: object) -> _EmptyResult:+ return _EmptyResult()++ class _FailingResult(_EmptyResult):+ def all(self) -> list[Any]:+ return [_Page()]++ class _FailingSession2:+ async def __aenter__(self) -> _FailingSession2:+ return self++ async def __aexit__(self, *args: object) -> None:+ return None++ async def execute(self, _stmt: object) -> _FailingResult:+ return _FailingResult()++ def _failing_sessionmaker(*_args: object, **_kwargs: object):+ return _FailingSession2++ monkeypatch.setattr("sqlalchemy.ext.asyncio.async_sessionmaker", _failing_sessionmaker)+ monkeypatch.setattr(+ "repowise.core.persistence.vector_store.LanceDBVectorStore",+ lambda *a, **k: _FailingStore(),+ )++ with pytest.raises(click.Abort):+ await reindex_cmd._reindex(tmp_path, "openai", batch_size=20)