Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.
Python aicode-complexitycode-healthcode-intelligencecode-qualitydead-codedeveloper-toolsdocumentationgit-analyticsmcpopen-sourcepythonrefactoringstatic-analysistechnical-debt
fix(ingestion): skip unity-generated dotnet scan paths (#499)
joptimuse3fdebc95164
diff --git a/packages/core/src/repowise/core/ingestion/resolvers/dotnet/index.py b/packages/core/src/repowise/core/ingestion/resolvers/dotnet/index.pyindex 28a0dd3cc..c401009d6 100644--- a/packages/core/src/repowise/core/ingestion/resolvers/dotnet/index.py+++ b/packages/core/src/repowise/core/ingestion/resolvers/dotnet/index.py@@ -11,7 +11,12 @@ import structlogfrom repowise.core.fs_walk import iter_globfrom .global_usings import collect_project_global_usings-from .msbuild import MSBuildProject, find_csproj_files, find_directory_build_props, parse_csproj+from .msbuild import (+ MSBuildProject,+ find_csproj_files,+ parse_csproj,+ path_has_dotnet_scan_skip_dir,+)from .namespace_map import build_namespace_mapfrom .solution import find_sln_files, parse_sln@@ -151,9 +156,6 @@ class DotNetProjectIndex:return package_id in self.package_refs.get(csproj, set())-_CS_WALK_SKIP_DIRS = frozenset({"bin", "obj", ".vs", "node_modules", ".git", "packages"})--def _walk_repo_cs_files(repo_path: Path, *, prune_nested_git: bool = True) -> list[Path]:"""Single repo-wide rglob for ``*.cs`` files, dedup by resolved path.@@ -164,7 +166,7 @@ def _walk_repo_cs_files(repo_path: Path, *, prune_nested_git: bool = True) -> liseen: set[Path] = set()out: list[Path] = []for cs in iter_glob(repo_path, "*.cs", prune_nested_git=prune_nested_git):- if any(part in _CS_WALK_SKIP_DIRS for part in cs.parts):+ if path_has_dotnet_scan_skip_dir(cs, repo_path):continuetry:resolved = cs.resolve()@@ -317,7 +319,7 @@ def build_index(repo_path: Path, *, prune_nested_git: bool = True) -> DotNetProj_INDEX_KEY = "_dotnet_index"-def get_or_build_index(ctx: "ResolverContext") -> DotNetProjectIndex | None:+def get_or_build_index(ctx: ResolverContext) -> DotNetProjectIndex | None:"""Return the cached DotNetProjectIndex, building it on first access."""if not ctx.repo_path:return Nonediff --git a/packages/core/src/repowise/core/ingestion/resolvers/dotnet/msbuild.py b/packages/core/src/repowise/core/ingestion/resolvers/dotnet/msbuild.pyindex 829279dfc..6983422a0 100644--- a/packages/core/src/repowise/core/ingestion/resolvers/dotnet/msbuild.py+++ b/packages/core/src/repowise/core/ingestion/resolvers/dotnet/msbuild.py@@ -19,6 +19,30 @@ from repowise.core.fs_walk import iter_globlog = structlog.get_logger(__name__)+# Directory basenames the .NET / Unity resolver should never scan for+# projects or source. These are intentionally scoped to the dotnet path,+# not shared global fs_walk pruning, because names like Library/ or Logs/+# can be legitimate source trees in non-Unity repos.+DOTNET_SCAN_SKIP_DIRS: frozenset[str] = frozenset(+ {+ "bin",+ "obj",+ ".vs",+ "node_modules",+ ".git",+ "packages",+ "TestResults",+ "Library",+ "Temp",+ "Logs",+ "UserSettings",+ "MemoryCaptures",+ "Builds",+ }+)+_DOTNET_SCAN_SKIP_DIRS_CASEFOLDED = frozenset(part.casefold() for part in DOTNET_SCAN_SKIP_DIRS)++@dataclassclass MSBuildProject:"""Parsed MSBuild project file."""@@ -91,15 +115,23 @@ def parse_csproj(csproj_path: Path) -> MSBuildProject | None:def find_csproj_files(repo_path: Path, *, prune_nested_git: bool = True) -> list[Path]:"""Return all .csproj files under *repo_path*, skipping bin/obj output."""- skip = {"bin", "obj", ".vs", "node_modules", ".git", "packages", "TestResults"}out: list[Path] = []for csproj in iter_glob(repo_path, "*.csproj", prune_nested_git=prune_nested_git):- if any(part in skip for part in csproj.parts):+ if path_has_dotnet_scan_skip_dir(csproj, repo_path):continueout.append(csproj)return out+def path_has_dotnet_scan_skip_dir(path: Path, repo_root: Path) -> bool:+ """Return True when *path* lives under a dotnet-skip directory in *repo_root*."""+ try:+ parts = path.relative_to(repo_root).parts+ except ValueError:+ parts = path.parts+ return any(part.casefold() in _DOTNET_SCAN_SKIP_DIRS_CASEFOLDED for part in parts)++def find_directory_build_props(start: Path, repo_root: Path) -> list[Path]:"""Walk from *start* up to *repo_root* collecting Directory.Build.props.diff --git a/packages/core/src/repowise/core/ingestion/resolvers/dotnet/solution.py b/packages/core/src/repowise/core/ingestion/resolvers/dotnet/solution.pyindex 3fe510857..1821f062a 100644--- a/packages/core/src/repowise/core/ingestion/resolvers/dotnet/solution.py+++ b/packages/core/src/repowise/core/ingestion/resolvers/dotnet/solution.py@@ -18,6 +18,8 @@ import structlogfrom repowise.core.fs_walk import iter_glob+from .msbuild import path_has_dotnet_scan_skip_dir+log = structlog.get_logger(__name__)# Project("{TYPE}") = "Name", "rel\path.csproj", "{GUID}"@@ -59,10 +61,9 @@ def parse_sln(sln_path: Path) -> list[SolutionEntry]:def find_sln_files(repo_path: Path, *, prune_nested_git: bool = True) -> list[Path]:- skip = {".git", "node_modules", "bin", "obj"}out: list[Path] = []for sln in iter_glob(repo_path, "*.sln", prune_nested_git=prune_nested_git):- if any(part in skip for part in sln.parts):+ if path_has_dotnet_scan_skip_dir(sln, repo_path):continueout.append(sln)return outdiff --git a/packages/core/src/repowise/core/ingestion/traverser.py b/packages/core/src/repowise/core/ingestion/traverser.pyindex a07d7abc2..c15b0a6d2 100644--- a/packages/core/src/repowise/core/ingestion/traverser.py+++ b/packages/core/src/repowise/core/ingestion/traverser.py@@ -92,6 +92,13 @@ _BLOCKED_DIRS: frozenset[str] = frozenset(".eggs","site-packages",".cache",+ # Unity generated state / editor data+ "Library",+ "Temp",+ "Logs",+ "UserSettings",+ "MemoryCaptures",+ "Builds",".idea",".vscode",# NOTE: test/tests/spec/specs/__tests__ are intentionally NOT@@ -117,7 +124,27 @@ _BLOCKED_DIRS: frozenset[str] = frozenset()_BLOCKED_EXTENSIONS: frozenset[str] = frozenset(- {".pyc", ".pyo", ".pyd", ".so", ".dll", ".dylib", ".exe", ".o", ".a", ".wasm"}+ {+ ".pyc",+ ".pyo",+ ".pyd",+ ".so",+ ".dll",+ ".dylib",+ ".exe",+ ".o",+ ".a",+ ".wasm",+ # Unity non-code assets. These are large, numerous, and currently+ # provide no parser/graph value, so skip them before binary sniffing.+ ".meta",+ ".prefab",+ ".unity",+ ".asset",+ ".mat",+ ".anim",+ ".controller",+ })_BLOCKED_FILENAME_PATTERNS: list[str] = [diff --git a/tests/unit/ingestion/test_csharp_resolver.py b/tests/unit/ingestion/test_csharp_resolver.pyindex 67fae0bf6..a6279dd0e 100644--- a/tests/unit/ingestion/test_csharp_resolver.py+++ b/tests/unit/ingestion/test_csharp_resolver.py@@ -26,7 +26,6 @@ from repowise.core.ingestion.resolvers.dotnet.global_usings import scan_global_ufrom repowise.core.ingestion.resolvers.dotnet.index import build_indexfrom repowise.core.ingestion.resolvers.dotnet.namespace_map import declared_namespaces-# ---------------------------------------------------------------------------# Helpers# ---------------------------------------------------------------------------@@ -264,6 +263,35 @@ class TestProjectIndexCaching:assert first.repo_path == tmp_path.resolve()assert "Foo" in first.namespace_map+ def test_build_index_skips_unity_generated_dirs(self, tmp_path: Path) -> None:+ (tmp_path / "Game.csproj").write_text(_csproj())+ (tmp_path / "Assets" / "Scripts").mkdir(parents=True)+ (tmp_path / "Assets" / "Scripts" / "Player.cs").write_text(+ "namespace Game;\npublic class Player {}\n"+ )+ (tmp_path / "Library" / "PackageCache").mkdir(parents=True)+ (tmp_path / "Library" / "PackageCache" / "Ghost.cs").write_text(+ "namespace Noise;\npublic class Ghost {}\n"+ )+ (tmp_path / "Library" / "Generated.csproj").write_text(_csproj())+ (tmp_path / "Temp" / "StagingArea").mkdir(parents=True)+ (tmp_path / "Temp" / "StagingArea" / "TempFile.cs").write_text(+ "namespace Noise;\npublic class TempFile {}\n"+ )+ (tmp_path / "Builds" / "Windows").mkdir(parents=True)+ (tmp_path / "Builds" / "Windows" / "Exported.cs").write_text(+ "namespace Noise;\npublic class Exported {}\n"+ )+ (tmp_path / "Builds" / "Windows" / "Exported.csproj").write_text(_csproj())++ index = build_index(tmp_path)++ assert {proj.name for proj in index.projects.values()} == {"Game"}+ assert "Player" in index.type_map+ assert "Ghost" not in index.type_map+ assert "TempFile" not in index.type_map+ assert "Exported" not in index.type_map+@pytest.mark.parametrize("raw,expected",diff --git a/tests/unit/ingestion/test_fs_walk.py b/tests/unit/ingestion/test_fs_walk.pyindex b2faf393f..21b9d00e0 100644--- a/tests/unit/ingestion/test_fs_walk.py+++ b/tests/unit/ingestion/test_fs_walk.py@@ -131,8 +131,12 @@ class TestPruning:at ``build/go.mod`` must stay discoverable."""_write(tmp_path, "coverage/__init__.py")_write(tmp_path, "build/go.mod")+ _write(tmp_path, "Library/app.py")+ _write(tmp_path, "Logs/worker.py")assert list(iter_glob(tmp_path, "__init__.py")) == [tmp_path / "coverage" / "__init__.py"]assert list(iter_glob(tmp_path, "go.mod")) == [tmp_path / "build" / "go.mod"]+ assert list(iter_glob(tmp_path, "app.py")) == [tmp_path / "Library" / "app.py"]+ assert list(iter_glob(tmp_path, "worker.py")) == [tmp_path / "Logs" / "worker.py"]def test_derived_set_prunes_output_dirs(self, tmp_path: Path) -> None:"""PRUNED_DIRS_DERIVED (dynamic hints) prunes derived-output names."""@@ -145,6 +149,8 @@ class TestPruning:"""Canary: the dirs behind past incidents stay pruned."""for d in ("node_modules", ".venv", "__pycache__", ".git", ".repowise", ".next"):assert d in PRUNED_DIRS+ for d in ("Library", "Temp", "Logs", "UserSettings", "MemoryCaptures"):+ assert d not in PRUNED_DIRSfor d in ("dist", "build", "out", "coverage"):assert d not in PRUNED_DIRS # possible source dirs — derived set onlyassert d in PRUNED_DIRS_DERIVEDdiff --git a/tests/unit/ingestion/test_traverser.py b/tests/unit/ingestion/test_traverser.pyindex f468c293d..e5eff100b 100644--- a/tests/unit/ingestion/test_traverser.py+++ b/tests/unit/ingestion/test_traverser.py@@ -6,6 +6,7 @@ from pathlib import Pathimport pytest+from repowise.core.ingestion import traverser as traverser_modfrom repowise.core.ingestion.traverser import FileTraverser, _detect_language# ---------------------------------------------------------------------------@@ -102,6 +103,40 @@ class TestFileTraverser:paths = [f.path for f in traverser.traverse()]assert not any("__pycache__" in p for p in paths)+ def test_skips_unity_generated_dirs(self, tmp_path: Path) -> None:+ (tmp_path / "Assets" / "Scripts").mkdir(parents=True)+ (tmp_path / "Assets" / "Scripts" / "Game.cs").write_text("class Game {}")+ (tmp_path / "Library" / "PackageCache").mkdir(parents=True)+ (tmp_path / "Library" / "PackageCache" / "Fake.cs").write_text("class Fake {}")+ (tmp_path / "Temp" / "StagingArea").mkdir(parents=True)+ (tmp_path / "Temp" / "StagingArea" / "Temp.cs").write_text("class TempFile {}")+ traverser = FileTraverser(tmp_path)+ paths = [f.path for f in traverser.traverse()]+ assert "Assets/Scripts/Game.cs" in paths+ assert not any(p.startswith("Library/") for p in paths)+ assert not any(p.startswith("Temp/") for p in paths)++ def test_skips_unity_asset_extensions_before_binary_detection(+ self, tmp_path: Path, monkeypatch: pytest.MonkeyPatch+ ) -> None:+ (tmp_path / "Assets").mkdir()+ (tmp_path / "Assets" / "Scene.unity").write_text("%YAML 1.1\n")+ (tmp_path / "Assets" / "Main.cs").write_text("class Main {}")++ def _fail_binary(_path: Path) -> bool:+ raise AssertionError("Unity asset hit binary detection")++ def _fail_shebang(_path: Path) -> str:+ raise AssertionError("Unity asset hit shebang detection")++ monkeypatch.setattr(traverser_mod, "_is_binary", _fail_binary)+ monkeypatch.setattr(traverser_mod, "_detect_by_shebang", _fail_shebang)++ traverser = FileTraverser(tmp_path)+ paths = [f.path for f in traverser.traverse()]+ assert "Assets/Main.cs" in paths+ assert "Assets/Scene.unity" not in paths+def test_skips_binary_files(self, tmp_path: Path) -> None:binary = tmp_path / "binary.so"binary.write_bytes(b"\x00\x01\x02\x03" * 100)