Skip to content

Codebase intelligence for AI and humans: code health scores, auto-generated docs, git analytics, dead code detection, and architectural decisions via MCP.

fix(core): pass unbounded limit to list_jobs from resume readers (#1329)

Felix-Ayushff90ebddbec5
diff --git a/packages/core/src/repowise/core/pipeline/checkpoint.py b/packages/core/src/repowise/core/pipeline/checkpoint.py
index 8236fd207..32bdda3cf 100644
--- a/packages/core/src/repowise/core/pipeline/checkpoint.py
+++ b/packages/core/src/repowise/core/pipeline/checkpoint.py
@@ -66,8 +66,10 @@ async def find_completed_phases(
"""
from repowise.core.persistence._interfaces.job_store import JobState
- jobs = await job_store.list_jobs(repository_id=repository_id)
- return {j.phase for j in jobs if j.state == JobState.COMPLETED}
+ jobs = await job_store.list_jobs(
+ repository_id=repository_id, state=JobState.COMPLETED
+ )
+ return {j.phase for j in jobs}
class PhaseCheckpointer:
diff --git a/packages/core/src/repowise/core/pipeline/resume/ledger.py b/packages/core/src/repowise/core/pipeline/resume/ledger.py
index a8d6c6630..51af83695 100644
--- a/packages/core/src/repowise/core/pipeline/resume/ledger.py
+++ b/packages/core/src/repowise/core/pipeline/resume/ledger.py
@@ -45,14 +45,14 @@ class ResumeLedger:
try:
async with get_session(self._sf) as session:
- jobs = await _store(session).list_jobs(repository_id=self._repo_id)
+ jobs = await _store(session).list_jobs(
+ repository_id=self._repo_id, state=JobState.COMPLETED
+ )
except Exception as exc:
logger.debug("resume_ledger_read_failed", error=str(exc))
return set()
done: set[ResumePhase] = set()
for j in jobs:
- if j.state != JobState.COMPLETED:
- continue
try:
done.add(ResumePhase(j.phase))
except ValueError:
diff --git a/tests/unit/persistence/test_interfaces_contract.py b/tests/unit/persistence/test_interfaces_contract.py
index 8448df852..003f27d94 100644
--- a/tests/unit/persistence/test_interfaces_contract.py
+++ b/tests/unit/persistence/test_interfaces_contract.py
@@ -210,3 +210,23 @@ async def test_job_store_find_resumable_filters_by_state(job_store):
@pytest.mark.asyncio
async def test_job_store_get_unknown_returns_none(job_store):
assert await job_store.get_job("does-not-exist") is None
+
+
+async def test_find_completed_phases_survives_many_non_completed_jobs(job_store):
+ """Completed phases must be found even when many newer non-completed jobs exist."""
+ from repowise.core.pipeline.checkpoint import find_completed_phases
+
+ repo_id = job_store._test_repo_id # type: ignore[attr-defined]
+ completed_phases = {f"done-{i}" for i in range(3)}
+ for phase in completed_phases:
+ job = await job_store.create_job(repository_id=repo_id, phase=phase)
+ await job_store.update_state(job.id, JobState.COMPLETED)
+
+ # Crowd the store with newer running jobs (beyond the default list_jobs limit).
+ for i in range(105):
+ job = await job_store.create_job(repository_id=repo_id, phase=f"running-{i}")
+ await job_store.update_state(job.id, JobState.RUNNING)
+
+ done = await find_completed_phases(job_store, repository_id=repo_id)
+ assert done == completed_phases
diff --git a/tests/unit/pipeline/test_checkpoint.py b/tests/unit/pipeline/test_checkpoint.py
index 0d7d88f78..063bba314 100644
--- a/tests/unit/pipeline/test_checkpoint.py
+++ b/tests/unit/pipeline/test_checkpoint.py
@@ -53,6 +53,7 @@ class FakeJobStore:
j
for j in self.jobs.values()
if (repository_id is None or j.repository_id == repository_id)
+ and (state is None or j.state == state)
]