Skip to content

The agent that turns websites into APIs!

fix: address greptile comments

kalil032122fce783a84a
diff --git a/src/reverse_api/browser.py b/src/reverse_api/browser.py
index d297950..84b745c 100644
--- a/src/reverse_api/browser.py
+++ b/src/reverse_api/browser.py
@@ -248,7 +248,7 @@ class ManualBrowser:
for (let i = 0; i < 3 && current; i++) {
if (current.dataset && current.dataset.testid) {
const path = i === 0 ? '' : ' ' + getPathFromAncestor(current, element);
- return '[data-testid="' + current.dataset.testid + '"]' + path;
+ return '[data-testid="' + current.dataset.testid.replace(/"/g, '\\"') + '"]' + path;
}
current = current.parentElement;
}
@@ -276,12 +276,12 @@ class ManualBrowser:
// Priority 4: name attribute
if (element.name) {
- return '[name="' + element.name + '"]';
+ return '[name="' + element.name.replace(/"/g, '\\"') + '"]';
}
// Priority 5: aria-label
if (element.getAttribute && element.getAttribute('aria-label')) {
- return '[aria-label="' + element.getAttribute('aria-label') + '"]';
+ return '[aria-label="' + element.getAttribute('aria-label').replace(/"/g, '\\"') + '"]';
}
// Priority 6: role + text for buttons
@@ -340,8 +340,8 @@ class ManualBrowser:
const el = e.target;
let selector = '';
if (el.id && el.id.length < 20) selector = '#' + el.id;
- else if (el.name) selector = '[name="' + el.name + '"]';
- else if (el.placeholder) selector = '[placeholder="' + el.placeholder + '"]';
+ else if (el.name) selector = '[name="' + el.name.replace(/"/g, '\\"') + '"]';
+ else if (el.placeholder) selector = '[placeholder="' + el.placeholder.replace(/"/g, '\\"') + '"]';
else selector = el.tagName.toLowerCase();
const action = {type: 'fill', selector: selector, value: el.value, timestamp: Date.now()};
@@ -355,7 +355,7 @@ class ManualBrowser:
const el = e.target;
let selector = '';
if (el.id && el.id.length < 20) selector = '#' + el.id;
- else if (el.name) selector = '[name="' + el.name + '"]';
+ else if (el.name) selector = '[name="' + el.name.replace(/"/g, '\\"') + '"]';
else selector = el.tagName.toLowerCase();
const action = {type: 'press', selector: selector, value: 'Enter', timestamp: Date.now()};
diff --git a/src/reverse_api/collector.py b/src/reverse_api/collector.py
index 21c52e8..2bcb959 100644
--- a/src/reverse_api/collector.py
+++ b/src/reverse_api/collector.py
@@ -281,8 +281,8 @@ When complete, briefly summarize what was collected.
writer = csv.DictWriter(f, fieldnames=fieldnames)
writer.writeheader()
for item in items:
- # Convert non-string values to strings
- row = {k: str(v) if v is not None else "" for k, v in item.items()}
+ # Convert non-string values to strings, filter out keys not in fieldnames
+ row = {k: str(v) if v is not None else "" for k, v in item.items() if k in fieldnames}
writer.writerow(row)
def _export_readme(self, readme_path: Path, items: list[dict[str, Any]], sources: set[str]) -> None:
diff --git a/src/reverse_api/playwright_codegen.py b/src/reverse_api/playwright_codegen.py
index 7e547bc..e9d0abf 100644
--- a/src/reverse_api/playwright_codegen.py
+++ b/src/reverse_api/playwright_codegen.py
@@ -91,14 +91,14 @@ class PlaywrightCodeGenerator:
last_nav_base = self._get_base_url(self.start_url) if self.start_url else None
for action in self.actions:
- if action.type == "click":
+ if action.type == "click" and action.selector:
lines.append(f" page.click({json.dumps(action.selector)})")
- elif action.type == "fill" and action.value is not None:
+ elif action.type == "fill" and action.selector and action.value is not None:
# Use json.dumps to safely escape newlines, quotes, and backslashes
lines.append(f" page.fill({json.dumps(action.selector)}, {json.dumps(action.value)})")
- elif action.type == "press":
+ elif action.type == "press" and action.selector:
lines.append(f" page.press({json.dumps(action.selector)}, {json.dumps(action.value)})")
elif action.type == "navigate":