🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(cli-core): honor ttl=0 as immediate expiry in JsonMemoryBackend
Arpit Tagade094258c4dfb8
diff --git a/tests/json-memory-expired-key-reuse.test.mjs b/tests/json-memory-expired-key-reuse.test.mjsindex 999271bb48..a30207ac86 100644--- a/tests/json-memory-expired-key-reuse.test.mjs+++ b/tests/json-memory-expired-key-reuse.test.mjs@@ -4,14 +4,32 @@ import { mkdtempSync, rmSync } from 'node:fs';import { tmpdir } from 'node:os';import { join } from 'node:path';import { JsonMemoryBackend } from '../v3/@claude-flow/cli-core/src/memory/json-backend.ts';-test('expired keys can be reused without a preceding read or upsert',async()=>{- const dir=mkdtempSync(join(tmpdir(),'memory-ttl-'));const backend=new JsonMemoryBackend({path:join(dir,'memory.json')});const now=Date.now;- try{- await backend.store('key','old',{ttl:1});- const stored=await backend.list();const boundary=new Date(stored[0].storedAt).getTime()+1000;- Date.now=()=>boundary;- assert.deepEqual(await backend.list(),[]);- await backend.store('key','new');assert.equal((await backend.retrieve('key')).value,'new');- await assert.rejects(backend.store('key','duplicate'),/UNIQUE/);- }finally{Date.now=now;rmSync(dir,{recursive:true,force:true});}++test('expired keys can be reused without a preceding read or upsert', async () => {+ const dir = mkdtempSync(join(tmpdir(), 'memory-ttl-')); const backend = new JsonMemoryBackend({ path: join(dir, 'memory.json') }); const now = Date.now;+ try {+ await backend.store('key', 'old', { ttl: 1 });+ const stored = await backend.list(); const boundary = new Date(stored[0].storedAt).getTime() + 1000;+ Date.now = () => boundary;+ assert.deepEqual(await backend.list(), []);+ await backend.store('key', 'new'); assert.equal((await backend.retrieve('key')).value, 'new');+ await assert.rejects(backend.store('key', 'duplicate'), /UNIQUE/);+ } finally { Date.now = now; rmSync(dir, { recursive: true, force: true }); }+});++test('entry stored with ttl: 0 is immediately treated as expired on next read while entry with no ttl is not', async () => {+ const dir = mkdtempSync(join(tmpdir(), 'memory-ttl-zero-')); const backend = new JsonMemoryBackend({ path: join(dir, 'memory.json') });+ try {+ await backend.store('expires-immediately', 'val1', { ttl: 0 });+ await backend.store('lives-forever', 'val2');++ assert.equal(await backend.retrieve('expires-immediately'), null);+ const retained = await backend.retrieve('lives-forever');+ assert.notEqual(retained, null);+ assert.equal(retained.value, 'val2');++ const listed = await backend.list();+ assert.equal(listed.length, 1);+ assert.equal(listed[0].key, 'lives-forever');+ } finally { rmSync(dir, { recursive: true, force: true }); }});diff --git a/v3/@claude-flow/cli-core/__tests__/json-backend.test.ts b/v3/@claude-flow/cli-core/__tests__/json-backend.test.tsnew file mode 100644index 0000000000..d13d942929--- /dev/null+++ b/v3/@claude-flow/cli-core/__tests__/json-backend.test.ts@@ -0,0 +1,33 @@+import { afterEach, beforeEach, describe, expect, it } from 'vitest';+import { mkdtempSync, rmSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { JsonMemoryBackend } from '../src/memory/json-backend.js';++describe('JsonMemoryBackend TTL behavior', () => {+ let dir: string;+ let backend: JsonMemoryBackend;++ beforeEach(() => {+ dir = mkdtempSync(join(tmpdir(), 'json-backend-ttl-'));+ backend = new JsonMemoryBackend({ path: join(dir, 'memory.json') });+ });++ afterEach(() => {+ rmSync(dir, { recursive: true, force: true });+ });++ it('immediately treats an entry stored with ttl: 0 as expired on read while entry with no ttl is not', async () => {+ await backend.store('expires-immediately', 'val1', { ttl: 0 });+ await backend.store('lives-forever', 'val2');++ expect(await backend.retrieve('expires-immediately')).toBeNull();+ const retained = await backend.retrieve('lives-forever');+ expect(retained).not.toBeNull();+ expect(retained?.value).toBe('val2');++ const listed = await backend.list();+ expect(listed).toHaveLength(1);+ expect(listed[0].key).toBe('lives-forever');+ });+});diff --git a/v3/@claude-flow/cli-core/src/memory/json-backend.ts b/v3/@claude-flow/cli-core/src/memory/json-backend.tsindex bff93ee16a..5ad2c3601e 100644--- a/v3/@claude-flow/cli-core/src/memory/json-backend.ts+++ b/v3/@claude-flow/cli-core/src/memory/json-backend.ts@@ -98,7 +98,7 @@ export class JsonMemoryBackend implements MemoryBackend {}private isExpired(entry: MemoryEntry): boolean {- if (!entry.ttlSeconds) return false;+ if (entry.ttlSeconds === undefined) return false;const expiresAt = new Date(entry.storedAt).getTime() + entry.ttlSeconds * 1000;return Date.now() >= expiresAt;}