Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

fix(memory): create the AgentDB directory before the bridge opens it (#4132)

martinvlad114c97a32f0c
diff --git a/v3/@claude-flow/cli/__tests__/memory-bridge-creates-db-dir-4132.test.ts b/v3/@claude-flow/cli/__tests__/memory-bridge-creates-db-dir-4132.test.ts
new file mode 100644
index 0000000000..01c6f262e4
--- /dev/null
+++ b/v3/@claude-flow/cli/__tests__/memory-bridge-creates-db-dir-4132.test.ts
@@ -0,0 +1,48 @@
+/**
+ * #4132: in a project without `.swarm/` (any fresh git worktree) the bridge
+ * opened AgentDB at `<cwd>/.swarm/agentdb-memory.db` without creating the
+ * directory. better-sqlite3 refuses a missing parent, AgentDB was marked
+ * unavailable, the degraded registry was cached, and hierarchical memory ran
+ * on the volatile fallback while every store reported success.
+ */
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { existsSync, mkdtempSync, realpathSync, rmSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { dirname, join } from 'node:path';
+
+class DirectoryCheckingRegistry {
+ // Mirrors better-sqlite3: opening a file in a missing directory fails.
+ async initialize(options: { dbPath: string }) {
+ if (!existsSync(dirname(options.dbPath))) throw new Error('Cannot open database because the directory does not exist');
+ }
+ get() { return null; }
+ getAgentDB() { return null; }
+ async shutdown() {}
+}
+
+vi.mock('../src/memory/intelligence.js', () => ({
+ initializeIntelligence: vi.fn(async () => ({ reasoningBankEnabled: false, sonaEnabled: false })),
+}));
+
+const bridge = await import('../src/memory/memory-bridge.js');
+
+let root: string;
+beforeEach(() => {
+ root = realpathSync(mkdtempSync(join(tmpdir(), 'ruflo-bridge-4132-')));
+ bridge._resetRegistryCacheForTest();
+ bridge.__setMemoryBridgeRegistryFactoryForTests(() => new DirectoryCheckingRegistry());
+});
+afterEach(async () => {
+ await bridge.shutdownBridge();
+ rmSync(root, { recursive: true, force: true });
+});
+
+describe('#4132 the bridge creates the AgentDB directory before opening it', () => {
+ it('opens a database whose .swarm directory does not exist yet', async () => {
+ const db = join(root, 'fresh-worktree', '.swarm', 'agentdb-memory.db');
+ expect(existsSync(dirname(db))).toBe(false);
+ expect(await bridge.getControllerRegistry(db)).not.toBeNull();
+ expect(bridge.getBridgeFailureReason(db)).toBeNull();
+ expect(existsSync(dirname(db))).toBe(true);
+ });
+});
diff --git a/v3/@claude-flow/cli/src/memory/memory-bridge.ts b/v3/@claude-flow/cli/src/memory/memory-bridge.ts
index 3921ad2476..b3e80334e9 100644
--- a/v3/@claude-flow/cli/src/memory/memory-bridge.ts
+++ b/v3/@claude-flow/cli/src/memory/memory-bridge.ts
@@ -23,7 +23,7 @@ import { resolveAgentdbBetterSqlite3 } from './shared-sqlite.js';
import { encodeEmbeddingQ8, MAX_LIST_EMBEDDINGS } from './embedding-q8.js';
import * as path from 'path';
import * as crypto from 'crypto';
-import { realpathSync } from 'node:fs';
+import { mkdirSync, realpathSync } from 'node:fs';
import { createRequire } from 'node:module';
import { AsyncLocalStorage } from 'node:async_hooks';
import { validateFeedbackPatterns } from './feedback-patterns.js';
@@ -270,6 +270,12 @@ async function getRegistry(dbPath?: string): Promise<any | null> {
origLog.apply(console, args);
};
+ // #4132: better-sqlite3 cannot create a missing parent directory. In a
+ // fresh checkout or worktree `.swarm/` does not exist yet, so AgentDB
+ // failed to open, the degraded registry was cached for the server's
+ // lifetime and hierarchical memory silently ran volatile.
+ if (resolvedPath !== ':memory:') mkdirSync(path.dirname(resolvedPath), { recursive: true });
+
try {
await (registry as any).initialize({
// #2786: use agentdb-memory.db (plaintext) so native better-sqlite3 doesn't hit the encrypted memory.db.