🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(auth): honor --no-browser for auth login (#4388)
nk-batman2111e35e39c18e
diff --git a/v3/@claude-flow/cli/__tests__/auth-login-no-browser.test.ts b/v3/@claude-flow/cli/__tests__/auth-login-no-browser.test.tsnew file mode 100644index 0000000000..f466e0f451--- /dev/null+++ b/v3/@claude-flow/cli/__tests__/auth-login-no-browser.test.ts@@ -0,0 +1,66 @@+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';+import { mkdtempSync, rmSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';++const mocks = vi.hoisted(() => {+ const login = async () => ({ tokens: { access_token: 'access', token_type: 'Bearer', expires_in: 3600 }, method: 'pkce' as const });+ return { browserLogin: vi.fn(login), manualLogin: vi.fn(login) };+});++vi.mock('../src/auth/security-bridge.js', () => ({+ loadSecurityOAuth: vi.fn(), SecurityPackageMissingError: class extends Error {},+}));+vi.mock('../src/output.js', () => ({+ output: { writeln: vi.fn(), printSuccess: vi.fn(), printError: vi.fn() },+}));+vi.mock('../src/funnel/index.js', () => ({+ // An interactive terminal, so login is not refused.+ isInteractive: () => true,+ isCI: () => false,+ hasConsent: vi.fn(), recordConsent: vi.fn(), revokeConsent: vi.fn(),+}));+vi.mock('../src/auth/client.js', async (importOriginal) => ({+ ...(await importOriginal<typeof import('../src/auth/client.js')>()),+ browserLogin: mocks.browserLogin,+ manualLogin: mocks.manualLogin,+ // No SSH or container hint, so only the flag can pick the manual flow.+ isProbablyHeadless: () => false,+}));++import { CommandParser } from '../src/parser.js';+import { authCommand } from '../src/commands/auth.js';++let stateDir: string;+beforeEach(() => {+ stateDir = mkdtempSync(join(tmpdir(), 'ruflo-auth-no-browser-'));+ process.env.RUFLO_STATE_DIR = stateDir;+});+afterEach(() => {+ vi.clearAllMocks();+ delete process.env.RUFLO_STATE_DIR;+ rmSync(stateDir, { recursive: true, force: true });+});++async function runLogin(flags: string[]) {+ const parser = new CommandParser();+ parser.registerCommand(authCommand);+ const parsed = parser.parse(['auth', 'login', ...flags]);+ const login = authCommand.subcommands!.find((command) => command.name === 'login')!;+ const result = await login.action!({ args: [], flags: parsed.flags, cwd: stateDir, interactive: true });+ expect(result).toMatchObject({ success: true });+}++describe('auth login --no-browser through the real command parser', () => {+ it('uses the manual copy-paste flow', async () => {+ await runLogin(['--no-browser']);+ expect(mocks.manualLogin).toHaveBeenCalledTimes(1);+ expect(mocks.browserLogin).not.toHaveBeenCalled();+ });++ it('still opens the browser without the flag', async () => {+ await runLogin([]);+ expect(mocks.browserLogin).toHaveBeenCalledTimes(1);+ expect(mocks.manualLogin).not.toHaveBeenCalled();+ });+});diff --git a/v3/@claude-flow/cli/src/commands/auth.ts b/v3/@claude-flow/cli/src/commands/auth.tsindex 67962445c7..08c0c2163a 100644--- a/v3/@claude-flow/cli/src/commands/auth.ts+++ b/v3/@claude-flow/cli/src/commands/auth.ts@@ -93,8 +93,9 @@ const loginCommand: Command = {const profileName = typeof ctx.flags.profile === 'string' ? ctx.flags.profile : DEFAULT_PROFILE;// Parser camelCases kebab-case flag names — read via tokenStdin/noBrowser,// not ['token-stdin']/['no-browser'] (see doctor.ts's fixHandles comment).+ // `--no-browser` itself arrives as `browser: false`.const tokenStdin = Boolean(ctx.flags.tokenStdin ?? ctx.flags['token-stdin']);- const noBrowser = Boolean(ctx.flags.noBrowser ?? ctx.flags['no-browser']);+ const noBrowser = Boolean(ctx.flags.noBrowser || ctx.flags['no-browser'] || ctx.flags.browser === false);const refusal = refuseNonInteractive(tokenStdin);if (refusal) return refusal;