π The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
feat(ci): #2132 β cross-platform audit for plugin hooks.json commands
ruv19984c20647c
diff --git a/.github/workflows/v3-ci.yml b/.github/workflows/v3-ci.ymlindex 5d6ed2e759..aa477655d0 100644--- a/.github/workflows/v3-ci.yml+++ b/.github/workflows/v3-ci.yml@@ -1530,6 +1530,20 @@ jobs:shell: bashrun: node scripts/audit-wrapper-dep-ranges.mjs+ - name: Run plugin-hooks cross-platform audit (#2132)+ # Catches /bin/bash literals, POSIX-only pipelines (jq, xargs, tr),+ # and .sh script invocations in plugin hooks.json files β patterns+ # that fail on native Windows (exit 126).+ #+ # KNOWN ISSUE: current main has unfixed violations from #2132 itself+ # (the underlying bug). Running with `continue-on-error: true` so the+ # audit reports but doesn't block PRs while the .shβ.cjs migration+ # lands. Flip to strict (remove continue-on-error) once #2132 is+ # closed β see commit log for the migration PR.+ shell: bash+ continue-on-error: true+ run: node scripts/audit-plugin-hooks-cross-platform.mjs+cli-npx-install-smoke:# Regression guard for ruvnet/ruflo#1147 and #2018 β both report:# $ npx @claude-flow/cli@latest β¦diff --git a/scripts/audit-plugin-hooks-cross-platform.mjs b/scripts/audit-plugin-hooks-cross-platform.mjsnew file mode 100644index 0000000000..8f25f11f04--- /dev/null+++ b/scripts/audit-plugin-hooks-cross-platform.mjs@@ -0,0 +1,136 @@+#!/usr/bin/env node+/**+ * Static guard for ruvnet/ruflo#2132 β plugin `hooks.json` commands must be+ * cross-platform (work on Windows without WSL / Git Bash).+ *+ * The reporter ran the plugin hooks on native Windows and every `PostToolUse`+ * fired exit code 126 ("cannot execute binary file") because the commands+ * hardcoded:+ *+ * - `/bin/bash -c '...'` β no such path on Windows+ * - POSIX-only pipelines: `jq`, `xargs -0`, `tr '\n' '\0'`, `sed`, `awk`+ * - `.sh` scripts with `#!/usr/bin/env bash` shebang+ *+ * The fix pattern (used by `.claude/settings.json` and `hook-handler.cjs` β+ * which already works on Windows) is to invoke `node` directly with a `.cjs`+ * or `.mjs` script:+ *+ * "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/helpers/hook-handler.cjs\" post-edit"+ *+ * This audit walks every plugin `hooks.json` in the tree (skipping+ * node_modules and worktrees) and fails if it finds any of the broken+ * patterns. Wired into v3-ci.yml as `plugin-hooks-cross-platform-audit`.+ *+ * False-positive avoidance: only the `command` field of `hooks[].hooks[]`+ * entries is scanned. Comments, descriptions, and the top-level `_note`+ * field are ignored.+ */++import { readFileSync, readdirSync, statSync } from 'node:fs';+import { fileURLToPath } from 'node:url';+import { dirname, join, relative, resolve } from 'node:path';++const __dirname = dirname(fileURLToPath(import.meta.url));+const REPO_ROOT = resolve(__dirname, '..');++// Directories to skip when walking+const SKIP_DIRS = new Set(['node_modules', '.git', 'dist', 'build', 'coverage']);++// Skip everything under .claude/worktrees β those are scratch copies+function isSkippedPath(absPath) {+ const rel = relative(REPO_ROOT, absPath);+ if (rel.startsWith('.claude/worktrees/')) return true;+ return false;+}++function* walkForHooksJson(dir) {+ for (const entry of readdirSync(dir)) {+ if (SKIP_DIRS.has(entry)) continue;+ const full = join(dir, entry);+ if (isSkippedPath(full)) continue;+ let st;+ try { st = statSync(full); } catch { continue; }+ if (st.isDirectory()) {+ yield* walkForHooksJson(full);+ } else if (st.isFile() && entry === 'hooks.json') {+ yield full;+ }+ }+}++// Patterns that break native Windows. Each rule has a label + a regex+// applied to the `command` string (not the surrounding JSON).+const BAD_PATTERNS = [+ { label: '/bin/bash literal', regex: /\/bin\/bash\b/, hint: 'replace with `node "..../hook-handler.cjs" <subcommand>` β same pattern as .claude/settings.json' },+ { label: '/bin/sh literal', regex: /\/bin\/sh\b/, hint: 'replace with `node ...` like .claude/settings.json' },+ { label: 'pipe to jq', regex: /\|\s*jq\b/, hint: 'parse JSON inside a node helper (the cli-side hook script can read stdin via process.stdin)' },+ { label: 'xargs -0', regex: /\bxargs\s+-0\b/, hint: 'do argument passing inside the node helper, not via shell' },+ { label: 'tr to NUL byte', regex: /\btr\s+['"]\\n['"]\s+['"]\\0['"]/, hint: 'unnecessary if you stop piping through xargs' },+ { label: '.sh script in cmd', regex: /\.sh\b/, hint: 'replace .sh shim with a .cjs helper that has no shebang requirement' },+];++let violations = [];+const scanned = [];++for (const file of walkForHooksJson(REPO_ROOT)) {+ const text = readFileSync(file, 'utf8');+ let json;+ try { json = JSON.parse(text); } catch (err) {+ violations.push({ file: relative(REPO_ROOT, file), line: 0, label: 'invalid JSON', cmd: err.message, hint: '' });+ continue;+ }++ const events = Array.isArray(json?.hooks) ? json.hooks : Object.values(json?.hooks ?? {}).flat();+ const flat = [];+ // hooks can be either:+ // - { hooks: [ { matcher, hooks: [ { type, command } ] }, ... ] } (Claude Code 1.x)+ // - { hooks: { PostToolUse: [ ... ] } } (alt shape)+ for (const entry of events) {+ if (!entry) continue;+ if (Array.isArray(entry.hooks)) {+ for (const h of entry.hooks) {+ if (h?.command) flat.push({ matcher: entry.matcher ?? '', command: h.command });+ }+ } else if (entry.command) {+ flat.push({ matcher: '', command: entry.command });+ }+ }++ scanned.push({ file: relative(REPO_ROOT, file), entries: flat.length });++ for (const { matcher, command } of flat) {+ for (const { label, regex, hint } of BAD_PATTERNS) {+ if (regex.test(command)) {+ // Find approximate line number by searching the raw text+ const idx = text.indexOf(command);+ const line = idx < 0 ? 0 : text.slice(0, idx).split('\n').length;+ violations.push({+ file: relative(REPO_ROOT, file),+ line,+ matcher: matcher || '(no matcher)',+ label,+ cmd: command.length > 120 ? command.slice(0, 117) + '...' : command,+ hint,+ });+ }+ }+ }+}++console.log(`plugin-hooks cross-platform audit β scanned ${scanned.length} file(s), ${scanned.reduce((a, b) => a + b.entries, 0)} hook command(s)`);+for (const s of scanned) console.log(` ${s.file}: ${s.entries} command(s)`);++if (violations.length === 0) {+ console.log(' ok: all plugin hook commands are cross-platform (no /bin/bash, no POSIX pipelines, no .sh scripts)');+ process.exit(0);+}++console.error(`\n${violations.length} violation(s):`);+for (const v of violations) {+ console.error(` β ${v.file}:${v.line} [${v.matcher}] ${v.label}`);+ console.error(` cmd: ${v.cmd}`);+ console.error(` fix: ${v.hint}`);+}+console.error('\nReference: ruvnet/ruflo#2132 (plugin hooks broken on Windows).');+console.error('Pattern that works cross-platform: .claude/settings.json + .claude/helpers/hook-handler.cjs (node, no bash).');+process.exit(1);