Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

fix(memory): allow expired JSON keys to be reused

Rudy Celekli35c87de12157
diff --git a/tests/json-memory-expired-key-reuse.test.mjs b/tests/json-memory-expired-key-reuse.test.mjs
new file mode 100644
index 0000000000..5d0a512eb5
--- /dev/null
+++ b/tests/json-memory-expired-key-reuse.test.mjs
@@ -0,0 +1,17 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { mkdtempSync, rmSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { JsonMemoryBackend } from '../v3/@claude-flow/cli-core/src/memory/json-backend.ts';
+test('expired keys can be reused without a preceding read or upsert',async()=>{
+ const dir=mkdtempSync(join(tmpdir(),'memory-ttl-'));const backend=new JsonMemoryBackend({path:join(dir,'memory.json')});const now=Date.now;
+ try{
+ await backend.store('key','old',{ttl:1});
+ const stored=await backend.list();const boundary=new Date(stored[0].storedAt).getTime()+1000;
+ Date.now=()=>boundary;
+ assert.deepEqual(await backend.list(),[]);
+ await backend.store('key','new');assert.equal((await backend.retrieve('key')).value,'new');
+ await assert.rejects(backend.store('key','duplicate'),/UNIQUE/);
+ }finally{Date.now=now;rmSync(dir,{recursive:true,force:true});}
+});
diff --git a/v3/@claude-flow/cli-core/src/memory/json-backend.ts b/v3/@claude-flow/cli-core/src/memory/json-backend.ts
index 50fe873ec2..c4001c6e65 100644
--- a/v3/@claude-flow/cli-core/src/memory/json-backend.ts
+++ b/v3/@claude-flow/cli-core/src/memory/json-backend.ts
@@ -95,14 +95,14 @@ export class JsonMemoryBackend implements MemoryBackend {
private isExpired(entry: MemoryEntry): boolean {
if (!entry.ttlSeconds) return false;
const expiresAt = new Date(entry.storedAt).getTime() + entry.ttlSeconds * 1000;
- return Date.now() > expiresAt;
+ return Date.now() >= expiresAt;
}
async store(key: string, value: unknown, opts?: StoreOptions): Promise<void> {
const namespace = opts?.namespace || 'default';
const ck = compositeKey(namespace, key);
const state = this.load();
- if (state.entries[ck] && !opts?.upsert) {
+ if (state.entries[ck] && !this.isExpired(state.entries[ck]) && !opts?.upsert) {
throw new Error(`memory: UNIQUE constraint failed for namespace='${namespace}' key='${key}' (pass --upsert to overwrite)`);
}
state.entries[ck] = {