🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(memory): reject unrescued AgentDB mock embeddings
Rudy Celekli36868e274b7e
diff --git a/v3/@claude-flow/cli/__tests__/issue-3108-embedding-space.test.ts b/v3/@claude-flow/cli/__tests__/issue-3108-embedding-space.test.tsnew file mode 100644index 0000000000..1aebc33f07--- /dev/null+++ b/v3/@claude-flow/cli/__tests__/issue-3108-embedding-space.test.ts@@ -0,0 +1,91 @@+/** A degraded AgentDB embedder can emit 384-d mock vectors until rescue finishes. */+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';+import Database from 'better-sqlite3';+import { mkdtempSync, rmSync } from 'node:fs';+import { join } from 'node:path';+import { tmpdir } from 'node:os';++const local = vi.hoisted(() => ({+ release: null as (() => void) | null,+ gate: Promise.resolve() as Promise<void>,+ vector: Array.from({ length: 384 }, (_, i) => i % 2),+}));++vi.mock('@huggingface/transformers', () => ({ pipeline: undefined }));+vi.mock('@xenova/transformers', () => ({ pipeline: undefined }));+vi.mock('agentic-flow/reasoningbank', () => ({ computeEmbedding: undefined }));+vi.mock('agentic-flow', () => ({ embeddings: undefined }));+vi.mock('ruvector', () => ({+ initOnnxEmbedder: async () => { await local.gate; },+ getOptimizedOnnxEmbedder: () => ({ embed: async () => local.vector }),+}));++let root: string;+let db: Database.Database;++beforeEach(() => {+ delete process.env.CLAUDE_FLOW_DISABLE_BRIDGE;+ root = mkdtempSync(join(tmpdir(), 'ruflo-3108-'));+ db = new Database(join(root, 'memory.db'));+ local.gate = new Promise<void>(resolve => { local.release = resolve; });+});++afterEach(async () => {+ local.release?.();+ const bridge = await import('../src/memory/memory-bridge.js');+ bridge.__setMemoryBridgeRegistryForTests(null);+ db.close();+ rmSync(root, { recursive: true, force: true });+});++async function setup() {+ vi.resetModules();+ // Give the store path and the rescue a single loaded local-chain module.+ await import('../src/memory/memory-initializer.js');+ const bridge = await import('../src/memory/memory-bridge.js');+ let mockCalls = 0;+ const embedder = {+ pipeline: null,+ __ruvectorRescued: false,+ embed: async () => {+ mockCalls++;+ return new Float32Array(384).fill(0.25);+ },+ };+ bridge.__setMemoryBridgeRegistryForTests({+ getAgentDB: () => ({ database: db, embedder }),+ get: () => null,+ });+ return { bridge, embedder, getMockCalls: () => mockCalls };+}++describe('#3108 embedding-space integrity', () => {+ it('does not advertise an unrescued AgentDB mock vector as MiniLM', async () => {+ const { bridge, getMockCalls } = await setup();++ const result = await bridge.bridgeGenerateEmbedding('probe');+ const reportedModel = await bridge.bridgeLoadEmbeddingModel();++ expect(result).toBeNull();+ expect(reportedModel).toBeNull();+ expect(getMockCalls()).toBe(0);+ });++ it('does not store a mock vector while the local ONNX rescue is pending', async () => {+ const { bridge, getMockCalls } = await setup();+ const writing = bridge.bridgeStoreEntry({ key: 'episode', value: 'the cat sat on the mat' });++ // Keep the rescue pending long enough for the pre-fix fire-and-forget+ // path to use AgentDB's 384-d mock vector.+ await Promise.race([writing, new Promise(resolve => setTimeout(resolve, 100))]);+ local.release?.();+ const stored = await writing;++ expect(stored?.success).toBe(true);+ expect(stored?.rawEmbedding).toEqual(local.vector);+ const row = db.prepare('SELECT embedding FROM memory_entries WHERE key = ?').get('episode') as { embedding: string };+ expect(JSON.parse(row.embedding)).toEqual(local.vector);+ expect(getMockCalls()).toBe(0);+ });++});diff --git a/v3/@claude-flow/cli/src/memory/memory-bridge.ts b/v3/@claude-flow/cli/src/memory/memory-bridge.tsindex 948ef83b11..a1cdc102cb 100644--- a/v3/@claude-flow/cli/src/memory/memory-bridge.ts+++ b/v3/@claude-flow/cli/src/memory/memory-bridge.ts@@ -830,6 +830,17 @@ async function rescueAgentdbEmbedder(agentdb: { embedder?: { pipeline?: unknown;_embedderPatched = true;}+/** AgentDB uses a null pipeline while its transformer failed and it serves mock vectors. */+function isMockAgentdbEmbedder(embedder: {+ isMock?: boolean;+ backend?: string;+ pipeline?: unknown;+ __ruvectorRescued?: boolean;+} | null | undefined): boolean {+ return embedder?.isMock === true || embedder?.backend === 'mock'+ || (embedder?.pipeline === null && embedder.__ruvectorRescued !== true);+}+/*** #3325: embed text for a bridge row or query.*@@ -841,14 +852,16 @@ async function rescueAgentdbEmbedder(agentdb: { embedder?: { pipeline?: unknown;* were a bare `catch {}` that stored embedding=NULL and reported nothing.*/async function embedForBridge(- agentdb: { embedder?: { embed?: (t: string) => Promise<ArrayLike<number> | null | undefined>; isMock?: boolean; backend?: string } } | null | undefined,+ agentdb: { embedder?: { embed?: (t: string) => Promise<ArrayLike<number> | null | undefined>; isMock?: boolean; backend?: string; pipeline?: unknown; __ruvectorRescued?: boolean } } | null | undefined,text: string,): Promise<{ vector: number[]; model: string } | { vector: null; reason: string }> {let agentdbProblem: string;const embedder = agentdb?.embedder;// Same mock signal bridgeGenerateEmbedding honours (AUDIT #3): the rescue// tags a degraded embedder backend='mock' when it cannot replace it.- const agentdbIsMock = embedder?.isMock === true || embedder?.backend === 'mock';+ // The rescue launched by getDb() is fire-and-forget. Do not persist mock+ // vectors during that window just because they happen to be 384-dimension.+ const agentdbIsMock = isMockAgentdbEmbedder(embedder);if (agentdbIsMock) {agentdbProblem = 'agentdb embedder is serving mock vectors';} else if (embedder && typeof embedder.embed === 'function') {@@ -1740,7 +1753,7 @@ export async function bridgeGenerateEmbedding(try {const agentdb = registry.getAgentDB();const embedder = agentdb?.embedder;- if (!embedder) return null;+ if (!embedder || isMockAgentdbEmbedder(embedder)) return null;const emb = await embedder.embed(text);if (!emb) return null;@@ -1793,7 +1806,7 @@ export async function bridgeLoadEmbeddingModel(try {const agentdb = registry.getAgentDB();const embedder = agentdb?.embedder;- if (!embedder) return null;+ if (!embedder || isMockAgentdbEmbedder(embedder)) return null;// Verify embedder works by generating a test embeddingconst test = await embedder.embed('test');