π The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(init): read the parser's actual camelCase flag keys (#2952) (#2989)
rUv3d3f6e08cc32
diff --git a/v3/@claude-flow/cli/__tests__/init-kebab-flags-2952.test.ts b/v3/@claude-flow/cli/__tests__/init-kebab-flags-2952.test.tsnew file mode 100644index 0000000000..60e2770ce6--- /dev/null+++ b/v3/@claude-flow/cli/__tests__/init-kebab-flags-2952.test.ts@@ -0,0 +1,74 @@+/**+ * #2952: `init --all-agents`, `--skip-claude`, `--only-claude`, `--cloud-mcp`+ * were silent no-ops.+ *+ * Root cause: every long-flag write path in the parser goes through+ * `normalizeKey()` (parser.ts), which converts kebab-case to camelCase+ * before storing β `--all-agents` lands as `flags.allAgents`, never as the+ * literal `flags['all-agents']`. `initClaudeAction` (commands/init.ts) read+ * the literal kebab-case keys, so all four reads were always `undefined`.+ * Same bug class the code already fixed for `--no-global` (#2098A) five+ * lines above β that fix was never applied to these sibling flags.+ *+ * `--all-agents` is the most observable of the four: it switches the+ * installed agent set from the ~17-agent curated default to the full+ * ~89-agent catalog (ADR-128 Phase 3, `options.agents.all = true`). Black-box+ * against the real built CLI β same pattern as mcp-http-foreground-2984 β+ * because the bug is in how the parser's actual output key and the command's+ * read key disagree, which a unit test against either side alone wouldn't+ * catch.+ */+import { describe, it, expect } from 'vitest';+import { execFileSync } from 'child_process';+import { existsSync, mkdtempSync, readdirSync, rmSync } from 'fs';+import { fileURLToPath } from 'url';+import { join } from 'path';+import { tmpdir } from 'os';++const CLI_BIN = fileURLToPath(new URL('../bin/cli.js', import.meta.url));+const CLI_BUILT = existsSync(CLI_BIN);++function countAgentFiles(cwd: string): number {+ const dir = join(cwd, '.claude', 'agents');+ if (!existsSync(dir)) return 0;+ let count = 0;+ const walk = (d: string) => {+ for (const entry of readdirSync(d, { withFileTypes: true })) {+ const p = join(d, entry.name);+ if (entry.isDirectory()) walk(p);+ else if (entry.name.endsWith('.md')) count++;+ }+ };+ walk(dir);+ return count;+}++describe.skipIf(!CLI_BUILT)('#2952 init reads the parser\'s actual (camelCase) flag keys', () => {+ it('--all-agents installs strictly more agents than the curated default', () => {+ const defaultCwd = mkdtempSync(join(tmpdir(), 'ruflo-2952-default-'));+ const allAgentsCwd = mkdtempSync(join(tmpdir(), 'ruflo-2952-all-'));+ try {+ execFileSync(process.execPath, [CLI_BIN, 'init', '--force'], {+ cwd: defaultCwd,+ timeout: 30_000,+ stdio: 'pipe',+ });+ execFileSync(process.execPath, [CLI_BIN, 'init', '--force', '--all-agents'], {+ cwd: allAgentsCwd,+ timeout: 30_000,+ stdio: 'pipe',+ });++ const defaultCount = countAgentFiles(defaultCwd);+ const allAgentsCount = countAgentFiles(allAgentsCwd);++ // Pre-fix: `ctx.flags['all-agents']` was always undefined, so both+ // runs installed the same curated default set β this assertion is+ // exactly what the bug made false.+ expect(allAgentsCount).toBeGreaterThan(defaultCount);+ } finally {+ rmSync(defaultCwd, { recursive: true, force: true });+ rmSync(allAgentsCwd, { recursive: true, force: true });+ }+ }, 60_000);+});diff --git a/v3/@claude-flow/cli/src/commands/init.ts b/v3/@claude-flow/cli/src/commands/init.tsindex 6c736c8ef4..b5a9d58d0d 100644--- a/v3/@claude-flow/cli/src/commands/init.ts+++ b/v3/@claude-flow/cli/src/commands/init.ts@@ -552,8 +552,16 @@ const initClaudeAction = async (ctx: CommandContext): Promise<CommandResult> =>const force = ctx.flags.force as boolean;const minimal = ctx.flags.minimal as boolean;const full = ctx.flags.full as boolean;- const skipClaude = ctx.flags['skip-claude'] as boolean;- const onlyClaude = ctx.flags['only-claude'] as boolean;+ // #2952 β every long-flag write path in the parser goes through+ // normalizeKey() (parser.ts:399-402), which converts kebab-case to+ // camelCase before storing. `--skip-claude`/`--only-claude`/+ // `--all-agents`/`--cloud-mcp` land as `flags.skipClaude`/`flags.onlyClaude`/+ // `flags.allAgents`/`flags.cloudMcp` β there is no code path that ever+ // stores the literal kebab-case key. Reading `ctx.flags['skip-claude']`+ // etc. was always undefined, so all four flags were silent no-ops. Same+ // bug class as #2098A below, just never applied to these siblings.+ const skipClaude = ctx.flags.skipClaude as boolean;+ const onlyClaude = ctx.flags.onlyClaude as boolean;// #2098A β the parser handles `--no-foo` by stripping the prefix and// storing `flags.foo = false` (parser.ts:291-294), not by storing// `flags['no-foo'] = true`. So `--no-global` lands as@@ -561,8 +569,8 @@ const initClaudeAction = async (ctx: CommandContext): Promise<CommandResult> =>// was always undefined and silently no-op'd β every user with the flag// set still got `~/.claude/CLAUDE.md` modified. Read the real key.const noGlobal = ctx.flags['no-global'] === true || ctx.flags['global'] === false;- const allAgents = ctx.flags['all-agents'] as boolean;- const cloudMcp = ctx.flags['cloud-mcp'] as boolean;+ const allAgents = ctx.flags.allAgents as boolean;+ const cloudMcp = ctx.flags.cloudMcp as boolean;const cwd = ctx.cwd;// Check if already initialized