🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(mcp): remove stale discovery indexes when overriding tools
Rudy Celekli55e439d06328
diff --git a/v3/@claude-flow/mcp/__tests__/tool-override-index.test.ts b/v3/@claude-flow/mcp/__tests__/tool-override-index.test.tsnew file mode 100644index 0000000000..c789915291--- /dev/null+++ b/v3/@claude-flow/mcp/__tests__/tool-override-index.test.ts@@ -0,0 +1,53 @@+import { describe, expect, it } from 'vitest';+import { createToolRegistry } from '../src/tool-registry.js';+import type { ILogger, MCPTool } from '../src/types.js';++const logger: ILogger = { debug() {}, info() {}, warn() {}, error() {} };+const tool = (name: string, category?: string, tags?: string[]): MCPTool => ({+ name, category, tags, description: `Tool ${name}`, inputSchema: { type: 'object', properties: {} },+ handler: async () => category ?? 'unclassified',+});++describe('tool replacement updates discovery indexes', () => {+ it('removes former category and tags while preserving shared and unrelated members', async () => {+ const registry = createToolRegistry(logger);+ registry.register(tool('changed', 'old', ['former', 'shared']));+ registry.register(tool('peer', 'old', ['former', 'shared']));+ registry.register(tool('other', 'unrelated', ['separate']));+ expect(registry.register(tool('changed', 'new', ['current', 'shared']), { override: true })).toBe(true);+ expect(registry.getByCategory('old').map(t => t.name)).toEqual(['peer']);+ expect(registry.getByTag('former').map(t => t.name)).toEqual(['peer']);+ expect(registry.getByTag('shared').map(t => t.name).sort()).toEqual(['changed', 'peer']);+ expect(registry.search({ category: 'old', tags: ['current'] })).toEqual([]);+ expect(registry.search({ category: 'new', tags: ['current'] }).map(t => t.name)).toEqual(['changed']);+ expect(registry.getByCategory('unrelated').map(t => t.name)).toEqual(['other']);+ expect((await registry.execute('changed', {})).content).toEqual([{ type: 'text', text: 'new' }]);+ });++ it('removes empty category/tag buckets on repeated and unclassified replacements', () => {+ const registry = createToolRegistry(logger);+ registry.register(tool('changed', 'one', ['a']));+ registry.register(tool('changed', 'two', ['b']), { override: true });+ expect(registry.getCategories()).toEqual(['two']);+ expect(registry.getTags()).toEqual(['b']);+ registry.register(tool('changed'), { override: true });+ expect(registry.getCategories()).toEqual([]);+ expect(registry.getTags()).toEqual([]);+ expect(registry.getToolCount()).toBe(1);+ expect(registry.unregister('changed')).toBe(true);+ expect(registry.search({})).toEqual([]);+ expect(registry.getStats().totalCategories).toBe(0);+ expect(registry.getStats().totalTags).toBe(0);+ });++ it('leaves existing discovery intact when replacement is invalid or override is absent', () => {+ const registry = createToolRegistry(logger);+ registry.register(tool('changed', 'old', ['original']));+ expect(registry.register(tool('changed', 'new', ['next']))).toBe(false);+ expect(registry.register({ ...tool('changed', 'new', ['next']), description: '' }, { override: true })).toBe(false);+ expect(registry.getByCategory('old').map(t => t.name)).toEqual(['changed']);+ expect(registry.getByTag('original').map(t => t.name)).toEqual(['changed']);+ expect(registry.getCategories()).toEqual(['old']);+ expect(registry.getTags()).toEqual(['original']);+ });+});diff --git a/v3/@claude-flow/mcp/src/tool-registry.ts b/v3/@claude-flow/mcp/src/tool-registry.tsindex 4cf17100c5..69902ec9f8 100644--- a/v3/@claude-flow/mcp/src/tool-registry.ts+++ b/v3/@claude-flow/mcp/src/tool-registry.ts@@ -79,6 +79,9 @@ export class ToolRegistry extends EventEmitter {}}+ const previous = this.tools.get(tool.name);+ if (previous) this.removeFromIndexes(previous.tool);+const metadata: ToolMetadata = {tool,registeredAt: new Date(),@@ -150,29 +153,32 @@ export class ToolRegistry extends EventEmitter {return false;}- if (metadata.tool.category) {- const categoryTools = this.categoryIndex.get(metadata.tool.category);- categoryTools?.delete(name);+ this.removeFromIndexes(metadata.tool);+ this.tools.delete(name);+ this.logger.debug('Tool unregistered', { name });+ this.emit('tool:unregistered', name);++ return true;+ }++ private removeFromIndexes(tool: MCPTool): void {+ if (tool.category) {+ const categoryTools = this.categoryIndex.get(tool.category);+ categoryTools?.delete(tool.name);if (categoryTools?.size === 0) {- this.categoryIndex.delete(metadata.tool.category);+ this.categoryIndex.delete(tool.category);}}- if (metadata.tool.tags) {- for (const tag of metadata.tool.tags) {+ if (tool.tags) {+ for (const tag of tool.tags) {const tagTools = this.tagIndex.get(tag);- tagTools?.delete(name);+ tagTools?.delete(tool.name);if (tagTools?.size === 0) {this.tagIndex.delete(tag);}}}-- this.tools.delete(name);- this.logger.debug('Tool unregistered', { name });- this.emit('tool:unregistered', name);-- return true;}getTool(name: string): MCPTool | undefined {