Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

fix(daemon): a cloned project's config can no longer enable AI workers (#4509)

rUv5b3bcc78cd1b
diff --git a/v3/@claude-flow/cli/__tests__/daemon-ai-workers-consent-sec.test.ts b/v3/@claude-flow/cli/__tests__/daemon-ai-workers-consent-sec.test.ts
new file mode 100644
index 0000000000..23651752d3
--- /dev/null
+++ b/v3/@claude-flow/cli/__tests__/daemon-ai-workers-consent-sec.test.ts
@@ -0,0 +1,37 @@
+import { describe, it, expect, afterEach, vi } from 'vitest';
+import { mkdtempSync, mkdirSync, writeFileSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
+import { tmpdir } from 'node:os';
+import { WorkerDaemon } from '../src/services/worker-daemon.js';
+import { HEADLESS_WORKER_CONFIGS } from '../src/services/headless-worker-executor.js';
+
+const dirs: string[] = [];
+afterEach(() => { vi.unstubAllEnvs(); for (const d of dirs.splice(0)) rmSync(d, { recursive: true, force: true }); });
+const tmp = (): string => { const d = mkdtempSync(join(tmpdir(), 'ruflo-aiw-')); dirs.push(d); return d; };
+const aiOn = (dir: string): boolean => new WorkerDaemon(dir, {}).getStatus().config.aiWorkersEnabled;
+const cfg = { daemon: { aiWorkers: { enabled: true } } };
+
+describe('AI workers need consent the repository cannot give', () => {
+ it('ignores aiWorkers.enabled in a cloned project config (claude-flow.config.json and .claude-flow/config.json)', () => {
+ vi.stubEnv('HOME', tmp()); vi.stubEnv('USERPROFILE', tmp()); vi.stubEnv('RUFLO_DAEMON_AI_WORKERS', '');
+ const dir = tmp(); mkdirSync(join(dir, '.claude-flow'));
+ writeFileSync(join(dir, 'claude-flow.config.json'), JSON.stringify(cfg));
+ writeFileSync(join(dir, '.claude-flow', 'config.json'), JSON.stringify(cfg));
+ expect(aiOn(dir)).toBe(false);
+ });
+
+ it('still honours the explicit option, the env var and the user-level config', () => {
+ const home = tmp(); mkdirSync(join(home, '.claude-flow'));
+ vi.stubEnv('HOME', home); vi.stubEnv('USERPROFILE', home); vi.stubEnv('RUFLO_DAEMON_AI_WORKERS', '');
+ expect(new WorkerDaemon(tmp(), { aiWorkersEnabled: true }).getStatus().config.aiWorkersEnabled).toBe(true);
+ vi.stubEnv('RUFLO_DAEMON_AI_WORKERS', '1');
+ expect(aiOn(tmp())).toBe(true);
+ vi.stubEnv('RUFLO_DAEMON_AI_WORKERS', '');
+ writeFileSync(join(home, '.claude-flow', 'config.json'), JSON.stringify(cfg));
+ expect(aiOn(tmp())).toBe(true);
+ });
+
+ it('never hands .env files to a worker prompt', () => {
+ for (const c of Object.values(HEADLESS_WORKER_CONFIGS)) expect(c.contextPatterns ?? []).not.toContainEqual(expect.stringContaining('.env'));
+ });
+});
diff --git a/v3/@claude-flow/cli/__tests__/daemon-ai-workers-optin-2661.test.ts b/v3/@claude-flow/cli/__tests__/daemon-ai-workers-optin-2661.test.ts
index b311de544a..f19c071834 100644
--- a/v3/@claude-flow/cli/__tests__/daemon-ai-workers-optin-2661.test.ts
+++ b/v3/@claude-flow/cli/__tests__/daemon-ai-workers-optin-2661.test.ts
@@ -6,11 +6,12 @@
*
* Consent gates (any one):
* - `daemon start --headless` β†’ constructor { aiWorkersEnabled: true }
- * - `daemon.aiWorkers.enabled: true` β†’ .claude-flow/config.json
+ * - `daemon.aiWorkers.enabled: true` β†’ the USER-level ~/.claude-flow/config.json only
+ * (a project file is repo content and can only say `false`)
* - `RUFLO_DAEMON_AI_WORKERS=1` β†’ environment
*/
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import { WorkerDaemon } from '../src/services/worker-daemon.js';
import { mkdtempSync, rmSync, mkdirSync, writeFileSync } from 'fs';
import { join } from 'path';
@@ -26,6 +27,7 @@ describe('#2661 β€” AI workers are opt-in', () => {
});
afterEach(() => {
+ vi.unstubAllEnvs();
delete process.env.RUFLO_DAEMON_AI_WORKERS;
rmSync(tempDir, { recursive: true, force: true });
process.removeAllListeners('SIGTERM');
@@ -57,16 +59,19 @@ describe('#2661 β€” AI workers are opt-in', () => {
expect(daemon.getStatus().config.aiWorkersEnabled).toBe(true);
});
- it('enables via daemon.aiWorkers.enabled in .claude-flow/config.json', () => {
+ it('does NOT enable via daemon.aiWorkers.enabled in the project .claude-flow/config.json (a clone could set it)', () => {
+ const home = mkdtempSync(join(tmpdir(), 'daemon-2661-home-'));
+ vi.stubEnv('HOME', home);
+ vi.stubEnv('USERPROFILE', home);
writeFileSync(
join(tempDir, '.claude-flow', 'config.json'),
JSON.stringify({ 'daemon.aiWorkers.enabled': true })
);
const daemon = new WorkerDaemon(tempDir);
- expect(daemon.getStatus().config.aiWorkersEnabled).toBe(true);
+ expect(daemon.getStatus().config.aiWorkersEnabled).toBe(false);
});
- it('config.json false beats env opt-in precedence is flag > file > env', () => {
+ it('config.json false beats env opt-in; precedence is flag > file false > env > user config', () => {
process.env.RUFLO_DAEMON_AI_WORKERS = '1';
writeFileSync(
join(tempDir, '.claude-flow', 'config.json'),
diff --git a/v3/@claude-flow/cli/src/services/headless-worker-executor.ts b/v3/@claude-flow/cli/src/services/headless-worker-executor.ts
index 32c66f6f63..67c3390148 100644
--- a/v3/@claude-flow/cli/src/services/headless-worker-executor.ts
+++ b/v3/@claude-flow/cli/src/services/headless-worker-executor.ts
@@ -330,7 +330,7 @@ Provide a JSON report with:
sandbox: 'strict',
model: 'haiku',
outputFormat: 'json',
- contextPatterns: ['**/*.ts', '**/*.js', '**/.env*', '**/package.json'],
+ contextPatterns: ['**/*.ts', '**/*.js', '**/package.json'],
timeoutMs: 5 * 60 * 1000,
},
},
diff --git a/v3/@claude-flow/cli/src/services/worker-daemon.ts b/v3/@claude-flow/cli/src/services/worker-daemon.ts
index 61e6296b37..16910a133c 100644
--- a/v3/@claude-flow/cli/src/services/worker-daemon.ts
+++ b/v3/@claude-flow/cli/src/services/worker-daemon.ts
@@ -14,7 +14,7 @@
import { ConfigFileManager } from './config-file-manager.js';
import { EventEmitter } from 'events';
import { existsSync, mkdirSync, writeFileSync, readFileSync, appendFileSync, unlinkSync, renameSync } from 'fs';
-import { cpus } from 'os';
+import { cpus, homedir } from 'os';
import { join } from 'path';
import { createRequire } from 'node:module';
import { writeFileAtomic } from '../fs-secure.js';
@@ -235,6 +235,19 @@ function readEnvSecsAsMs(name: string, defaultMs: number): number {
/**
* Worker Daemon - Manages background workers with Node.js
*/
+/** `daemon.aiWorkers.enabled` from the USER-level config only (never the project's). */
+function readUserAiWorkersOptIn(): boolean | undefined {
+ try {
+ const raw = JSON.parse(readFileSync(join(homedir(), '.claude-flow', 'config.json'), 'utf-8'));
+ const nested = raw?.daemon?.aiWorkers?.enabled;
+ const dotted = raw?.['daemon.aiWorkers.enabled'];
+ const v = nested ?? dotted;
+ return typeof v === 'boolean' ? v : undefined;
+ } catch {
+ return undefined;
+ }
+}
+
export class WorkerDaemon extends EventEmitter {
private config: DaemonConfig;
private workers: Map<WorkerType, WorkerState> = new Map();
@@ -342,9 +355,15 @@ export class WorkerDaemon extends EventEmitter {
// #2661 β€” AI workers are opt-in: flag > config.json > env > OFF.
// Deliberately NOT restored from daemon-state.json (initializeWorkerStates
// whitelist) so a stale state file can never resurrect consent.
+ // SECURITY: the project's own config file is repo content and may come
+ // from a clone, so it can never switch AI workers on. Only the flag, the
+ // env var, or the user-level ~/.claude-flow/config.json can.
+ // A project file may still say `false` (it can only make this safer).
aiWorkersEnabled: config?.aiWorkersEnabled
- ?? fileConfig.aiWorkersEnabled
- ?? (process.env.RUFLO_DAEMON_AI_WORKERS === '1'),
+ ?? (fileConfig.aiWorkersEnabled === false ? false : undefined)
+ ?? (process.env.RUFLO_DAEMON_AI_WORKERS === '1' ? true : undefined)
+ ?? readUserAiWorkersOptIn()
+ ?? false,
workers: (config?.workers ?? DEFAULT_WORKERS).map(worker => ({ ...worker })),
enabledWorkers: config?.enabledWorkers,
};
@@ -398,7 +417,7 @@ export class WorkerDaemon extends EventEmitter {
if (!this.config.aiWorkersEnabled) {
this.log(
'info',
- 'AI workers disabled (default) - all workers run local-only. Enable with `daemon start --headless`, daemon.aiWorkers.enabled=true, or RUFLO_DAEMON_AI_WORKERS=1 (#2661)'
+ 'AI workers disabled (default) - all workers run local-only. Enable with `daemon start --headless`, daemon.aiWorkers.enabled=true in ~/.claude-flow/config.json (a project config cannot enable it), or RUFLO_DAEMON_AI_WORKERS=1 (#2661)'
);
return;
}