🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(workflow): let condition steps read a step's output (step-N.output) (#4530)
kevin754d77246204
diff --git a/v3/@claude-flow/cli/__tests__/workflow-condition-step-output.test.ts b/v3/@claude-flow/cli/__tests__/workflow-condition-step-output.test.tsnew file mode 100644index 0000000000..20f0b37aa4--- /dev/null+++ b/v3/@claude-flow/cli/__tests__/workflow-condition-step-output.test.ts@@ -0,0 +1,40 @@+import { afterEach, beforeEach, expect, it, vi } from 'vitest';+import { mkdtempSync, readFileSync, rmSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+const state = vi.hoisted(() => ({ cwd: '', execute: vi.fn() }));+vi.mock('../src/mcp-tools/types.js', () => ({ getProjectCwd: () => state.cwd }));+vi.mock('../src/mcp-tools/agent-execute-core.js', () => ({ executeAgentTask: state.execute }));+import { workflowTools } from '../src/mcp-tools/workflow-tools.js';+const call = (name: string, input: Record<string, unknown>) => workflowTools.find(t => t.name === name)!.handler(input) as Promise<any>;+const stepResults = (workflowId: string) => {+ const store = JSON.parse(readFileSync(join(state.cwd, '.claude-flow', 'workflows', 'store.json'), 'utf-8'));+ return store.workflows[workflowId].steps.map((s: { result?: unknown }) => s.result);+};+beforeEach(() => {+ state.cwd = mkdtempSync(join(tmpdir(), 'ruflo-workflow-condition-output-'));+ state.execute.mockReset().mockResolvedValue({ success: true, output: 'approved' });+});+afterEach(() => rmSync(state.cwd, { recursive: true, force: true }));++// A task step stores its output as `<stepId>.output`, and step ids default to+// `step-N`, so a condition must accept the same names `{{step-1.output}}` does.+it.each([+ ["step-1.output == 'approved'", true],+ ["step-1.output === 'rejected'", false],+])('evaluates a condition on a step output: %s', async (when, truthy) => {+ const created = await call('workflow_create', { name: 'review', steps: [+ { name: 'review', type: 'task', config: { agentId: 'reviewer', prompt: 'review it' } },+ { name: 'gate', type: 'condition', config: { when } },+ ] });+ expect(created).toMatchObject({ workflowId: expect.any(String) });+ expect(await call('workflow_execute', { workflowId: created.workflowId })).toMatchObject({ status: 'completed' });+ expect(stepResults(created.workflowId)[1]).toMatchObject({ conditionExpr: when, truthy });+});++it('still rejects a condition that is not a comparison', async () => {+ const created = await call('workflow_create', { name: 'gate', steps: [+ { name: 'gate', type: 'condition', config: { when: 'step-1.output' } },+ ] });+ expect(created).toMatchObject({ success: false, error: expect.stringContaining('config.when') });+});diff --git a/v3/@claude-flow/cli/src/mcp-tools/workflow-tools.ts b/v3/@claude-flow/cli/src/mcp-tools/workflow-tools.tsindex 8afccd7a07..e1099b8404 100644--- a/v3/@claude-flow/cli/src/mcp-tools/workflow-tools.ts+++ b/v3/@claude-flow/cli/src/mcp-tools/workflow-tools.ts@@ -56,7 +56,9 @@ function parseCondition(when: unknown): Condition | Error {if (expression === 'true' || expression === 'false') {return { constant: expression === 'true' };}- const match = expression.match(/^([a-zA-Z_]\w*)\s*===?\s*(?:'([^']*)'|"([^"]*)"|(-?\d+(?:\.\d+)?)|(true|false))$/);+ // Variable names follow the `{{…}}` interpolation syntax, so a condition can+ // read a task step's output, stored as `<stepId>.output` (`step-1.output`).+ const match = expression.match(/^([a-zA-Z_][\w.-]*)\s*===?\s*(?:'([^']*)'|"([^"]*)"|(-?\d+(?:\.\d+)?)|(true|false))$/);if (!match) {return new Error('condition config.when must compare a variable to a quoted string, number, or boolean using == or ===');}