Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

fix(retry): stop callbacks after attempts are exhausted

Rudy Celekli92a79e72e38b
diff --git a/tests/retry-exhausted-callbacks.test.mjs b/tests/retry-exhausted-callbacks.test.mjs
new file mode 100644
index 0000000000..62d626da6e
--- /dev/null
+++ b/tests/retry-exhausted-callbacks.test.mjs
@@ -0,0 +1,18 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import { withRetry } from '../v3/@claude-flow/cli/src/production/retry.ts';
+test('retry callbacks and history describe only actual retries', async () => {
+ for (const maxAttempts of [1, 3]) {
+ let calls = 0; const callbacks = [];
+ const result = await withRetry(async () => { calls++; throw new Error('failure'); }, { maxAttempts, initialDelayMs: 0, jitter: 0, shouldRetry: () => true, onRetry: (_, attempt) => callbacks.push(attempt) });
+ assert.equal(calls, maxAttempts);
+ assert.equal(result.success, false);
+ assert.equal(result.retryHistory.length, maxAttempts - 1);
+ assert.deepEqual(callbacks, Array.from({ length: maxAttempts - 1 }, (_, i) => i + 1));
+ }
+});
+test('successful retry preserves prior retry history', async () => {
+ let calls = 0;
+ const result = await withRetry(async () => { if (++calls === 1) throw new Error('transient'); return 42; }, { initialDelayMs: 0, jitter: 0, shouldRetry: () => true });
+ assert.equal(result.result, 42); assert.equal(result.retryHistory.length, 1);
+});
diff --git a/v3/@claude-flow/cli/src/production/retry.ts b/v3/@claude-flow/cli/src/production/retry.ts
index ef9134e9fd..b5ab6186f7 100644
--- a/v3/@claude-flow/cli/src/production/retry.ts
+++ b/v3/@claude-flow/cli/src/production/retry.ts
@@ -129,6 +129,9 @@ function shouldRetryError(
attempt: number,
config: RetryConfig
): boolean {
+ // Exhaustion always takes precedence over custom retry policies.
+ if (attempt >= config.maxAttempts) return false;
+
// Check custom retry function
if (config.shouldRetry) {
return config.shouldRetry(error, attempt);