🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(plugins): parameterize gnn.ts SQL generation to close SQL injection gap (#3564)
rUva3dee4ff8b7c
diff --git a/v3/@claude-flow/plugins/__tests__/gnn-sql-injection.test.ts b/v3/@claude-flow/plugins/__tests__/gnn-sql-injection.test.tsnew file mode 100644index 0000000000..8b94050ce7--- /dev/null+++ b/v3/@claude-flow/plugins/__tests__/gnn-sql-injection.test.ts@@ -0,0 +1,159 @@+import { describe, expect, it } from 'vitest';+import {+ GCNLayer,+ GraphOperations,+ GNNSQLGenerator,+} from '../src/integrations/ruvector/gnn.js';++// The *SQL() methods below are executed verbatim by a caller's query executor.+// TypeScript types do not exist at runtime, so any identifier (schema/table/+// column) or value (node id, algorithm name, ...) interpolated into the+// returned string must be validated. Before hardening, an identifier+// containing `"` or a value containing `'` could break out of the query.++describe('GNN toSQL/*SQL injection hardening', () => {+ describe('BaseGNNLayer#toSQL', () => {+ it('emits unchanged SQL for legitimate input', () => {+ const layer = new GCNLayer({ type: 'gcn', inputDim: 4, outputDim: 2 });+ const sql = layer.toSQL('nodes', { schema: 'app', edgeTable: 'edges', nodeColumn: 'vec' });+ expect(sql).toContain('FROM "app"."nodes"'.replace(/"/g, '"'));+ expect(sql).toContain('SELECT ruvector.gcn_layer(');+ expect(sql).toContain('array_agg("vec")');+ expect(sql).toContain('FROM "app"."edges"');+ });++ it('emits a $N placeholder for prepared statements with the default prefix', () => {+ const layer = new GCNLayer({ type: 'gcn', inputDim: 4, outputDim: 2 });+ const sql = layer.toSQL('nodes', { prepared: true });+ expect(sql).toContain('$1::jsonb');+ });++ it.each([+ ['schema', { schema: '"; DROP TABLE t; --' }],+ ['nodeColumn', { nodeColumn: 'x") ; DROP TABLE t; --' }],+ ['edgeTable', { edgeTable: 'x"."y' }],+ ])('rejects a malicious %s identifier', (_name, options) => {+ const layer = new GCNLayer({ type: 'gcn', inputDim: 4, outputDim: 2 });+ expect(() => layer.toSQL('nodes', options)).toThrow(TypeError);+ });++ it('rejects a malicious tableName identifier', () => {+ const layer = new GCNLayer({ type: 'gcn', inputDim: 4, outputDim: 2 });+ expect(() => layer.toSQL('nodes"; DROP TABLE t; --')).toThrow(TypeError);+ });++ it('rejects a malicious paramPrefix', () => {+ const layer = new GCNLayer({ type: 'gcn', inputDim: 4, outputDim: 2 });+ expect(() =>+ layer.toSQL('nodes', { prepared: true, paramPrefix: "'; DROP TABLE t; --" })+ ).toThrow(TypeError);+ });++ it('embeds config values that contain a single quote safely', () => {+ const layer = new GCNLayer({+ type: 'gcn',+ inputDim: 4,+ outputDim: 2,+ params: { note: "'; DROP TABLE t; --" },+ });+ const sql = layer.toSQL('nodes');+ // The quote must be doubled inside the jsonb literal, not break out of it.+ expect(sql).toContain("''; DROP TABLE t; --");+ expect(sql.match(/::jsonb/g)?.length).toBe(1);+ });+ });++ describe('GraphOperations SQL builders', () => {+ const ops = new GraphOperations();++ it('emits unchanged SQL for legitimate input', () => {+ const sql = ops.kHopNeighborsSQL('n1', 2, 'nodes', { schema: 'app', edgeTable: 'edges' });+ expect(sql).toContain("target_id = 'n1'");+ expect(sql).toContain('kh.depth < 2');+ expect(sql).toContain('FROM "app"."edges"');+ });++ it('escapes a single quote in nodeId as a literal, not a break-out', () => {+ const sql = ops.kHopNeighborsSQL("1' OR '1'='1", 2, 'nodes');+ expect(sql).toContain("'1'' OR ''1''=''1'");+ });++ it.each([+ ['schema', () => ops.kHopNeighborsSQL('n1', 2, 'nodes', { schema: 'a"; DROP TABLE t; --' })],+ ['edgeTable', () => ops.kHopNeighborsSQL('n1', 2, 'nodes', { edgeTable: 'e"; DROP TABLE t; --' })],+ ['k', () => ops.kHopNeighborsSQL('n1', Number.NaN, 'nodes')],+ ['k (non-integer)', () => ops.kHopNeighborsSQL('n1', 1.5, 'nodes')],+ ['nodeId (non-string)', () => ops.kHopNeighborsSQL(123 as never, 2, 'nodes')],+ ])('rejects a malicious/invalid %s', (_name, run) => {+ expect(run).toThrow(TypeError);+ });++ it('shortestPathSQL escapes source/target literals', () => {+ const sql = ops.shortestPathSQL("a' OR '1'='1", 'b', 'nodes');+ expect(sql).toContain("'a'' OR ''1''=''1'");+ });++ it('shortestPathSQL rejects a malicious edgeTable identifier', () => {+ expect(() =>+ ops.shortestPathSQL('a', 'b', 'nodes', { edgeTable: 'e"."other' })+ ).toThrow(TypeError);+ });++ it('pageRankSQL rejects non-finite damping/maxIterations', () => {+ expect(() => ops.pageRankSQL('nodes', { damping: Number.POSITIVE_INFINITY })).toThrow(TypeError);+ expect(() => ops.pageRankSQL('nodes', { maxIterations: 1.5 })).toThrow(TypeError);+ });++ it('communityDetectionSQL escapes the algorithm literal', () => {+ const sql = ops.communityDetectionSQL('nodes', {+ algorithm: "louvain'; DROP TABLE t; --" as never,+ });+ expect(sql).toContain("'louvain''; DROP TABLE t; --'");+ });++ it('communityDetectionSQL rejects a non-finite resolution', () => {+ expect(() =>+ ops.communityDetectionSQL('nodes', { algorithm: 'louvain', resolution: Number.NaN })+ ).toThrow(TypeError);+ });+ });++ describe('GNNSQLGenerator static SQL builders', () => {+ it('cacheEmbeddingsSQL/createCacheTableSQL reject malicious identifiers', () => {+ expect(() =>+ GNNSQLGenerator.cacheEmbeddingsSQL('nodes', 'cache"; DROP TABLE t; --')+ ).toThrow(TypeError);+ expect(() =>+ GNNSQLGenerator.createCacheTableSQL('cache"; DROP TABLE t; --', 128)+ ).toThrow(TypeError);+ });++ it('createCacheTableSQL rejects a non-positive dimension', () => {+ expect(() => GNNSQLGenerator.createCacheTableSQL('cache', 0)).toThrow(TypeError);+ expect(() => GNNSQLGenerator.createCacheTableSQL('cache', 1.5)).toThrow(TypeError);+ });++ it('createCacheTableSQL emits unchanged SQL for legitimate input', () => {+ const sql = GNNSQLGenerator.createCacheTableSQL('cache', 128, { schema: 'app' });+ expect(sql).toContain('embedding vector(128) NOT NULL');+ expect(sql).toContain('CREATE TABLE IF NOT EXISTS "app"."cache"');+ expect(sql).toContain('CREATE INDEX IF NOT EXISTS "cache_computed_at_idx"');+ });++ it('messagePassingSQL/graphPoolingSQL reject malicious identifiers', () => {+ expect(() =>+ GNNSQLGenerator.messagePassingSQL('nodes"; DROP TABLE t; --', 'mean')+ ).toThrow(TypeError);+ expect(() =>+ GNNSQLGenerator.graphPoolingSQL('nodes', 'mean', { nodeColumn: 'x") --' })+ ).toThrow(TypeError);+ });++ it('batchGNNSQL rejects a malicious tableName', () => {+ const layer = new GCNLayer({ type: 'gcn', inputDim: 4, outputDim: 2 });+ expect(() =>+ GNNSQLGenerator.batchGNNSQL([layer], 'nodes"; DROP TABLE t; --')+ ).toThrow(TypeError);+ });+ });+});diff --git a/v3/@claude-flow/plugins/src/integrations/ruvector/gnn.ts b/v3/@claude-flow/plugins/src/integrations/ruvector/gnn.tsindex a9a6c25ded..8a947b8c46 100644--- a/v3/@claude-flow/plugins/src/integrations/ruvector/gnn.ts+++ b/v3/@claude-flow/plugins/src/integrations/ruvector/gnn.ts@@ -263,6 +263,75 @@ export interface SQLGenerationOptions {readonly paramPrefix?: string;}+// ============================================================================+// SQL Safety Helpers+// ============================================================================+//+// The toSQL()/*SQL() methods below build SQL executed verbatim by a caller's+// query executor. TypeScript types are erased at runtime, so every value+// interpolated into a query string must be validated here: an identifier+// (schema/table/column) that contains `"` or a value that contains `'` would+// otherwise let a caller break out of the surrounding quotes.++/** Identifiers (schema/table/column names) must be plain SQL identifiers. */+const SQL_IDENT_RE = /^[A-Za-z_][A-Za-z0-9_]*$/;++/** Validate and double-quote a SQL identifier (schema, table, or column name). */+function sqlIdent(value: unknown, name: string): string {+ if (typeof value !== 'string' || !SQL_IDENT_RE.test(value)) {+ throw new TypeError(+ `gnn SQL: ${name} must match ${SQL_IDENT_RE} (got ${JSON.stringify(value)})`+ );+ }+ return `"${value}"`;+}++/** Validate a string and render it as a single-quoted SQL literal. */+function sqlLiteral(value: unknown, name: string): string {+ if (typeof value !== 'string') {+ throw new TypeError(`gnn SQL: ${name} must be a string (got ${JSON.stringify(value)})`);+ }+ return `'${value.replace(/'/g, "''")}'`;+}++/** Validate a finite number and render it as a bare SQL numeric literal. */+function sqlNumber(value: unknown, name: string): string {+ if (typeof value !== 'number' || !Number.isFinite(value)) {+ throw new TypeError(`gnn SQL: ${name} must be a finite number (got ${JSON.stringify(value)})`);+ }+ return String(value);+}++/** Validate a finite integer (optionally bounded) and render it as a bare SQL numeric literal. */+function sqlInt(value: unknown, name: string, opts: { min?: number } = {}): string {+ if (typeof value !== 'number' || !Number.isInteger(value)) {+ throw new TypeError(`gnn SQL: ${name} must be an integer (got ${JSON.stringify(value)})`);+ }+ if (opts.min !== undefined && value < opts.min) {+ throw new TypeError(`gnn SQL: ${name} must be >= ${opts.min} (got ${value})`);+ }+ return String(value);+}++/** Serialize a value to JSON and render it as a single-quoted SQL jsonb literal body. */+function sqlJson(value: unknown, name: string): string {+ let json: string;+ try {+ json = JSON.stringify(value) ?? 'null';+ } catch {+ throw new TypeError(`gnn SQL: ${name} could not be serialized to JSON`);+ }+ return `'${json.replace(/'/g, "''")}'`;+}++/** Validate a bind-parameter prefix used in prepared-statement placeholders (e.g. `$`). */+function sqlParamPrefix(value: unknown, name: string): string {+ if (typeof value !== 'string' || !/^[A-Za-z0-9_$:]{1,16}$/.test(value)) {+ throw new TypeError(`gnn SQL: ${name} must be a short alphanumeric token (got ${JSON.stringify(value)})`);+ }+ return value;+}+// ============================================================================// GNN Layer Registry// ============================================================================@@ -549,12 +618,15 @@ export abstract class BaseGNNLayer implements IGNNLayer {* Generate SQL for this layer.*/toSQL(tableName: string, options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const nodeColumn = options.nodeColumn ?? 'embedding';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const nodeColumn = sqlIdent(options.nodeColumn ?? 'embedding', 'nodeColumn');+ const table = sqlIdent(tableName, 'tableName');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');+ // Not attacker-reachable: `this.type` is always a key of GNN_SQL_FUNCTIONS+ // (or falls back to the fixed literal below), never caller-supplied text.const sqlFunction = GNN_SQL_FUNCTIONS[this.type] ?? 'ruvector.gnn_layer';- const configJson = JSON.stringify({+ const configObj = {type: this.type,input_dim: this.config.inputDim,output_dim: this.config.outputDim,@@ -566,23 +638,23 @@ export abstract class BaseGNNLayer implements IGNNLayer {use_bias: this.config.useBias,activation: this.config.activation,params: this.config.params,- });+ };if (options.prepared) {- const prefix = options.paramPrefix ?? '$';+ const prefix = sqlParamPrefix(options.paramPrefix ?? '$', 'paramPrefix');return `SELECT ${sqlFunction}(- (SELECT array_agg(${nodeColumn}) FROM "${schema}"."${tableName}"),- (SELECT array_agg(ARRAY[source_id, target_id]) FROM "${schema}"."${edgeTable}"),+ (SELECT array_agg(${nodeColumn}) FROM ${schema}.${table}),+ (SELECT array_agg(ARRAY[source_id, target_id]) FROM ${schema}.${edgeTable}),${prefix}1::jsonb);`.trim();}return `SELECT ${sqlFunction}(- (SELECT array_agg(${nodeColumn}) FROM "${schema}"."${tableName}"),- (SELECT array_agg(ARRAY[source_id, target_id]) FROM "${schema}"."${edgeTable}"),- '${configJson}'::jsonb+ (SELECT array_agg(${nodeColumn}) FROM ${schema}.${table}),+ (SELECT array_agg(ARRAY[source_id, target_id]) FROM ${schema}.${edgeTable}),+ ${sqlJson(configObj, 'config')}::jsonb);`.trim();}@@ -2651,38 +2723,42 @@ export class GraphOperations {* Generate SQL for k-hop neighbors query.*/kHopNeighborsSQL(nodeId: string, k: number, tableName: string, options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');+ const nodeIdLit = sqlLiteral(nodeId, 'nodeId');+ const depth = sqlInt(k, 'k', { min: 0 });return `WITH RECURSIVE k_hop AS (SELECT source_id AS node_id, 1 AS depth- FROM "${schema}"."${edgeTable}"- WHERE target_id = '${nodeId}'+ FROM ${schema}.${edgeTable}+ WHERE target_id = ${nodeIdLit}UNIONSELECT target_id AS node_id, 1 AS depth- FROM "${schema}"."${edgeTable}"- WHERE source_id = '${nodeId}'+ FROM ${schema}.${edgeTable}+ WHERE source_id = ${nodeIdLit}UNION ALLSELECT e.target_id AS node_id, kh.depth + 1FROM k_hop kh- JOIN "${schema}"."${edgeTable}" e ON kh.node_id = e.source_id- WHERE kh.depth < ${k}+ JOIN ${schema}.${edgeTable} e ON kh.node_id = e.source_id+ WHERE kh.depth < ${depth}UNION ALLSELECT e.source_id AS node_id, kh.depth + 1FROM k_hop kh- JOIN "${schema}"."${edgeTable}" e ON kh.node_id = e.target_id- WHERE kh.depth < ${k}+ JOIN ${schema}.${edgeTable} e ON kh.node_id = e.target_id+ WHERE kh.depth < ${depth})-SELECT DISTINCT node_id FROM k_hop WHERE node_id != '${nodeId}';`.trim();+SELECT DISTINCT node_id FROM k_hop WHERE node_id != ${nodeIdLit};`.trim();}/*** Generate SQL for shortest path query.*/shortestPathSQL(source: string, target: string, tableName: string, options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');+ const sourceLit = sqlLiteral(source, 'source');+ const targetLit = sqlLiteral(target, 'target');return `WITH RECURSIVE path AS (@@ -2692,8 +2768,8 @@ WITH RECURSIVE path AS (ARRAY[source_id, target_id] AS path,weight AS total_weight,1 AS depth- FROM "${schema}"."${edgeTable}"- WHERE source_id = '${source}'+ FROM ${schema}.${edgeTable}+ WHERE source_id = ${sourceLit}UNION ALLSELECTp.source_id,@@ -2702,13 +2778,13 @@ WITH RECURSIVE path AS (p.total_weight + e.weight,p.depth + 1FROM path p- JOIN "${schema}"."${edgeTable}" e ON p.target_id = e.source_id+ JOIN ${schema}.${edgeTable} e ON p.target_id = e.source_idWHERE NOT e.target_id = ANY(p.path)AND p.depth < 10)SELECT path, total_weightFROM path-WHERE target_id = '${target}'+WHERE target_id = ${targetLit}ORDER BY total_weightLIMIT 1;`.trim();}@@ -2717,14 +2793,14 @@ LIMIT 1;`.trim();* Generate SQL for PageRank computation.*/pageRankSQL(tableName: string, options: PageRankOptions & SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;- const damping = options.damping ?? 0.85;- const maxIterations = options.maxIterations ?? 100;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');+ const damping = sqlNumber(options.damping ?? 0.85, 'damping');+ const maxIterations = sqlInt(options.maxIterations ?? 100, 'maxIterations', { min: 1 });return `SELECT ruvector.page_rank(- (SELECT array_agg(ARRAY[source_id::text, target_id::text]) FROM "${schema}"."${edgeTable}"),+ (SELECT array_agg(ARRAY[source_id::text, target_id::text]) FROM ${schema}.${edgeTable}),${damping},${maxIterations});`.trim();@@ -2734,15 +2810,15 @@ SELECT ruvector.page_rank(* Generate SQL for community detection.*/communityDetectionSQL(tableName: string, options: CommunityOptions & SQLGenerationOptions): string {- const schema = options.schema ?? 'public';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;- const algorithm = options.algorithm ?? 'louvain';- const resolution = options.resolution ?? 1.0;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');+ const algorithm = sqlLiteral(options.algorithm ?? 'louvain', 'algorithm');+ const resolution = sqlNumber(options.resolution ?? 1.0, 'resolution');return `SELECT ruvector.community_detection(- (SELECT array_agg(ARRAY[source_id::text, target_id::text]) FROM "${schema}"."${edgeTable}"),- '${algorithm}',+ (SELECT array_agg(ARRAY[source_id::text, target_id::text]) FROM ${schema}.${edgeTable}),+ ${algorithm},${resolution});`.trim();}@@ -2775,9 +2851,10 @@ export class GNNSQLGenerator {tableName: string,options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const nodeColumn = options.nodeColumn ?? 'embedding';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const nodeColumn = sqlIdent(options.nodeColumn ?? 'embedding', 'nodeColumn');+ const table = sqlIdent(tableName, 'tableName');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');const layerConfigs = layers.map((l) => ({type: l.type,@@ -2791,9 +2868,9 @@ export class GNNSQLGenerator {return `SELECT ruvector.batch_gnn_forward(- (SELECT array_agg(${nodeColumn}) FROM "${schema}"."${tableName}"),- (SELECT array_agg(ARRAY[source_id, target_id]) FROM "${schema}"."${edgeTable}"),- '${JSON.stringify(layerConfigs)}'::jsonb+ (SELECT array_agg(${nodeColumn}) FROM ${schema}.${table}),+ (SELECT array_agg(ARRAY[source_id, target_id]) FROM ${schema}.${edgeTable}),+ ${sqlJson(layerConfigs, 'layerConfigs')}::jsonb);`.trim();}@@ -2805,15 +2882,18 @@ SELECT ruvector.batch_gnn_forward(cacheTable: string,options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const table = sqlIdent(tableName, 'tableName');+ const cache = sqlIdent(cacheTable, 'cacheTable');+ const nodeColumn = sqlIdent(options.nodeColumn ?? 'embedding', 'nodeColumn');return `-INSERT INTO "${schema}"."${cacheTable}" (node_id, embedding, computed_at)+INSERT INTO ${schema}.${cache} (node_id, embedding, computed_at)SELECTid,- ${options.nodeColumn ?? 'embedding'},+ ${nodeColumn},NOW()-FROM "${schema}"."${tableName}"+FROM ${schema}.${table}ON CONFLICT (node_id)DO UPDATE SETembedding = EXCLUDED.embedding,@@ -2828,19 +2908,21 @@ DO UPDATE SETdimension: number,options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const cache = sqlIdent(cacheTable, 'cacheTable');+ const dim = sqlInt(dimension, 'dimension', { min: 1 });return `-CREATE TABLE IF NOT EXISTS "${schema}"."${cacheTable}" (+CREATE TABLE IF NOT EXISTS ${schema}.${cache} (node_id TEXT PRIMARY KEY,- embedding vector(${dimension}) NOT NULL,+ embedding vector(${dim}) NOT NULL,computed_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),layer_config JSONB,version INTEGER DEFAULT 1);-CREATE INDEX IF NOT EXISTS "${cacheTable}_computed_at_idx"-ON "${schema}"."${cacheTable}" (computed_at);`.trim();+CREATE INDEX IF NOT EXISTS ${sqlIdent(`${cacheTable}_computed_at_idx`, 'cacheTable')}+ON ${schema}.${cache} (computed_at);`.trim();}/**@@ -2851,9 +2933,10 @@ ON "${schema}"."${cacheTable}" (computed_at);`.trim();aggregation: GNNAggregation,options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const nodeColumn = options.nodeColumn ?? 'embedding';- const edgeTable = options.edgeTable ?? `${tableName}_edges`;+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const nodeColumn = sqlIdent(options.nodeColumn ?? 'embedding', 'nodeColumn');+ const table = sqlIdent(tableName, 'tableName');+ const edgeTable = sqlIdent(options.edgeTable ?? `${tableName}_edges`, 'edgeTable');const aggFunctionMap: Record<GNNAggregation, string> = {mean: 'avg',@@ -2867,15 +2950,17 @@ ON "${schema}"."${cacheTable}" (computed_at);`.trim();std: 'std',var: 'var',};+ // Not attacker-reachable: `aggregation` is a GNNAggregation union member+ // (or falls back to the fixed 'avg' literal), never caller-supplied text.const aggFunction = aggFunctionMap[aggregation] ?? 'avg';return `SELECTn.id,ruvector.vector_${aggFunction}(array_agg(neighbor.${nodeColumn})) AS aggregated_embedding-FROM "${schema}"."${tableName}" n-LEFT JOIN "${schema}"."${edgeTable}" e ON n.id = e.target_id-LEFT JOIN "${schema}"."${tableName}" neighbor ON e.source_id = neighbor.id+FROM ${schema}.${table} n+LEFT JOIN ${schema}.${edgeTable} e ON n.id = e.target_id+LEFT JOIN ${schema}.${table} neighbor ON e.source_id = neighbor.idGROUP BY n.id;`.trim();}@@ -2887,9 +2972,12 @@ GROUP BY n.id;`.trim();poolingMethod: 'mean' | 'sum' | 'max' | 'attention',options: SQLGenerationOptions = {}): string {- const schema = options.schema ?? 'public';- const nodeColumn = options.nodeColumn ?? 'embedding';+ const schema = sqlIdent(options.schema ?? 'public', 'schema');+ const nodeColumn = sqlIdent(options.nodeColumn ?? 'embedding', 'nodeColumn');+ const table = sqlIdent(tableName, 'tableName');+ // Not attacker-reachable: `poolingMethod` maps through a fixed literal+ // table (or falls back to 'vector_avg'), never caller-supplied text.const poolFunction = {mean: 'vector_avg',sum: 'vector_sum',@@ -2899,7 +2987,7 @@ GROUP BY n.id;`.trim();return `SELECT ruvector.${poolFunction}(- (SELECT array_agg(${nodeColumn}) FROM "${schema}"."${tableName}")+ (SELECT array_agg(${nodeColumn}) FROM ${schema}.${table})) AS graph_embedding;`.trim();}}