Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

feat(doctor): integration-layer health check distinct from upstream (iter 45)

ruvca8741f4cdfa
diff --git a/plugins/ruflo-metaharness/scripts/smoke.sh b/plugins/ruflo-metaharness/scripts/smoke.sh
index 1e1b57f2e7..6a0ab83dc0 100755
--- a/plugins/ruflo-metaharness/scripts/smoke.sh
+++ b/plugins/ruflo-metaharness/scripts/smoke.sh
@@ -191,6 +191,23 @@ grep -q "execCli(\[\s*'-y'\s*,\s*'metaharness@latest'" "$F" 2>/dev/null || \
grep -q "cwd: opts" "$F" || miss="$miss no-cwd-passthrough"
[[ -z "$miss" ]] && ok || bad "$miss"
+step "17z8. ruflo doctor checks the integration layer, not just upstream (iter 45)"
+miss=""
+DOC="$ROOT/../../v3/@claude-flow/cli/src/commands/doctor.ts"
+# New function present
+grep -q "function checkMetaharnessIntegration" "$DOC" 2>/dev/null || miss="$miss no-integration-check"
+# Registered in allChecks
+grep -q "checkMetaharnessIntegration, // iter 45" "$DOC" 2>/dev/null || miss="$miss not-in-allchecks"
+# Alias in componentMap
+grep -q "'metaharness-integration': checkMetaharnessIntegration" "$DOC" 2>/dev/null || miss="$miss no-component-alias"
+# Verifies the 5 critical files
+for f in _harness _similarity similarity _spike-similarity harness-similarity; do
+ grep -q "${f}" "$DOC" 2>/dev/null || miss="$miss check-missing-${f}"
+done
+# Runtime smoke: similarity({}, {}) call present
+grep -q "mod.similarity({}, {})" "$DOC" 2>/dev/null || miss="$miss no-smoke-call"
+[[ -z "$miss" ]] && ok || bad "$miss"
+
step "17z7. MCP wrapper success semantic fix (iter 44 β€” exitCode is the source of truth)"
miss=""
WRAPPER="$ROOT/../../v3/@claude-flow/cli/src/mcp-tools/metaharness-tools.ts"
diff --git a/v3/@claude-flow/cli/src/commands/doctor.ts b/v3/@claude-flow/cli/src/commands/doctor.ts
index 6fa69d13bb..810b491bf9 100644
--- a/v3/@claude-flow/cli/src/commands/doctor.ts
+++ b/v3/@claude-flow/cli/src/commands/doctor.ts
@@ -556,6 +556,107 @@ async function checkVersionFreshness(): Promise<HealthCheck> {
// the standard ruflo doctor flow. Graceful degradation: when metaharness
// is not installed (no network, optionalDep skipped), the check returns
// `warn` with a hint instead of `fail` β€” ruflo continues to function.
+/**
+ * iter 45 β€” verify the ruflo-side MetaHarness integration is intact.
+ *
+ * The existing `checkMetaharness` verifies the UPSTREAM `metaharness`
+ * package is reachable (warn if missing β€” it's optional per ADR-150).
+ * This check verifies the INTEGRATION LAYER (plugin scripts, production
+ * module, subprocess bridge) is intact. Unlike upstream, the integration
+ * layer is shipped with ruflo β€” missing files mean ruflo's install is
+ * corrupted, not that an optional dep is absent.
+ *
+ * Status mapping:
+ * pass β€” all required files present + module loads + similarity() smoke OK
+ * fail β€” any required file missing OR module fails to import
+ * warn β€” files present but module import errored at runtime
+ *
+ * Verified files (iter 36-44 surfaces):
+ * - plugins/ruflo-metaharness/scripts/_harness.mjs (subprocess bridge)
+ * - plugins/ruflo-metaharness/scripts/_similarity.mjs (ADR-152 Β§3.1 module)
+ * - plugins/ruflo-metaharness/scripts/similarity.mjs (CLI skill)
+ * - plugins/ruflo-metaharness/skills/harness-similarity/SKILL.md
+ */
+async function checkMetaharnessIntegration(): Promise<HealthCheck> {
+ // Locate plugins dir using the same upward-walk pattern as
+ // metaharness-tools.ts::locatePluginScripts() and commands/metaharness.ts
+ const candidates: string[] = [];
+ let p = process.cwd();
+ for (let i = 0; i < 8; i++) {
+ candidates.push(join(p, 'plugins', 'ruflo-metaharness'));
+ p = dirname(p);
+ }
+ candidates.push(join(process.cwd(), 'node_modules', '@claude-flow', 'cli', 'plugins', 'ruflo-metaharness'));
+
+ let pluginDir: string | null = null;
+ for (const c of candidates) {
+ if (existsSync(join(c, 'scripts', '_harness.mjs'))) {
+ pluginDir = c;
+ break;
+ }
+ }
+
+ if (!pluginDir) {
+ return {
+ name: 'MetaHarness integration (ADR-150)',
+ status: 'fail',
+ message: 'plugins/ruflo-metaharness/ not found in expected locations',
+ fix: 'Reinstall ruflo: `npm i -g ruflo@latest`',
+ };
+ }
+
+ // Required files (iter 36+44 surfaces)
+ const required = [
+ 'scripts/_harness.mjs',
+ 'scripts/_similarity.mjs',
+ 'scripts/similarity.mjs',
+ 'scripts/_spike-similarity.mjs',
+ 'skills/harness-similarity/SKILL.md',
+ ];
+ const missing = required.filter((f) => !existsSync(join(pluginDir, f)));
+ if (missing.length > 0) {
+ return {
+ name: 'MetaHarness integration (ADR-150)',
+ status: 'fail',
+ message: `Missing files: ${missing.join(', ')}`,
+ fix: 'Reinstall ruflo or restore from git: `git checkout HEAD -- plugins/ruflo-metaharness/`',
+ };
+ }
+
+ // Runtime smoke: import the similarity module and exercise it
+ try {
+ const modPath = join(pluginDir, 'scripts', '_similarity.mjs');
+ const mod = await import(modPath) as { similarity?: (a: unknown, b: unknown) => { overall?: number } };
+ if (typeof mod.similarity !== 'function') {
+ return {
+ name: 'MetaHarness integration (ADR-150)',
+ status: 'fail',
+ message: '_similarity.mjs does not export similarity()',
+ fix: 'Reinstall ruflo or restore the file from git',
+ };
+ }
+ const result = mod.similarity({}, {});
+ if (typeof result?.overall !== 'number') {
+ return {
+ name: 'MetaHarness integration (ADR-150)',
+ status: 'warn',
+ message: 'similarity() returned unexpected shape; module may be stale',
+ };
+ }
+ return {
+ name: 'MetaHarness integration (ADR-150)',
+ status: 'pass',
+ message: 'plugin scripts intact, _similarity.mjs loads, smoke OK',
+ };
+ } catch (e) {
+ return {
+ name: 'MetaHarness integration (ADR-150)',
+ status: 'warn',
+ message: `Module import errored: ${(e as Error).message.slice(0, 60)}`,
+ };
+ }
+}
+
async function checkMetaharness(): Promise<HealthCheck> {
try {
const version = await runCommand('npx -y metaharness@latest --version 2>&1', 15000);
@@ -820,7 +921,8 @@ export const doctorCommand: Command = {
checkAgenticFlow,
checkEncryptionAtRest, // ADR-096 Phase 5
checkFederationBreaker, // ADR-097 Phase 4
- checkMetaharness, // ADR-150 β€” MetaHarness optional integration
+ checkMetaharness, // ADR-150 β€” MetaHarness upstream package
+ checkMetaharnessIntegration, // iter 45 β€” ruflo-side integration layer
];
const componentMap: Record<string, () => Promise<HealthCheck>> = {
@@ -841,7 +943,8 @@ export const doctorCommand: Command = {
'agentic-flow': checkAgenticFlow,
'encryption': checkEncryptionAtRest, // ADR-096 Phase 5
'federation': checkFederationBreaker, // ADR-097 Phase 4
- 'metaharness': checkMetaharness, // ADR-150 β€” MetaHarness optional integration
+ 'metaharness': checkMetaharness, // ADR-150 β€” upstream package
+ 'metaharness-integration': checkMetaharnessIntegration, // iter 45 β€” ruflo-side
};
let checksToRun = allChecks;