Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

fix(metaharness): fail unreadable oracle pin audits

Rudy Celeklid38c56337ada
diff --git a/scripts/check-metaharness-pins.mjs b/scripts/check-metaharness-pins.mjs
index cc266c120f..987d78d33a 100644
--- a/scripts/check-metaharness-pins.mjs
+++ b/scripts/check-metaharness-pins.mjs
@@ -168,13 +168,13 @@ async function main() {
}
// Lock-step: MH_DARWIN_PIN constant must satisfy the declared darwin range.
- let constRow = null;
+ let constRow = { name: 'MH_DARWIN_PIN (distill-oracle.ts)', pin: null, declared: declaredRange(pkg, '@metaharness/darwin').range ?? null, status: 'UNREADABLE' };
try {
const m = readFileSync(DISTILL, 'utf-8').match(/MH_DARWIN_PIN\s*=\s*['"]([^'"]+)['"]/);
const declared = declaredRange(pkg, '@metaharness/darwin').range;
if (m && declared) {
const inRange = satisfies(declared, m[1]);
- constRow = { name: 'MH_DARWIN_PIN (distill-oracle.ts)', pin: m[1], declared, status: inRange === false ? 'OUT-OF-RANGE' : 'in-range' };
+ constRow = { name: 'MH_DARWIN_PIN (distill-oracle.ts)', pin: m[1], declared, status: inRange === false ? 'OUT-OF-RANGE' : inRange === true ? 'in-range' : 'unparseable' };
}
} catch { /* non-fatal */ }
@@ -214,7 +214,7 @@ async function main() {
const pluginBad = pluginRows.filter((r) => ['NOT-COVERED', 'NOT-TILDE', 'UNREADABLE', 'STALE', 'unparseable'].includes(r.status));
const stale = rows.filter((r) => r.status === 'STALE' || r.status === 'UNDECLARED' || r.status === 'PEER-ONLY');
- const constBad = constRow && constRow.status === 'OUT-OF-RANGE';
+ const constBad = constRow.status !== 'in-range';
const apiErrors = [];
if (ARGS.requireInstalled) {
const cliDir = dirname(CLI_PKG);
diff --git a/tests/metaharness-oracle-pin.test.mjs b/tests/metaharness-oracle-pin.test.mjs
new file mode 100644
index 0000000000..9a7ea1cf95
--- /dev/null
+++ b/tests/metaharness-oracle-pin.test.mjs
@@ -0,0 +1,30 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import { mkdtempSync, mkdirSync, readFileSync, writeFileSync, rmSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { spawnSync } from 'node:child_process';
+const script = readFileSync(new URL('../scripts/check-metaharness-pins.mjs', import.meta.url), 'utf8');
+function run(source) {
+ const root = mkdtempSync(join(tmpdir(), 'oracle-pin-'));
+ try {
+ const cli = join(root, 'v3/@claude-flow/cli');
+ mkdirSync(join(root, 'scripts'), { recursive: true });
+ mkdirSync(join(cli, 'src/services'), { recursive: true });
+ mkdirSync(join(root, 'plugins/ruflo-metaharness/scripts'), { recursive: true });
+ writeFileSync(join(root, 'scripts/check-metaharness-pins.mjs'), script);
+ const dependencies = Object.fromEntries(['metaharness', '@metaharness/router', '@metaharness/darwin', '@metaharness/flywheel', '@metaharness/radio', '@metaharness/turn-credit'].map(name => [name, '~1.2.3']));
+ writeFileSync(join(cli, 'package.json'), JSON.stringify({ dependencies }));
+ if (source !== null) writeFileSync(join(cli, 'src/services/distill-oracle.ts'), source);
+ for (const [file, name] of [['_harness.mjs','METAHARNESS'],['_darwin.mjs','DARWIN'],['_redblue.mjs','REDBLUE']]) writeFileSync(join(root, 'plugins/ruflo-metaharness/scripts', file), `const ${name}_PIN_VERSION = '~1.2.3';`);
+ const result = spawnSync(process.execPath, [join(root, 'scripts/check-metaharness-pins.mjs'), '--offline', '--format', 'json'], { encoding: 'utf8' });
+ return { status: result.status, payload: JSON.parse(result.stdout) };
+ } finally { rmSync(root, { recursive: true, force: true }); }
+}
+test('missing and unreadable oracle constants fail the offline lock-step check', () => {
+ for (const source of [null, 'export const unrelated = 1;']) { const r = run(source); assert.equal(r.status, 1); assert.equal(r.payload.constCheck.status, 'UNREADABLE'); }
+});
+test('an unparseable oracle version fails instead of reporting in-range', () => {
+ const r = run("const MH_DARWIN_PIN = 'invalid';"); assert.equal(r.status, 1); assert.equal(r.payload.constCheck.status, 'unparseable');
+});
+test('valid oracle pin remains accepted offline', () => { const r = run("const MH_DARWIN_PIN = '1.2.3';"); assert.equal(r.status, 0); });