🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(adr): avoid repeated directory traversal through cycles
Rudy Celeklie1f2937b5ebd
diff --git a/plugins/ruflo-adr/scripts/lib/parse-adrs.mjs b/plugins/ruflo-adr/scripts/lib/parse-adrs.mjsindex c4d3040433..f356d1ac3c 100644--- a/plugins/ruflo-adr/scripts/lib/parse-adrs.mjs+++ b/plugins/ruflo-adr/scripts/lib/parse-adrs.mjs@@ -6,7 +6,7 @@// Pure functions only — no memory_store / subprocess calls live here. Callers// own persistence.-import { readFileSync, readdirSync, statSync } from 'node:fs';+import { readFileSync, readdirSync, statSync, realpathSync } from 'node:fs';import { join, basename } from 'node:path';// #2474 bonus: `.claude/worktrees/*` mirrors the repo so every ADR was@@ -36,7 +36,11 @@ export function normalizeAdrId(raw) {return digits.length >= 4 ? `ADR-${digits}` : `ADR-${digits.padStart(3, '0')}`;}-export function findAdrs(dir, out = []) {+export function findAdrs(dir, out = [], visited = new Set()) {+ let canonical;+ try { canonical = realpathSync(dir); } catch { return out; }+ if (visited.has(canonical)) return out;+ visited.add(canonical);let entries;try { entries = readdirSync(dir); } catch { return out; }for (const e of entries) {@@ -45,7 +49,7 @@ export function findAdrs(dir, out = []) {let st;try { st = statSync(p); } catch { continue; }if (st.isDirectory()) {- findAdrs(p, out);+ findAdrs(p, out, visited);} else if (e.endsWith('.md') && (p.includes('/docs/adr/') || p.includes('/docs/adrs/'))) {out.push(p);}diff --git a/tests/adr-directory-cycle-scan.test.mjs b/tests/adr-directory-cycle-scan.test.mjsnew file mode 100644index 0000000000..1fdc3eec3d--- /dev/null+++ b/tests/adr-directory-cycle-scan.test.mjs@@ -0,0 +1,14 @@+import { test } from 'node:test';+import assert from 'node:assert/strict';+import { mkdtempSync, mkdirSync, writeFileSync, symlinkSync, rmSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { findAdrs } from '../plugins/ruflo-adr/scripts/lib/parse-adrs.mjs';+test('directory cycles enumerate each real ADR once and scans remain independent',()=>{+ const root=mkdtempSync(join(tmpdir(),'adr-cycle-'));+ try{+ const adr=join(root,'docs','adr');mkdirSync(adr,{recursive:true});+ writeFileSync(join(adr,'001-example.md'),'# Example');symlinkSync(adr,join(adr,'loop'),'dir');+ assert.equal(findAdrs(root).length,1);assert.equal(findAdrs(root).length,1);+ }finally{rmSync(root,{recursive:true,force:true});}+});