🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(init): stop granting blanket execution of project helpers (#4221)
xjhf04ce8df1ce2
diff --git a/v3/@claude-flow/cli/__tests__/settings-helper-permission-4205.test.ts b/v3/@claude-flow/cli/__tests__/settings-helper-permission-4205.test.tsnew file mode 100644index 0000000000..f2ae3a80ba--- /dev/null+++ b/v3/@claude-flow/cli/__tests__/settings-helper-permission-4205.test.ts@@ -0,0 +1,45 @@+import { afterEach, describe, expect, it } from 'vitest';+import { mkdtempSync, readFileSync, rmSync } from 'node:fs';+import { tmpdir } from 'node:os';+import { join } from 'node:path';+import { DEFAULT_INIT_OPTIONS, MINIMAL_INIT_OPTIONS } from '../src/init/types.js';+import { generateSettingsJson } from '../src/init/settings-generator.js';+import { executeUpgrade, mergeSettingsForUpgrade } from '../src/init/executor.js';++const roots: string[] = [];+afterEach(() => {+ for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });+});++const broadHelperPermission = 'Bash(node .claude/*)';++describe('#4205 generated helper permissions', () => {+ it.each([+ ['standard', DEFAULT_INIT_OPTIONS],+ ['minimal', MINIMAL_INIT_OPTIONS],+ ] as const)('%s settings do not pre-authorize arbitrary project scripts', (_name, options) => {+ const settings = JSON.parse(generateSettingsJson(options));+ expect(settings.permissions.allow).not.toContain(broadHelperPermission);+ expect(settings.permissions.allow).toContain('mcp__claude-flow__*');+ expect(settings.permissions.deny).toContain('Read(./.env)');+ if (options.components.helpers) {+ expect(settings.hooks.SessionStart[0].hooks[0].command).toContain('hook-handler.cjs');+ }+ });++ it('creates upgrade settings without adding a blanket helper permission', async () => {+ const cwd = mkdtempSync(join(tmpdir(), 'ruflo-4205-'));+ roots.push(cwd);+ const result = await executeUpgrade(cwd, true);+ expect(result.success).toBe(true);+ const settings = JSON.parse(readFileSync(join(cwd, '.claude', 'settings.json'), 'utf-8'));+ expect(settings.permissions.allow).not.toContain(broadHelperPermission);+ expect(settings.hooks.SessionStart[0].hooks[0].command).toContain('hook-handler.cjs');+ });++ it('preserves explicit permissions already present in user settings during upgrade', () => {+ const permissions = { allow: [broadHelperPermission, 'Bash(npm test)'], deny: ['Read(private/**)'] };+ const { merged } = mergeSettingsForUpgrade({ permissions });+ expect(merged.permissions).toEqual(permissions);+ });+});diff --git a/v3/@claude-flow/cli/src/init/settings-generator.ts b/v3/@claude-flow/cli/src/init/settings-generator.tsindex 467b7a9a78..d9729defd0 100644--- a/v3/@claude-flow/cli/src/init/settings-generator.ts+++ b/v3/@claude-flow/cli/src/init/settings-generator.ts@@ -33,7 +33,6 @@ export function generateSettings(options: InitOptions): object {allow: ['Bash(npx @claude-flow*)','Bash(npx claude-flow*)',- 'Bash(node .claude/*)','mcp__claude-flow__*',],deny: [