🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated
TypeScript agentic-aiagentic-frameworkagentic-workflowagentsai-agentsai-assistantai-skillsautonomous-agentsclaudecodexdsh-pluginharnessmcp-servermulti-agentmulti-agent-systemsnpmskillsswarmswarm-intelligencetypescript
fix(config): isolate nested default values (#3595)
Rudy Celeklif0f9fe852bee
diff --git a/v3/@claude-flow/cli/__tests__/config-default-isolation.test.ts b/v3/@claude-flow/cli/__tests__/config-default-isolation.test.tsnew file mode 100644index 0000000000..61952af2c7--- /dev/null+++ b/v3/@claude-flow/cli/__tests__/config-default-isolation.test.ts@@ -0,0 +1,81 @@+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';+import { existsSync, mkdtempSync, mkdirSync, readFileSync, rmSync } from 'node:fs';+import { join } from 'node:path';+import { tmpdir } from 'node:os';++let root: string;+let Manager: typeof import('../src/services/config-file-manager.js').ConfigFileManager;+beforeEach(async () => {+ // Reset the source module so each pre-fix failure cannot contaminate another test.+ vi.resetModules();+ ({ ConfigFileManager: Manager } = await import('../src/services/config-file-manager.js'));+ vi.stubEnv('CLAUDE_FLOW_CONFIG', '');+ root = mkdtempSync(join(tmpdir(), 'config-default-isolation-'));+});+afterEach(() => { vi.unstubAllEnvs(); rmSync(root, { recursive: true, force: true }); });+function project(name: string): string { const dir = join(root, name); mkdirSync(dir); return dir; }+function disk(dir: string): any { return JSON.parse(readFileSync(join(dir, 'claude-flow.config.json'), 'utf8')); }++describe('default configuration ownership', () => {+ it('creates independent project files after a different manager changes a nested default', () => {+ const a = project('a'), b = project('b');+ const first = new Manager(); first.create(a);+ first.set(a, 'memory.persistPath', './a-only-memory');+ const second = new Manager(); second.create(b);+ expect(disk(a).memory.persistPath).toBe('./a-only-memory');+ expect(disk(b).memory.persistPath).toBe('./data/memory');+ expect(second.getDefaults().memory).toHaveProperty('persistPath', './data/memory');+ });++ it('returns independent nested objects and arrays from getDefaults', () => {+ const first = new Manager().getDefaults() as any;+ first.memory.persistPath = './changed'; first.agents.providers.push('custom'); first.mcp.tools.push('tool');+ const second = new Manager().getDefaults() as any;+ expect(second.memory.persistPath).toBe('./data/memory');+ expect(second.agents.providers).toEqual([]); expect(second.mcp.tools).toEqual([]);+ });++ it('does not expose the template through missing-file getConfig fallbacks', () => {+ const a = project('a'), b = project('b'); const manager = new Manager();+ const fallback = manager.getConfig(a) as any;+ fallback.memory.persistPath = './fallback-only'; fallback.hooks.hooks.push('custom');+ expect((manager.getConfig(a) as any).memory.persistPath).toBe('./data/memory');+ expect((new Manager().getConfig(b) as any).hooks.hooks).toEqual([]);+ expect(existsSync(join(a, 'claude-flow.config.json'))).toBe(false);+ });++ it('resets a changed project to the original defaults on disk and in memory', () => {+ const a = project('a'); const manager = new Manager(); manager.create(a);+ manager.set(a, 'memory.persistPath', './custom'); manager.set(a, 'agents.maxConcurrent', 0);+ manager.reset(a);+ expect(disk(a).memory.persistPath).toBe('./data/memory');+ expect(disk(a).agents.maxConcurrent).toBe(8);+ expect(manager.get(a, 'memory.persistPath')).toBe('./data/memory');+ });++ it('keeps reset-derived cached arrays isolated from later new projects', () => {+ const a = project('a'), b = project('b'); const first = new Manager(); first.reset(a);+ (first.getConfig(a) as any).agents.providers.push('reset-only');+ new Manager().create(b);+ expect(disk(b).agents.providers).toEqual([]);+ expect((new Manager().getDefaults() as any).agents.providers).toEqual([]);+ });++ it('keeps create-derived cached arrays isolated from later new projects', () => {+ const a = project('a'), b = project('b'); const first = new Manager(); first.create(a);+ (first.getConfig(a) as any).hooks.hooks.push('project-only');+ new Manager().create(b);+ expect(disk(b).hooks.hooks).toEqual([]);+ });++ it('preserves shallow override semantics and arbitrary caller-owned values', () => {+ const a = project('a'); const custom = { run: () => 'caller function', name: 'keep' };+ const memory = { persistPath: './override-only' }; const manager = new Manager();+ manager.create(a, { memory, custom });+ expect(manager.getConfig(a).memory).toBe(memory);+ expect(manager.getConfig(a).custom).toBe(custom);+ expect(disk(a).memory).toEqual({ persistPath: './override-only' });+ expect(disk(a).custom).toEqual({ name: 'keep' });+ expect((new Manager().getDefaults() as any).memory.persistPath).toBe('./data/memory');+ });+});diff --git a/v3/@claude-flow/cli/src/services/config-file-manager.ts b/v3/@claude-flow/cli/src/services/config-file-manager.tsindex 2d8d66f3fa..0b3cc0c7da 100644--- a/v3/@claude-flow/cli/src/services/config-file-manager.ts+++ b/v3/@claude-flow/cli/src/services/config-file-manager.ts@@ -110,7 +110,7 @@ export class ConfigFileManager {if (this.config === null) {this.load(cwd);}- return this.config ?? { ...DEFAULT_CONFIG };+ return this.config ?? structuredClone(DEFAULT_CONFIG);}/** Get a nested config value by dot-separated key */@@ -145,7 +145,7 @@ export class ConfigFileManager {if (fs.existsSync(targetPath) && !force) {throw new Error(`Config file already exists: ${targetPath}. Use --force to overwrite.`);}- const config = { ...DEFAULT_CONFIG, ...overrides };+ const config = { ...structuredClone(DEFAULT_CONFIG), ...overrides };this.writeAtomic(targetPath, config);this.config = config;this.configPath = targetPath;@@ -155,8 +155,9 @@ export class ConfigFileManager {/** Reset config to defaults */reset(cwd: string): string {const targetPath = this.configPath ?? path.resolve(cwd, CONFIG_FILENAMES[0]);- this.writeAtomic(targetPath, DEFAULT_CONFIG);- this.config = { ...DEFAULT_CONFIG };+ const config = structuredClone(DEFAULT_CONFIG);+ this.writeAtomic(targetPath, config);+ this.config = config;this.configPath = targetPath;return targetPath;}@@ -197,7 +198,7 @@ export class ConfigFileManager {/** Get default config */getDefaults(): Record<string, unknown> {- return { ...DEFAULT_CONFIG };+ return structuredClone(DEFAULT_CONFIG);}/** Atomic write: write to .tmp then rename */