Skip to content

armgit / ruflo

Public Imported from GitHub
0

🌊 The original agent harness. Deploy intelligent multi-player swarms, coordinate autonomous workflows, and build conversational AI systems. Features adaptive memory, self-learning intelligence, federation, vector RAG integration, and native Claude Code / Codex / Hermes and many more Integrated

fix(cli): preserve settled worker task outcomes

Rudy Celeklife5ad5cce152
diff --git a/v3/@claude-flow/cli/__tests__/worker-queue-terminal-outcomes.test.ts b/v3/@claude-flow/cli/__tests__/worker-queue-terminal-outcomes.test.ts
new file mode 100644
index 0000000000..e5357687a0
--- /dev/null
+++ b/v3/@claude-flow/cli/__tests__/worker-queue-terminal-outcomes.test.ts
@@ -0,0 +1,52 @@
+import { afterEach, describe, it, expect } from 'vitest';
+import { WorkerQueue } from '../src/services/worker-queue.js';
+import type { HeadlessExecutionResult } from '../src/services/headless-worker-executor.js';
+const queues: WorkerQueue[] = [];
+afterEach(async () => {
+ for (const queue of queues.splice(0)) await queue.shutdown();
+});
+function create() {
+ const queue = new WorkerQueue();
+ queues.push(queue);
+ return queue;
+}
+const result: HeadlessExecutionResult = {
+ success: true,
+ output: 'done',
+ durationMs: 1,
+ model: 'test',
+ sandboxMode: 'strict',
+ workerType: 'audit',
+ timestamp: new Date(),
+ executionId: 'test',
+};
+describe('settled worker task outcomes', () => {
+ it('does not overwrite a terminal failure with a late success', async () => {
+ const queue = create();
+ const id = await queue.enqueue('audit');
+ await queue.dequeue(['audit']);
+ await queue.fail(id, 'shutdown', false);
+ await queue.complete(id, result);
+ expect((await queue.getTask(id))?.status).toBe('failed');
+ expect(await queue.getResult(id)).toBeNull();
+ });
+ it('does not requeue an already completed task after a duplicate failure', async () => {
+ const queue = create();
+ const id = await queue.enqueue('audit');
+ await queue.dequeue(['audit']);
+ await queue.complete(id, result);
+ await queue.fail(id, 'late failure');
+ expect((await queue.getTask(id))?.status).toBe('completed');
+ expect(await queue.getResult(id)).toBe(result);
+ expect((await queue.getStats()).pending).toBe(0);
+ });
+ it('preserves a cancelled task when a delayed outcome arrives', async () => {
+ const queue = create();
+ const id = await queue.enqueue('audit');
+ await queue.cancel(id);
+ await queue.complete(id, result);
+ await queue.fail(id, 'late failure', false);
+ expect((await queue.getTask(id))?.status).toBe('cancelled');
+ expect(await queue.getResult(id)).toBeNull();
+ });
+});
diff --git a/v3/@claude-flow/cli/src/services/worker-queue.ts b/v3/@claude-flow/cli/src/services/worker-queue.ts
index 8f31a73924..41bc17e109 100644
--- a/v3/@claude-flow/cli/src/services/worker-queue.ts
+++ b/v3/@claude-flow/cli/src/services/worker-queue.ts
@@ -397,6 +397,11 @@ export class WorkerQueue extends EventEmitter {
return;
}
+ // Late or duplicate outcomes must not rewrite a settled task.
+ if (['completed', 'failed', 'timeout', 'cancelled'].includes(task.status)) {
+ return;
+ }
+
task.status = 'completed';
task.completedAt = new Date();
task.result = result;
@@ -419,6 +424,11 @@ export class WorkerQueue extends EventEmitter {
return;
}
+ // Late or duplicate outcomes must not rewrite a settled task.
+ if (['completed', 'failed', 'timeout', 'cancelled'].includes(task.status)) {
+ return;
+ }
+
this.processingTasks.delete(taskId);
// Check if we should retry