Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Zod validation

Edward Cui262e19107317
diff --git a/server/src/api/importData.ts b/server/src/api/importData.ts
index 5b44cde69..eb3ec083b 100644
--- a/server/src/api/importData.ts
+++ b/server/src/api/importData.ts
@@ -17,7 +17,7 @@ const importRequestSchema = z.object({
body: z.object({
source: z.enum(["umami"]),
}),
-});
+}).strict();
type ImportRequest = {
Params: z.infer<typeof importRequestSchema.shape.params>;
@@ -29,13 +29,21 @@ export async function importData(
reply: FastifyReply,
) {
try {
- const { site } = request.params;
- const { source } = request.body;
+ const parsed = importRequestSchema.safeParse({
+ params: request.params,
+ body: request.body,
+ });
- if (!source) {
- return reply.status(400).send({ error: "Missing 'source' in request body." });
+ if (!parsed.success) {
+ return reply.status(400).send({
+ error: "Validation failed",
+ details: parsed.error.flatten(),
+ });
}
+ const { site } = parsed.data.params;
+ const { source } = parsed.data.body;
+
const userHasAccess = await getUserHasAccessToSite(request, site);
if (!userHasAccess) {
return reply.status(403).send({ error: "Forbidden" });