Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Refactor deleteSite function to remove redundant database deletion call. Consolidated site removal logic to ensure all associated data is deleted in a single operation, enhancing code clarity and maintainability.

Bill Yang29f86c065a3b
diff --git a/server/src/api/sites/deleteSite.ts b/server/src/api/sites/deleteSite.ts
index 8f1f89415..7ba089bbd 100644
--- a/server/src/api/sites/deleteSite.ts
+++ b/server/src/api/sites/deleteSite.ts
@@ -14,7 +14,6 @@ export async function deleteSite(request: FastifyRequest<{ Params: { siteId: str
// });
await Promise.all([
- db.delete(sites).where(eq(sites.siteId, Number(id))),
clickhouse.command({
query: "DELETE FROM session_replay_events WHERE site_id = {id:UInt32}",
query_params: { id: Number(id) },
@@ -23,9 +22,9 @@ export async function deleteSite(request: FastifyRequest<{ Params: { siteId: str
query: "DELETE FROM session_replay_metadata WHERE site_id = {id:UInt32}",
query_params: { id: Number(id) },
}),
+ siteConfig.removeSite(Number(id))
]);
- siteConfig.removeSite(Number(id));
return reply.status(200).send({ success: true });
}