Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Simplify BullMQ adapter by removing explicit ioredis instantiation

Edward Cui4a0dac2bd181
diff --git a/server/package-lock.json b/server/package-lock.json
index 5e0ed6b28..5786925d1 100644
--- a/server/package-lock.json
+++ b/server/package-lock.json
@@ -29,7 +29,6 @@
"drizzle-orm": "0.43.1",
"fastify": "5.3.3",
"fastify-better-auth": "1.1.0",
- "ioredis": "^5.4.2",
"ip-address": "^10.0.1",
"isbot": "^5.1.28",
"luxon": "3.6.1",
diff --git a/server/package.json b/server/package.json
index 6ceebe02c..c0668572b 100644
--- a/server/package.json
+++ b/server/package.json
@@ -41,7 +41,6 @@
"better-auth": "1.3.27",
"bullmq": "^5.56.5",
"dotenv": "16.5.0",
- "ioredis": "^5.4.2",
"drizzle-orm": "0.43.1",
"fastify": "5.3.3",
"fastify-better-auth": "1.1.0",
diff --git a/server/src/queues/adapters/bullMQAdapter.ts b/server/src/queues/adapters/bullMQAdapter.ts
index 3a9b3ec21..e7605f2e1 100644
--- a/server/src/queues/adapters/bullMQAdapter.ts
+++ b/server/src/queues/adapters/bullMQAdapter.ts
@@ -1,40 +1,23 @@
import { Job, Queue, QueueEvents, Worker } from "bullmq";
-import type { Redis as RedisType } from "ioredis";
-import RedisModule from "ioredis";
import { IJobQueue, JobConfig, JobData, JobResult } from "../jobQueue.js";
-// Extract the Redis constructor for NodeNext module resolution
-const Redis = RedisModule.default || RedisModule;
-
export class BullMQAdapter implements IJobQueue {
- private connection: RedisType;
+ private readonly connection: { host: string; port: number; password?: string };
private queues: Map<string, Queue> = new Map();
private workers: Map<string, Worker> = new Map();
private queueEvents: Map<string, QueueEvents> = new Map();
constructor() {
- this.connection = new Redis({
+ this.connection = {
host: process.env.REDIS_HOST || "localhost",
port: parseInt(process.env.REDIS_PORT || "6379", 10),
- password: process.env.REDIS_PASSWORD,
- maxRetriesPerRequest: null,
- retryStrategy: (times: number) => {
- return Math.min(times * 50, 2000);
- },
- });
+ ...(process.env.REDIS_PASSWORD && { password: process.env.REDIS_PASSWORD }),
+ };
- this.connection.on("error", (error: Error) => {
- console.error("[BullMQ] Redis connection error:", error);
- });
-
- this.connection.on("connect", () => {
- console.info("[BullMQ] Connected to Redis");
- });
+ console.info(`[BullMQ] Configuration: Redis at ${this.connection.host}:${this.connection.port}`);
}
async start(): Promise<void> {
- // Verify Redis connection
- await this.connection.ping();
console.info("[BullMQ] Started successfully");
}
@@ -49,12 +32,10 @@ export class BullMQAdapter implements IJobQueue {
await Promise.all(Array.from(this.queueEvents.values()).map(qe => qe.close()));
this.queueEvents.clear();
- // Close all queues
+ // Close all queues (this closes their Redis connections)
await Promise.all(Array.from(this.queues.values()).map(queue => queue.close()));
this.queues.clear();
- // Close Redis connection
- await this.connection.quit();
console.info("[BullMQ] Stopped successfully");
}